From: Joel Brobecker <brobecker@adacore.com>
To: gdb@sourceware.org
Subject: Re: FTR: this GDB patch is AdaCore-local (R907-036: do not suppress all symbols in the STRUCT_DOMAIN)
Date: Sun, 1 Nov 2020 10:04:49 +0400 [thread overview]
Message-ID: <20201101060449.GA1860282@adacore.com> (raw)
In-Reply-To: <20201101060130.GA1859832@adacore.com>
And this is, children, the reason why one should never work on weekends :-(.
I apologize for the noise.
> Just recording the fact that the following patch...
>
> | commit 0bf64e2236bd6a2aacb978e5a7fa0a5b43567665
> | Subject: (Ada) do not suppress all symbols in the STRUCT_DOMAIN
> | Author: Joel Brobecker <brobecker@adacore.com>
> | Date: 2018-09-25 14:52:01 -0700
> | Subject: (Ada) do not suppress all symbols in the STRUCT_DOMAIN
>
> cannot be contributed upstream, because it touches a function
> (ada_suppress_symbol_printing) which is specific to the AdaCore
> version of GDB.
>
> This is from memory, but I believe we tried to contribute this function
> (combined with its companion function called is_suppressed_name), and
> got feedback that we should be doing it differently, relying on DWARF
> rather than GNAT encodings to determine whether symbols should be
> displayed or not.
>
> I will annotate the commit accordingly.
--
Joel
prev parent reply other threads:[~2020-11-01 6:04 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-01 6:01 Joel Brobecker
2020-11-01 6:04 ` Joel Brobecker [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201101060449.GA1860282@adacore.com \
--to=brobecker@adacore.com \
--cc=gdb@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).