public inbox for gdb@sourceware.org
 help / color / mirror / Atom feed
* Microblaze simulator - Fix missing prototype
@ 2012-05-07 20:23 Joel Sherrill
  2012-05-15 13:41 ` Michael Eager
  0 siblings, 1 reply; 2+ messages in thread
From: Joel Sherrill @ 2012-05-07 20:23 UTC (permalink / raw)
  To: gdb

[-- Attachment #1: Type: text/plain, Size: 581 bytes --]

Without this patch, this generates a missing prototype
warning which is treated as an error. I don't see this
routine referenced elsewhere, so there is the possibility
that it also could be made static.

OK to apply?

2012-05-12  Joel Sherrill <joel.sherrill@oarcorp.com>

     * microblaze-rom.c (_initialize_picobug_rom): Add prototype.

-- 
Joel Sherrill, Ph.D.             Director of Research&   Development
joel.sherrill@OARcorp.com        On-Line Applications Research
Ask me about RTEMS: a free RTOS  Huntsville AL 35805
     Support Available             (256) 722-9985



[-- Attachment #2: gdb-prototype.diff --]
[-- Type: text/x-patch, Size: 561 bytes --]

Index: gdb/microblaze-rom.c
===================================================================
RCS file: /cvs/src/src/gdb/microblaze-rom.c,v
retrieving revision 1.5
diff -u -r1.5 microblaze-rom.c
--- gdb/microblaze-rom.c	4 Jan 2012 08:17:06 -0000	1.5
+++ gdb/microblaze-rom.c	7 May 2012 20:15:54 -0000
@@ -25,6 +25,8 @@
 #include "serial.h"
 #include "regcache.h"
 
+void _initialize_picobug_rom(void);
+
 static char *picobug_inits[] =
 {"\r", NULL};
 
@@ -174,7 +176,7 @@
 }
 
 void
-_initialize_picobug_rom ()
+_initialize_picobug_rom (void)
 {
   int i;
 

^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: Microblaze simulator - Fix missing prototype
  2012-05-07 20:23 Microblaze simulator - Fix missing prototype Joel Sherrill
@ 2012-05-15 13:41 ` Michael Eager
  0 siblings, 0 replies; 2+ messages in thread
From: Michael Eager @ 2012-05-15 13:41 UTC (permalink / raw)
  To: Joel Sherrill; +Cc: gdb

On 05/07/2012 01:23 PM, Joel Sherrill wrote:
> Without this patch, this generates a missing prototype
> warning which is treated as an error. I don't see this
> routine referenced elsewhere, so there is the possibility
> that it also could be made static.
>
> OK to apply?
>
> 2012-05-12 Joel Sherrill <joel.sherrill@oarcorp.com>
>
> * microblaze-rom.c (_initialize_picobug_rom): Add prototype.

I don't see any warning issued in my build, but it is OK
to check this patch in.


-- 
Michael Eager	 eager@eagercon.com
1960 Park Blvd., Palo Alto, CA 94306  650-325-8077

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2012-05-15 13:41 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2012-05-07 20:23 Microblaze simulator - Fix missing prototype Joel Sherrill
2012-05-15 13:41 ` Michael Eager

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).