From: Eli Zaretskii <eliz@gnu.org>
To: Jonny Grant <jg@jguk.org>
Cc: simark@simark.ca, gdb@sourceware.org
Subject: Re: http://mail.gnu.org/mailman/listinfo/bug-gdb/ down
Date: Thu, 28 May 2020 09:31:58 +0300 [thread overview]
Message-ID: <83h7w0sh7l.fsf@gnu.org> (raw)
In-Reply-To: <3a66feb1-686f-d0c0-7124-ca3887b52507@jguk.org> (message from Jonny Grant on Wed, 27 May 2020 23:12:32 +0100)
> From: Jonny Grant <jg@jguk.org>
> Date: Wed, 27 May 2020 23:12:32 +0100
>
> >> BTW, the footer has a link "Previous: (dir)" and "Up: (dir)" is a broken link to
> >> https://sourceware.org/gdb/onlinedocs/dir/index.html
> >>
> >> Could someone fix that link, or should I file a bug report on sourceware?
> >
> > Hmm, we would have to find out if it's a texinfo bug, or just us using texinfo wrong.
> >
> > Again, you can generate this file using the "make html" command mentioned above and
> > try to find out why.
>
> Yes, it is the same in the html created.
> I've attached a patch that removes those broken links.
Thanks, these changes are fine with me in principle, but the
indentations seems to be wrong here:
> if (REPORT_BUGS_TO[0] && stream == gdb_stdout)
> fprintf_unfiltered (stream, _("\
> Report bugs to \"%s\".\n\
> +"), REPORT_BUGS_TO);
> + fprintf_unfiltered (stream, _("\
> +GDB mailing list \"mailto:gdb@sourceware.org\"\n\
> "), REPORT_BUGS_TO);
Is the added fprintf conditioned by this 'if':
if (REPORT_BUGS_TO[0] && stream == gdb_stdout)
If it is, then braces are missing around the two fprintf's; if it
isn't, then the second fprintf should not be indented as the first
one.
prev parent reply other threads:[~2020-05-28 6:32 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-26 11:07 Jonny Grant
2020-05-26 14:17 ` Simon Marchi
2020-05-27 22:12 ` Jonny Grant
2020-05-27 22:26 ` Jonny Grant
2020-05-28 6:47 ` Eli Zaretskii
2020-05-30 0:20 ` Jonny Grant
2020-05-30 6:19 ` Eli Zaretskii
2020-06-27 19:37 ` Jonny Grant
2020-06-28 1:27 ` Joel Brobecker
2020-06-28 5:20 ` Andreas Schwab
2020-06-28 15:26 ` Jonny Grant
2020-06-28 15:36 ` Joel Brobecker
2020-06-29 11:44 ` Pedro Alves
2020-06-29 17:48 ` Joel Brobecker
2020-07-06 18:54 ` Joel Brobecker
2020-07-08 22:03 ` Jonny Grant
2020-06-28 15:21 ` Jonny Grant
2020-05-28 6:31 ` Eli Zaretskii [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=83h7w0sh7l.fsf@gnu.org \
--to=eliz@gnu.org \
--cc=gdb@sourceware.org \
--cc=jg@jguk.org \
--cc=simark@simark.ca \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).