[PATCH] gnu-nat.c: fix calls to add_info_alias

[PATCH] gnu-nat.c: fix calls to add_info_alias

[Andrea Monaco]

Hello,


some time ago add_info_alias was changed (commit
e0f25bd9717c7973197095523db7c1cdc956cea2).  These calls were not updated
and caused errors on compilation.


Warmly,

Andrea Monaco



diff --git a/gdb/gnu-nat.c b/gdb/gnu-nat.c
index c6cecff0686..2d15b3d3e58 100644
--- a/gdb/gnu-nat.c
+++ b/gdb/gnu-nat.c
@@ -3286,15 +3286,17 @@ This is the same as setting `task pause', `exceptions', and\n\
            _("Show information about the task's send rights."));
   add_info ("receive-rights", info_recv_rights_cmd,
            _("Show information about the task's receive rights."));
-  add_info ("port-rights", info_port_rights_cmd,
-           _("Show information about the task's port rights."));
-  add_info ("port-sets", info_port_sets_cmd,
-           _("Show information about the task's port sets."));
+  cmd_list_element *port_rights_cmd =
+    add_info ("port-rights", info_port_rights_cmd,
+             _("Show information about the task's port rights."));
+  cmd_list_element *port_sets_cmd =
+    add_info ("port-sets", info_port_sets_cmd,
+             _("Show information about the task's port sets."));
   add_info ("dead-names", info_dead_names_cmd,
            _("Show information about the task's dead names."));
-  add_info_alias ("ports", "port-rights", 1);
-  add_info_alias ("port", "port-rights", 1);
-  add_info_alias ("psets", "port-sets", 1);
+  add_info_alias ("ports", port_rights_cmd, 1);
+  add_info_alias ("port", port_rights_cmd, 1);
+  add_info_alias ("psets", port_sets_cmd, 1);
 }
 
 ^L

Re: [PATCH] gnu-nat.c: fix calls to add_info_alias

[Simon Marchi]

On 2021-11-06 12:22, Andrea Monaco via Gdb wrote:
> 
> Hello,
> 
> 
> some time ago add_info_alias was changed (commit
> e0f25bd9717c7973197095523db7c1cdc956cea2).  These calls were not updated
> and caused errors on compilation.
> 
> 
> Warmly,
> 
> Andrea Monaco
> 
> 
> 
> diff --git a/gdb/gnu-nat.c b/gdb/gnu-nat.c
> index c6cecff0686..2d15b3d3e58 100644
> --- a/gdb/gnu-nat.c
> +++ b/gdb/gnu-nat.c
> @@ -3286,15 +3286,17 @@ This is the same as setting `task pause', `exceptions', and\n\
>             _("Show information about the task's send rights."));
>    add_info ("receive-rights", info_recv_rights_cmd,
>             _("Show information about the task's receive rights."));
> -  add_info ("port-rights", info_port_rights_cmd,
> -           _("Show information about the task's port rights."));
> -  add_info ("port-sets", info_port_sets_cmd,
> -           _("Show information about the task's port sets."));
> +  cmd_list_element *port_rights_cmd =
> +    add_info ("port-rights", info_port_rights_cmd,
> +             _("Show information about the task's port rights."));
> +  cmd_list_element *port_sets_cmd =
> +    add_info ("port-sets", info_port_sets_cmd,
> +             _("Show information about the task's port sets."));
>    add_info ("dead-names", info_dead_names_cmd,
>             _("Show information about the task's dead names."));
> -  add_info_alias ("ports", "port-rights", 1);
> -  add_info_alias ("port", "port-rights", 1);
> -  add_info_alias ("psets", "port-sets", 1);
> +  add_info_alias ("ports", port_rights_cmd, 1);
> +  add_info_alias ("port", port_rights_cmd, 1);
> +  add_info_alias ("psets", port_sets_cmd, 1);
>  }
>  
>  ^L
> 

Hi,

I had trouble applying your patch, I suppose the text was modified by
your email client.  But it is small enough that I applied it by hand and
pushed it, thanks.  Just note for next time that patches should ideally
be sent to the gdb-patches mailing list.

Simon