* Question about running "make check-gdb"
@ 2021-06-04 9:56 Shahab Vahedi
2021-06-04 13:09 ` Andrew Burgess
` (2 more replies)
0 siblings, 3 replies; 5+ messages in thread
From: Shahab Vahedi @ 2021-06-04 9:56 UTC (permalink / raw)
To: Tom Tromey; +Cc: gdb
Hi Tom,
Couple of days ago, you've pushed a refactoring commit [1] to gdb.
I noticed after that change I am not able to run gdb tests for
ARC targets anymore. I investigated a little bit and it seems like
that the "target_alias" in generated "gdb/testsuite/site.exp" is
not recognized correctly:
------ After the commit -------
$ configure --target=arc-elf32 ...
$ make
$ make check-gdb
$ cat gdb/testsuite/site.exp
...
set target_alias @target_noncanonical@
...
------ After the commit -------
------ Before the commit -------
$ ./configure --target=arc-elf32 ...
$ make
$ make check-gdb
$ cat gdb/testsuite/site.exp
...
set target_alias arc-elf32
...
------ Before the commit -------
I've tried some other target combinations as well to no avail:
$ ./configure --target=arc-none-elf32
$ ./configure --target=arc-snps-elf
$ ...
I would much appreciate it if you could point me in the direction of
how to fix this.
Cheers,
Shahab
[1] Remove gdb/testsuite/configure
https://sourceware.org/git/?p=binutils-gdb.git;a=commit;h=f99d1d374
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: Question about running "make check-gdb"
2021-06-04 9:56 Question about running "make check-gdb" Shahab Vahedi
@ 2021-06-04 13:09 ` Andrew Burgess
2021-06-04 20:25 ` Tom Tromey
2021-06-04 13:54 ` Tom Tromey
2021-06-07 12:13 ` Shahab Vahedi
2 siblings, 1 reply; 5+ messages in thread
From: Andrew Burgess @ 2021-06-04 13:09 UTC (permalink / raw)
To: Shahab Vahedi; +Cc: Tom Tromey, gdb
* Shahab Vahedi via Gdb <gdb@sourceware.org> [2021-06-04 11:56:48 +0200]:
> Hi Tom,
>
> Couple of days ago, you've pushed a refactoring commit [1] to gdb.
> I noticed after that change I am not able to run gdb tests for
> ARC targets anymore. I investigated a little bit and it seems like
> that the "target_alias" in generated "gdb/testsuite/site.exp" is
> not recognized correctly:
>
> ------ After the commit -------
> $ configure --target=arc-elf32 ...
> $ make
> $ make check-gdb
> $ cat gdb/testsuite/site.exp
> ...
> set target_alias @target_noncanonical@
> ...
> ------ After the commit -------
>
> ------ Before the commit -------
> $ ./configure --target=arc-elf32 ...
> $ make
> $ make check-gdb
> $ cat gdb/testsuite/site.exp
> ...
> set target_alias arc-elf32
> ...
> ------ Before the commit -------
>
> I've tried some other target combinations as well to no avail:
>
> $ ./configure --target=arc-none-elf32
> $ ./configure --target=arc-snps-elf
> $ ...
>
> I would much appreciate it if you could point me in the direction of
> how to fix this.
I suspect that it was the loss of ACX_NONCANONICAL_TARGET that is the
problem, this used to be present in gdb/testsuite/configure.ac, but is
not in gdb/configure.ac.
Try adding this call into gdb/configure.ac and see if that fixes it
for you.
thanks,
Andrew
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: Question about running "make check-gdb"
2021-06-04 9:56 Question about running "make check-gdb" Shahab Vahedi
2021-06-04 13:09 ` Andrew Burgess
@ 2021-06-04 13:54 ` Tom Tromey
2021-06-07 12:13 ` Shahab Vahedi
2 siblings, 0 replies; 5+ messages in thread
From: Tom Tromey @ 2021-06-04 13:54 UTC (permalink / raw)
To: Shahab Vahedi; +Cc: Tom Tromey, gdb
Shahab> Couple of days ago, you've pushed a refactoring commit [1] to gdb.
Shahab> I noticed after that change I am not able to run gdb tests for
Shahab> ARC targets anymore. I investigated a little bit and it seems like
Shahab> that the "target_alias" in generated "gdb/testsuite/site.exp" is
Shahab> not recognized correctly:
Sorry about that. I'll look into it soon.
Tom
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: Question about running "make check-gdb"
2021-06-04 13:09 ` Andrew Burgess
@ 2021-06-04 20:25 ` Tom Tromey
0 siblings, 0 replies; 5+ messages in thread
From: Tom Tromey @ 2021-06-04 20:25 UTC (permalink / raw)
To: Andrew Burgess; +Cc: Shahab Vahedi, Tom Tromey, gdb
Andrew> I suspect that it was the loss of ACX_NONCANONICAL_TARGET that is the
Andrew> problem, this used to be present in gdb/testsuite/configure.ac, but is
Andrew> not in gdb/configure.ac.
Andrew> Try adding this call into gdb/configure.ac and see if that fixes it
Andrew> for you.
Thanks. This does seem to be the problem.
I'll send a patch shortly.
Tom
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: Question about running "make check-gdb"
2021-06-04 9:56 Question about running "make check-gdb" Shahab Vahedi
2021-06-04 13:09 ` Andrew Burgess
2021-06-04 13:54 ` Tom Tromey
@ 2021-06-07 12:13 ` Shahab Vahedi
2 siblings, 0 replies; 5+ messages in thread
From: Shahab Vahedi @ 2021-06-07 12:13 UTC (permalink / raw)
To: gdb; +Cc: Tom Tromey, Andrew Burgess
For the record, this problem is resolved [1].
Thank you Andrew and Tom for your prompt response.
Cheers,
Shahab
[1] Use ACX_NONCANONICAL_TARGET in gdb/configure
https://sourceware.org/git/?p=binutils-gdb.git;a=commit;h=b316465fab7
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2021-06-07 12:12 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-06-04 9:56 Question about running "make check-gdb" Shahab Vahedi
2021-06-04 13:09 ` Andrew Burgess
2021-06-04 20:25 ` Tom Tromey
2021-06-04 13:54 ` Tom Tromey
2021-06-07 12:13 ` Shahab Vahedi
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).