Question about running "make check-gdb"

Question about running "make check-gdb"

[Shahab Vahedi]

Hi Tom,

Couple of days ago, you've pushed a refactoring commit [1] to gdb.
I noticed after that change I am not able to run gdb tests for
ARC targets anymore. I investigated a little bit and it seems like
that the "target_alias" in generated "gdb/testsuite/site.exp" is
not recognized correctly:

------ After the commit -------
$ configure --target=arc-elf32 ...
$ make
$ make check-gdb
$ cat gdb/testsuite/site.exp
  ...
  set target_alias @target_noncanonical@
  ...
------ After the commit -------

------ Before the commit -------
$ ./configure --target=arc-elf32 ...
$ make
$ make check-gdb
$ cat gdb/testsuite/site.exp
  ...
  set target_alias arc-elf32
  ...
------ Before the commit -------

I've tried some other target combinations as well to no avail:

$ ./configure --target=arc-none-elf32
$ ./configure --target=arc-snps-elf
$ ...

I would much appreciate it if you could point me in the direction of
how to fix this.


Cheers,
Shahab

[1] Remove gdb/testsuite/configure
https://sourceware.org/git/?p=binutils-gdb.git;a=commit;h=f99d1d374

Re: Question about running "make check-gdb"

[Andrew Burgess]

* Shahab Vahedi via Gdb <gdb@sourceware.org> [2021-06-04 11:56:48 +0200]:

> Hi Tom,
> 
> Couple of days ago, you've pushed a refactoring commit [1] to gdb.
> I noticed after that change I am not able to run gdb tests for
> ARC targets anymore. I investigated a little bit and it seems like
> that the "target_alias" in generated "gdb/testsuite/site.exp" is
> not recognized correctly:
> 
> ------ After the commit -------
> $ configure --target=arc-elf32 ...
> $ make
> $ make check-gdb
> $ cat gdb/testsuite/site.exp
>   ...
>   set target_alias @target_noncanonical@
>   ...
> ------ After the commit -------
> 
> ------ Before the commit -------
> $ ./configure --target=arc-elf32 ...
> $ make
> $ make check-gdb
> $ cat gdb/testsuite/site.exp
>   ...
>   set target_alias arc-elf32
>   ...
> ------ Before the commit -------
> 
> I've tried some other target combinations as well to no avail:
> 
> $ ./configure --target=arc-none-elf32
> $ ./configure --target=arc-snps-elf
> $ ...
> 
> I would much appreciate it if you could point me in the direction of
> how to fix this.

I suspect that it was the loss of ACX_NONCANONICAL_TARGET that is the
problem, this used to be present in gdb/testsuite/configure.ac, but is
not in gdb/configure.ac.

Try adding this call into gdb/configure.ac and see if that fixes it
for you.

thanks,
Andrew

Re: Question about running "make check-gdb"

[Tom Tromey]

Andrew> I suspect that it was the loss of ACX_NONCANONICAL_TARGET that is the
Andrew> problem, this used to be present in gdb/testsuite/configure.ac, but is
Andrew> not in gdb/configure.ac.

Andrew> Try adding this call into gdb/configure.ac and see if that fixes it
Andrew> for you.

Thanks.  This does seem to be the problem.
I'll send a patch shortly.

Tom

Re: Question about running "make check-gdb"

[Tom Tromey]

Shahab> Couple of days ago, you've pushed a refactoring commit [1] to gdb.
Shahab> I noticed after that change I am not able to run gdb tests for
Shahab> ARC targets anymore. I investigated a little bit and it seems like
Shahab> that the "target_alias" in generated "gdb/testsuite/site.exp" is
Shahab> not recognized correctly:

Sorry about that.  I'll look into it soon.

Tom

Re: Question about running "make check-gdb"

[Shahab Vahedi]

For the record, this problem is resolved [1].

Thank you Andrew and Tom for your prompt response.

Cheers,
Shahab

[1] Use ACX_NONCANONICAL_TARGET in gdb/configure
https://sourceware.org/git/?p=binutils-gdb.git;a=commit;h=b316465fab7