From: Mark Wielaard <mark@klomp.org>
To: Luis Machado <luis.machado@arm.com>
Cc: gdb@sourceware.org, buildbot@sourceware.org
Subject: Re: [builder] gdb_check_step: remove gdb.gdb/selftest.exp
Date: Fri, 10 Jun 2022 01:21:15 +0200 [thread overview]
Message-ID: <YqKAa/0JvxriOAYp@wildebeest.org> (raw)
In-Reply-To: <YqJ9n22XFeveBaQ9@wildebeest.org>
[-- Attachment #1: Type: text/plain, Size: 888 bytes --]
On Fri, Jun 10, 2022 at 01:09:19AM +0200, Mark Wielaard wrote:
> On Thu, Jun 09, 2022 at 10:37:58AM +0100, Luis Machado wrote:
> > I always use gdb.base/break.exp as a good smoke test. If that one fails, then things
> > are really broken.
> >
> > I think gdb.base/break*.exp should make a good smoke test list. We just need to exclude
> > gdb.base/break-interp.exp, which is problematic on some targets.
>
> It never is just easy is it? :) You are right, I saw break-interp.exp
> fail... I tried to come up with a regexp but gave up given that it
> has to go throug python first and then we don't know whether the
> worker uses bash as /bin/sh so I just added them all (exclusing
> break-interp.exp) as a list.
Sigh, sorry, looks like gdb.base/break-unload-file.exp also sometimes fails.
I have removed from the list. Hopefully the remaining list does actually pass.
Cheers,
Mark
[-- Attachment #2: 0001-gdb_test_exp-Remove-gdb.base-break-unload-file.exp.patch --]
[-- Type: text/x-diff, Size: 764 bytes --]
From 49a95a50543a772d4413078c34de520e2e2a9610 Mon Sep 17 00:00:00 2001
From: Mark Wielaard <mark@klomp.org>
Date: Fri, 10 Jun 2022 01:20:19 +0200
Subject: [PATCH] gdb_test_exp: Remove gdb.base/break-unload-file.exp
---
builder/master.cfg | 1 -
1 file changed, 1 deletion(-)
diff --git a/builder/master.cfg b/builder/master.cfg
index f6895b5..e413d3f 100644
--- a/builder/master.cfg
+++ b/builder/master.cfg
@@ -1461,7 +1461,6 @@ gdb_test_exp = ("TESTS= "
"gdb.base/breakpoint-in-ro-region.exp "
"gdb.base/breakpoint-shadow.exp "
"gdb.base/break-probes.exp "
- "gdb.base/break-unload-file.exp "
"gdb.gdb/unittest.exp "
"gdb.server/unittest.exp ")
--
2.30.2
next prev parent reply other threads:[~2022-06-09 23:21 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-06-08 18:51 Mark Wielaard
2022-06-09 9:37 ` Luis Machado
2022-06-09 23:09 ` Mark Wielaard
2022-06-09 23:21 ` Mark Wielaard [this message]
2022-06-10 10:50 ` Mark Wielaard
2022-06-10 10:58 ` Luis Machado
2022-06-10 15:17 ` will schmidt
2022-06-10 15:54 ` Carl Love
2022-06-10 19:11 ` Mark Wielaard
2022-06-10 20:11 ` Carl Love
2022-06-10 22:23 ` Frank Ch. Eigler
2022-06-29 15:58 ` Carl Love
2022-06-29 22:42 ` Mark Wielaard
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YqKAa/0JvxriOAYp@wildebeest.org \
--to=mark@klomp.org \
--cc=buildbot@sourceware.org \
--cc=gdb@sourceware.org \
--cc=luis.machado@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).