public inbox for gdb@sourceware.org
 help / color / mirror / Atom feed
From: Luis Machado <luis.machado@linaro.org>
To: Eli Zaretskii <eliz@gnu.org>, Simon Marchi <simon.marchi@polymtl.ca>
Cc: gdb@sourceware.org, Mike Frysinger <vapier@gentoo.org>
Subject: Re: sim: replacing ChangeLog files with online git logs
Date: Wed, 17 Mar 2021 14:24:27 -0300	[thread overview]
Message-ID: <b9667a5d-c830-9baf-03d9-ea5308a63eac@linaro.org> (raw)
In-Reply-To: <83im5pdao2.fsf@gnu.org>

On 3/17/21 1:09 PM, Eli Zaretskii wrote:
>> Cc: gdb@sourceware.org
>> From: Simon Marchi <simon.marchi@polymtl.ca>
>> Date: Wed, 17 Mar 2021 11:52:49 -0400
>>
>> In the GDB project, we write what I believe are excellent git commit
>> messages that go in depth describing the observed problem and the
>> solution provided by the patch.  That provides valuable information for
>> anyone wanting to understand why the code is the way it is.  A list of
>> modified symbols doesn't help.  So I am completely fine if the "list of
>> modified symbols" part of the information is lost.
> 
> Well, if that's what the majority here wants, then so be it.

That's what we should assess. From chatting with other active GDB 
developers, my feeling is that most of us want to drop the process of 
having to write ChangeLog entries manually. But we tend to keep quiet 
and carry on doing it.

> 
> (The importance of having the list of modified symbols in the log is
> that then one doesn't need advanced Git commands to find out which
> changes modified a given function and why.)
> 

I understand the concern about git. I used to find git a bit too cryptic 
too, but using it daily has made that better.

Now git log/git blame shows very useful information when I'm looking for 
specific changes from a commit, and I rarely need to go through 
ChangeLogs other than to find commits that touched a particular 
function/variable.

The auto-generated ChangeLog entry may still help with that, but it 
would be auto-generated instead of taking time away from active developers.

>>> If that is not an option that this community wants to adopt, then
>>> gitlog-to-changelog is probably not the adequate solution, and we
>>> should try using vcs-to-changelog.py (also in Gnulib).
>>
>> I tried vcs-to-changelog, it gave horrible/useless results with our
>> codebase.  This is not an option.
> 
> Too bad.  Maybe we should report this to the developer of the script,
> it could help fix those shortcomings in the future.
> 

Maybe. But looking into the future, parsing C++ to extract that kind of 
information is really not trivial. So it may never work in a reasonable 
way for GDB without some serious effort put into the script.

  reply	other threads:[~2021-03-17 17:24 UTC|newest]

Thread overview: 45+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-03-13  2:53 Mike Frysinger
2021-03-13  7:30 ` Eli Zaretskii
2021-03-13 15:12   ` Mike Frysinger
2021-03-13 16:02     ` Eli Zaretskii
2021-03-13 16:26       ` Mike Frysinger
2021-03-13 16:38         ` Eli Zaretskii
2021-03-13 18:21           ` Mike Frysinger
2021-03-13 18:32             ` Eli Zaretskii
2021-03-17  6:07               ` Mike Frysinger
2021-03-17 13:14                 ` Eli Zaretskii
2021-03-17 14:31                   ` Luis Machado
2021-03-17 14:47                     ` Eli Zaretskii
2021-03-17 14:52                       ` Luis Machado
2021-03-17 15:09                         ` Eli Zaretskii
2021-03-17 15:22                           ` Luis Machado
2021-03-17 15:40                             ` Eli Zaretskii
2021-03-17 15:52                               ` Simon Marchi
2021-03-17 16:09                                 ` Eli Zaretskii
2021-03-17 17:24                                   ` Luis Machado [this message]
2021-03-17 17:53                                     ` Eli Zaretskii
2021-03-17 20:53                                       ` Luis Machado
2021-03-18  9:31                                       ` Andrew Burgess
2021-03-18  9:48                                         ` Eli Zaretskii
2021-03-22  2:19                                           ` Maciej W. Rozycki
2021-03-22  3:38                                             ` Eli Zaretskii
2021-03-23  4:57                                               ` Mike Frysinger
2021-03-23  5:05                   ` Mike Frysinger
2021-03-23 11:06                     ` Andrew Burgess
2021-03-24  3:45                       ` Mike Frysinger
2021-03-24 16:46                         ` Eli Zaretskii
2021-03-24 16:59                           ` Andrew Burgess
2021-03-24 17:39                             ` Eli Zaretskii
2021-03-24 18:44                               ` Mike Frysinger
2021-03-31  2:27                                 ` Mike Frysinger
2021-03-31  3:27                                   ` Joel Brobecker
2021-03-31 11:35                                     ` Luis Machado
2021-03-31 15:29                                       ` Joel Brobecker
2021-04-01  3:41                                     ` Mike Frysinger
2021-04-19  0:52                                       ` Mike Frysinger
2021-04-19  2:32                                         ` Joel Brobecker
2021-04-19  4:31                                           ` Mike Frysinger
2021-04-19  5:00                                             ` Joel Brobecker
2021-05-23  3:26                                               ` Mike Frysinger
2021-06-10 12:11                                                 ` Luis Machado
2021-03-13 18:34             ` Paul Smith

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=b9667a5d-c830-9baf-03d9-ea5308a63eac@linaro.org \
    --to=luis.machado@linaro.org \
    --cc=eliz@gnu.org \
    --cc=gdb@sourceware.org \
    --cc=simon.marchi@polymtl.ca \
    --cc=vapier@gentoo.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).