* [Bug regex/281] regex.c doesn't compile on hosts with signed char
2004-07-23 10:56 [Bug regex/281] New: regex.c doesn't compile on hosts with signed char kasal at ucw dot cz
@ 2004-07-23 10:59 ` kasal at ucw dot cz
2004-07-23 13:47 ` jakub at redhat dot com
` (6 subsequent siblings)
7 siblings, 0 replies; 9+ messages in thread
From: kasal at ucw dot cz @ 2004-07-23 10:59 UTC (permalink / raw)
To: glibc-bugs-regex
------- Additional Comments From kasal at ucw dot cz 2004-07-23 10:59 -------
Created an attachment (id=140)
--> (http://sources.redhat.com/bugzilla/attachment.cgi?id=140&action=view)
the patch to fix the bug
--
http://sources.redhat.com/bugzilla/show_bug.cgi?id=281
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.
^ permalink raw reply [flat|nested] 9+ messages in thread* [Bug regex/281] regex.c doesn't compile on hosts with signed char
2004-07-23 10:56 [Bug regex/281] New: regex.c doesn't compile on hosts with signed char kasal at ucw dot cz
2004-07-23 10:59 ` [Bug regex/281] " kasal at ucw dot cz
@ 2004-07-23 13:47 ` jakub at redhat dot com
2004-07-23 14:45 ` kasal at ucw dot cz
` (5 subsequent siblings)
7 siblings, 0 replies; 9+ messages in thread
From: jakub at redhat dot com @ 2004-07-23 13:47 UTC (permalink / raw)
To: glibc-bugs-regex
------- Additional Comments From jakub at redhat dot com 2004-07-23 13:47 -------
What kind of problems?
Most of the arches have signed char.
re_search_internal is certainly not the only place which uses
unsigned RE_TRANSLATE_TYPE.
IMHO RE_TRANSLATE_TYPE should stay char *, it has been that way since the
original GNU regex.
--
What |Removed |Added
----------------------------------------------------------------------------
Status|NEW |WAITING
http://sources.redhat.com/bugzilla/show_bug.cgi?id=281
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.
^ permalink raw reply [flat|nested] 9+ messages in thread* [Bug regex/281] regex.c doesn't compile on hosts with signed char
2004-07-23 10:56 [Bug regex/281] New: regex.c doesn't compile on hosts with signed char kasal at ucw dot cz
2004-07-23 10:59 ` [Bug regex/281] " kasal at ucw dot cz
2004-07-23 13:47 ` jakub at redhat dot com
@ 2004-07-23 14:45 ` kasal at ucw dot cz
2004-07-26 11:10 ` kasal at ucw dot cz
` (4 subsequent siblings)
7 siblings, 0 replies; 9+ messages in thread
From: kasal at ucw dot cz @ 2004-07-23 14:45 UTC (permalink / raw)
To: glibc-bugs-regex
------- Additional Comments From kasal at ucw dot cz 2004-07-23 14:45 -------
(In reply to comment #2)
> What kind of problems?
> Most of the arches have signed char.
> re_search_internal is certainly not the only place which uses
> unsigned RE_TRANSLATE_TYPE.
When the patch was created, exactly one year ago, this was the only place.
(I've submitted the patch to bug-glibc back then, but no answer...)
Since then, many bugs were fixed by adding "unsigned" before
RE_TRANSLATE_TYPE on many places.
> IMHO RE_TRANSLATE_TYPE should stay char *, it has been that way since the
> original GNU regex.
Well, my opinion has to be humble too, you have read more of regex then I.
But I think that it was a mistake originally, which is proved by the rapid
growth of "unsigned RE_TRANSLATE_TYPE" which you mentioned.
I don't see any problem with the change.
--
http://sources.redhat.com/bugzilla/show_bug.cgi?id=281
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.
^ permalink raw reply [flat|nested] 9+ messages in thread* [Bug regex/281] regex.c doesn't compile on hosts with signed char
2004-07-23 10:56 [Bug regex/281] New: regex.c doesn't compile on hosts with signed char kasal at ucw dot cz
` (2 preceding siblings ...)
2004-07-23 14:45 ` kasal at ucw dot cz
@ 2004-07-26 11:10 ` kasal at ucw dot cz
2004-09-26 21:31 ` drepper at redhat dot com
` (3 subsequent siblings)
7 siblings, 0 replies; 9+ messages in thread
From: kasal at ucw dot cz @ 2004-07-26 11:10 UTC (permalink / raw)
To: glibc-bugs-regex
------- Additional Comments From kasal at ucw dot cz 2004-07-26 11:10 -------
Created an attachment (id=144)
--> (http://sources.redhat.com/bugzilla/attachment.cgi?id=144&action=view)
updated patch
Since the disease has affected more places since the original patch was
created,
an update is needed.
--
What |Removed |Added
----------------------------------------------------------------------------
Attachment #140 is|0 |1
obsolete| |
http://sources.redhat.com/bugzilla/show_bug.cgi?id=281
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.
^ permalink raw reply [flat|nested] 9+ messages in thread* [Bug regex/281] regex.c doesn't compile on hosts with signed char
2004-07-23 10:56 [Bug regex/281] New: regex.c doesn't compile on hosts with signed char kasal at ucw dot cz
` (3 preceding siblings ...)
2004-07-26 11:10 ` kasal at ucw dot cz
@ 2004-09-26 21:31 ` drepper at redhat dot com
2004-09-26 22:57 ` kasal at ucw dot cz
` (2 subsequent siblings)
7 siblings, 0 replies; 9+ messages in thread
From: drepper at redhat dot com @ 2004-09-26 21:31 UTC (permalink / raw)
To: glibc-bugs-regex
------- Additional Comments From drepper at redhat dot com 2004-09-26 21:31 -------
I'm not going to apply any change like that without justification. I.e., test
case where it fails. I don't even see warnings on the architectures I use
regularly.
--
http://sources.redhat.com/bugzilla/show_bug.cgi?id=281
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.
^ permalink raw reply [flat|nested] 9+ messages in thread* [Bug regex/281] regex.c doesn't compile on hosts with signed char
2004-07-23 10:56 [Bug regex/281] New: regex.c doesn't compile on hosts with signed char kasal at ucw dot cz
` (4 preceding siblings ...)
2004-09-26 21:31 ` drepper at redhat dot com
@ 2004-09-26 22:57 ` kasal at ucw dot cz
2004-09-26 23:00 ` kasal at ucw dot cz
2005-09-23 6:11 ` drepper at redhat dot com
7 siblings, 0 replies; 9+ messages in thread
From: kasal at ucw dot cz @ 2004-09-26 22:57 UTC (permalink / raw)
To: glibc-bugs-regex
------- Additional Comments From kasal at ucw dot cz 2004-09-26 22:57 -------
The code you have in glibc now works, because almost all instances of
``RE_TRANSLATE_TYPE'' have been replaced by ``unsigned RE_TRANSLATE_TYPE''.
I think this solution is ugly; of course it would have been better if
RE_TRANSLATE_TYPE were defined as ``unsigned char *'' at the beginning.
My patch cleans that ugliness.
I upload a new version of the patch which dosn't touch regex.c and thus is not
visible for user programs.
--
http://sources.redhat.com/bugzilla/show_bug.cgi?id=281
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.
^ permalink raw reply [flat|nested] 9+ messages in thread* [Bug regex/281] regex.c doesn't compile on hosts with signed char
2004-07-23 10:56 [Bug regex/281] New: regex.c doesn't compile on hosts with signed char kasal at ucw dot cz
` (5 preceding siblings ...)
2004-09-26 22:57 ` kasal at ucw dot cz
@ 2004-09-26 23:00 ` kasal at ucw dot cz
2005-09-23 6:11 ` drepper at redhat dot com
7 siblings, 0 replies; 9+ messages in thread
From: kasal at ucw dot cz @ 2004-09-26 23:00 UTC (permalink / raw)
To: glibc-bugs-regex
------- Additional Comments From kasal at ucw dot cz 2004-09-26 23:00 -------
Created an attachment (id=204)
--> (http://sources.redhat.com/bugzilla/attachment.cgi?id=204&action=view)
patch 3
A cleanup patch, see above for explanation.
--
What |Removed |Added
----------------------------------------------------------------------------
Attachment #144 is|0 |1
obsolete| |
http://sources.redhat.com/bugzilla/show_bug.cgi?id=281
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.
^ permalink raw reply [flat|nested] 9+ messages in thread* [Bug regex/281] regex.c doesn't compile on hosts with signed char
2004-07-23 10:56 [Bug regex/281] New: regex.c doesn't compile on hosts with signed char kasal at ucw dot cz
` (6 preceding siblings ...)
2004-09-26 23:00 ` kasal at ucw dot cz
@ 2005-09-23 6:11 ` drepper at redhat dot com
7 siblings, 0 replies; 9+ messages in thread
From: drepper at redhat dot com @ 2005-09-23 6:11 UTC (permalink / raw)
To: glibc-bugs-regex
------- Additional Comments From drepper at redhat dot com 2005-09-23 06:10 -------
I've checked in a form of the last patch to the trunk.
--
What |Removed |Added
----------------------------------------------------------------------------
Status|WAITING |RESOLVED
Resolution| |FIXED
http://sourceware.org/bugzilla/show_bug.cgi?id=281
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.
^ permalink raw reply [flat|nested] 9+ messages in thread