public inbox for glibc-bugs-regex@sourceware.org
help / color / mirror / Atom feed
* [Bug regex/506] New: there is dead code in regex
@ 2004-11-04 8:59 bonzini at gnu dot org
2004-11-09 7:49 ` [Bug regex/506] " bonzini at gnu dot org
0 siblings, 1 reply; 2+ messages in thread
From: bonzini at gnu dot org @ 2004-11-04 8:59 UTC (permalink / raw)
To: glibc-bugs-regex
The flurry of algorithms to efficiently implement backreferences left behind
some dead code in regex.
The patch at http://sources.redhat.com/ml/libc-alpha/2004-11/msg00016.html
removes several unused parameters and struct fields.
The most egregious is the "flag" struct re_backref_cache_entry field.
Removing it turned a potentially quadratic loop into linear, though I did
not try to find a case in which this actually happened.
In another case, it looks like changing the algorithms would have required
changing the node_set passed to sift_states_bkref, but this was not done.
So this patch does that instead of only removing the unused parameter.
--
Summary: there is dead code in regex
Product: glibc
Version: unspecified
Status: NEW
Severity: normal
Priority: P2
Component: regex
AssignedTo: bonzini at gnu dot org
ReportedBy: bonzini at gnu dot org
CC: glibc-bugs-regex at sources dot redhat dot com,glibc-
bugs at sources dot redhat dot com
OtherBugsDependingO 500
nThis:
http://sources.redhat.com/bugzilla/show_bug.cgi?id=506
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.
^ permalink raw reply [flat|nested] 2+ messages in thread
* [Bug regex/506] there is dead code in regex
2004-11-04 8:59 [Bug regex/506] New: there is dead code in regex bonzini at gnu dot org
@ 2004-11-09 7:49 ` bonzini at gnu dot org
0 siblings, 0 replies; 2+ messages in thread
From: bonzini at gnu dot org @ 2004-11-09 7:49 UTC (permalink / raw)
To: glibc-bugs-regex
------- Additional Comments From bonzini at gnu dot org 2004-11-09 07:48 -------
Patch applied.
--
What |Removed |Added
----------------------------------------------------------------------------
Status|NEW |RESOLVED
Resolution| |FIXED
http://sources.redhat.com/bugzilla/show_bug.cgi?id=506
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2004-11-09 7:49 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2004-11-04 8:59 [Bug regex/506] New: there is dead code in regex bonzini at gnu dot org
2004-11-09 7:49 ` [Bug regex/506] " bonzini at gnu dot org
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).