public inbox for glibc-bugs@sourceware.org
help / color / mirror / Atom feed
From: Joseph Myers <josmyers@redhat.com>
To: Adhemerval Zanella Netto <adhemerval.zanella@linaro.org>
Cc: Ilya Kurdyukov <ilyakurdyukov@basealt.ru>,
glibc-bugs@sourceware.org,
Wilco Dijkstra <Wilco.Dijkstra@arm.com>
Subject: Re: Upstream glibc has a bug in math/e_exp10l.c
Date: Mon, 29 Jan 2024 21:21:47 +0000 (UTC) [thread overview]
Message-ID: <105f3bad-1a6f-b5c4-c61c-e2e97f64459@redhat.com> (raw)
In-Reply-To: <e9bd41e5-f82f-41b4-a25f-9127344078cb@linaro.org>
[-- Attachment #1: Type: text/plain, Size: 1167 bytes --]
On Mon, 29 Jan 2024, Adhemerval Zanella Netto via Glibc-bugs wrote:
> > Here in math/e_exp10l.c, the name "exp10l" must be used, but this line is copied from math/e_exp10.c and not changed:
> >
> > 34 libm_alias_finite (__ieee754_exp10, __exp10)
> >
> > https://sourceware.org/git/?p=glibc.git;a=blob;f=math/e_exp10l.c;h=b33d6fea239ebc20caf8b2dec9b7d03909a0fc81;hb=220622dde5704c95a100c2792a280f18f3deba73#l34
>
> It is indeed wrong, although it is not used by any ABI which defines
> a long double different than double. Either the sysdep version
> (ieee754/ldbl-128ibm, ieee754/ldbl-128) or an arch specific one
> (m68k, x86).
>
> If/once an ABI uses this generic version, it would most likely
> generic either an build error (due wrong aliases) or an ABI
> issue. Maybe a better option would just to remove this file.
I agree with the idea of removing all the math/ implementations that are
bogus (don't implement the appropriate semantics with an reasonable
accuracy) and overridden for all supported floating-point formats /
targets. That includes at least: e_exp10.c e_exp10l.c s_fma.c s_fmaf.c
s_fmal.c.
--
Joseph S. Myers
josmyers@redhat.com
prev parent reply other threads:[~2024-01-29 21:22 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-01-29 10:38 Ilya Kurdyukov
2024-01-29 17:16 ` Adhemerval Zanella Netto
2024-01-29 17:32 ` Ilya Kurdyukov
2024-01-29 20:28 ` Adhemerval Zanella Netto
2024-01-29 21:21 ` Joseph Myers [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=105f3bad-1a6f-b5c4-c61c-e2e97f64459@redhat.com \
--to=josmyers@redhat.com \
--cc=Wilco.Dijkstra@arm.com \
--cc=adhemerval.zanella@linaro.org \
--cc=glibc-bugs@sourceware.org \
--cc=ilyakurdyukov@basealt.ru \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).