Re: Upstream glibc has a bug in math/e_exp10l.c

[Ilya Kurdyukov <ilyakurdyukov@basealt.ru>]

On 1/30/24 00:16, Adhemerval Zanella Netto wrote:
> On 29/01/24 07:38, Ilya Kurdyukov wrote:
>> Wilco Dijkstra made a typo in this patch:
>>
>> Add libm_alias_finite for _finite symbols
>>
>> author    Wilco Dijkstra <Wilco.Dijkstra@arm.com>
>>      Tue, 16 Jul 2019 15:17:22 +0000 (12:17 -0300)
>> committer    Adhemerval Zanella <adhemerval.zanella@linaro.org>
>>      Fri, 3 Jan 2020 13:02:04 +0000 (10:02 -0300)
>>
>> https://sourceware.org/git/?p=glibc.git;a=commitdiff;h=220622dde5704c95a100c2792a280f18f3deba73
>>
>> Here in math/e_exp10l.c, the name "exp10l" must be used, but this line is copied from math/e_exp10.c and not changed:
>>
>>    34 libm_alias_finite (__ieee754_exp10, __exp10)
>>
>> https://sourceware.org/git/?p=glibc.git;a=blob;f=math/e_exp10l.c;h=b33d6fea239ebc20caf8b2dec9b7d03909a0fc81;hb=220622dde5704c95a100c2792a280f18f3deba73#l34
> It is indeed wrong, although it is not used by any ABI which defines
> a long double different than double.  Either the sysdep version
> (ieee754/ldbl-128ibm, ieee754/ldbl-128) or an arch specific one
> (m68k, x86).

It is used in patches for the e2karchitecture.

> If/once an ABI uses this generic version, it would most likely
> generic either an build error (due wrong aliases) or an ABI
> issue.  Maybe a better option would just to remove this file.