public inbox for glibc-bugs@sourceware.org help / color / mirror / Atom feed
From: "carlos_odonell at mentor dot com" <sourceware-bugzilla@sourceware.org> To: glibc-bugs@sources.redhat.com Subject: [Bug libc/11787] Program with large TLS segment fails aio_write Date: Fri, 23 Mar 2012 22:51:00 -0000 [thread overview] Message-ID: <bug-11787-131-dXN69qGvng@http.sourceware.org/bugzilla/> (raw) In-Reply-To: <bug-11787-131@http.sourceware.org/bugzilla/> http://sourceware.org/bugzilla/show_bug.cgi?id=11787 --- Comment #8 from Carlos O'Donell <carlos_odonell at mentor dot com> 2012-03-23 22:46:37 UTC --- (In reply to comment #6) > (In reply to comment #5) > > Carlos, > > I don't believe you've understood the problem. > > Default stack sizes are fine. > > But aio_write creates a small (16K) stack, and chrome creates 128K stacks. > > Normally this is also just fine; and all works. > > But then application creates a larger-than-usual TLS (either by allocating > 4096 thread-local ints as in the test case here, or by instrumenting for > profiling), and suddenly things start crashing in hard-to-diagnose fashion. That does make the problem clearer. Please note that the aio helper thread *should* be using a default 2MB stack on x86, not 16K, I don't see anywhere that sets the helper threads stack to 16K. > > We do not want to penalize all of the other programs that don't need the extra > > stack space. > > You aren't penalizing them much if they aren't using TLS, and if they are > using large TLS, then you are making them work instead of crashing. You are also increasing the memory footprint of all applications that use TLS that worked fine before. Before making any changes we need to hear from the distros (RH, SuSE, Debian, Gentoo, Ubuntu etc) about the kind of impact this might have e.g. a quick find / readelf -a / grep to determine on average the memory increase we are looking at. > From "man pthread_attr_setstacksize": > > > The pthread_attr_setstacksize() function sets the stack size attribute of > the thread attributes object referred to by attr to the value specified > in stacksize. > > It doesn't say "to the value specified in stacksize minus the size of TLS". > > The fact that GLIBC chops off space for TLS from the top of stack is an > implementation detail, and (IMHO) should *not* reduce the stack size > application actually gets! The "stack" is purposely ambiguous and once handed over to the implementation the implementation has complete control and can do what it wishes including use some of it for TLS which is what we do. http://pubs.opengroup.org/onlinepubs/007904975/functions/xsh_chap02_09.html#tag_02_09_08 Having said that it is *bad* for us to crash in the *DEFAULT* case because TLS data takes up the entire default stack. However, you are arguing for variable sized thread stacks based on TLS data, which is a fine suggestion but needs serious consideration. There are multiple cases here. (a) App. provides memory (pthread_attr_setstackaddr, pthread_attr_setstack). (b) App. requests minimum size (pthread_attr_setstacksize). (c) App. makes no request, and RLIMIT_STACK is set and >= PTHREAD_STACK_MIN. (d) App. makes no request, and RLIMIT_STACK is set and < PTHREAD_STACK_MIN. (e) App. makes no request, and RLIMIT_STACK is 0/inf. What do you suggest for each of these cases? Are there any other cases I might have missed? In the current implementation we do the following: For (a) we use the user memory for everything we need. For (b) we allocate the minimum and use that for everything we need. For (c) we allocate the value of RLIMIT_STACK only if it's >= minstack, otherwise minstack (nptl-init.c) and use that for everything we need. For (d) we allocate the value of PTHREAD_STACK_MIN only if it's >= minstack, otherwise minstack (nptl-init.c) and use that for everything we need. For (e) we allocate the value of ARCH_STACK_DEFAULT_SIZE only if it's >= minstack, otherwise minstack (nptl-init.c) and use that for everything we need. You appear to be suggesting the following: For (a) the behaviour remains the same. For (b) we adjust upward by the size of the static TLS data. For (c) " For (d) " For (e) " In which case the patch is probably to nptl-init.c to change the computation of the default size. -- Configure bugmail: http://sourceware.org/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
next prev parent reply other threads:[~2012-03-23 22:47 UTC|newest] Thread overview: 64+ messages / expand[flat|nested] mbox.gz Atom feed top [not found] <bug-11787-131@http.sourceware.org/bugzilla/> 2012-02-24 4:35 ` ppluzhnikov at google dot com 2012-02-24 19:36 ` asharif.tools at gmail dot com 2012-03-22 21:48 ` asharif.tools at gmail dot com 2012-03-23 20:35 ` vapier at gentoo dot org 2012-03-23 20:37 ` carlos_odonell at mentor dot com 2012-03-23 20:39 ` carlos_odonell at mentor dot com 2012-03-23 21:33 ` carlos_odonell at mentor dot com 2012-03-23 22:07 ` ppluzhnikov at google dot com 2012-03-23 22:47 ` asharif.tools at gmail dot com 2012-03-23 22:51 ` carlos_odonell at mentor dot com [this message] 2012-03-23 23:02 ` carlos_odonell at mentor dot com 2012-03-23 23:03 ` carlos_odonell at mentor dot com 2012-03-24 2:22 ` carlos_odonell at mentor dot com 2012-03-24 10:30 ` ppluzhnikov at google dot com 2012-03-24 16:10 ` carlos_odonell at mentor dot com 2012-03-24 17:08 ` carlos_odonell at mentor dot com 2012-03-24 17:39 ` vapier at gentoo dot org 2012-03-24 18:30 ` ppluzhnikov at google dot com 2012-03-24 20:13 ` carlos_odonell at mentor dot com 2012-03-24 20:46 ` carlos_odonell at mentor dot com 2012-03-24 20:57 ` ppluzhnikov at google dot com 2012-03-25 2:01 ` carlos_odonell at mentor dot com 2012-03-25 23:16 ` vapier at gentoo dot org 2012-03-26 14:29 ` joseph at codesourcery dot com 2012-03-26 17:44 ` carlos_odonell at mentor dot com 2012-03-27 21:21 ` carlos_odonell at mentor dot com 2012-03-30 16:21 ` carlos_odonell at mentor dot com 2012-03-30 16:46 ` law at redhat dot com 2012-03-30 21:28 ` ppluzhnikov at google dot com 2012-04-01 19:47 ` carlos_odonell at mentor dot com 2012-04-24 22:03 ` asharif.tools at gmail dot com 2012-04-24 22:36 ` carlos_odonell at mentor dot com 2012-04-25 2:55 ` vapier at gentoo dot org 2012-04-25 18:25 ` asharif.tools at gmail dot com 2012-04-25 20:11 ` carlos_odonell at mentor dot com 2012-05-07 21:22 ` [Bug libc/11787] Program with large TLS segments fail carlos_odonell at mentor dot com 2012-05-17 14:11 ` carlos_odonell at mentor dot com 2012-05-22 7:05 ` siddhesh at redhat dot com 2012-05-23 16:41 ` carlos_odonell at mentor dot com 2012-05-23 17:09 ` siddhesh at redhat dot com 2012-05-23 17:09 ` siddhesh at redhat dot com 2012-06-05 15:15 ` ian at airs dot com 2012-11-19 6:18 ` carlos_odonell at mentor dot com 2012-12-03 23:52 ` carlos at systemhalted dot org 2012-12-03 23:53 ` carlos at systemhalted dot org 2013-04-26 18:06 ` ppluzhnikov at google dot com 2013-04-27 2:02 ` bugdal at aerifal dot cx 2013-05-22 18:40 ` carlos at redhat dot com 2013-09-13 21:45 ` bas at bmail dot ru 2013-11-23 9:05 ` david.abdurachmanov at gmail dot com 2013-11-23 9:20 ` david.abdurachmanov at gmail dot com 2013-11-24 15:58 ` carlos at redhat dot com 2014-02-16 19:42 ` jackie.rosen at hushmail dot com 2014-05-28 19:41 ` schwab at sourceware dot org 2014-06-30 17:33 ` fweimer at redhat dot com 2014-07-02 6:06 ` fweimer at redhat dot com 2015-03-23 2:50 ` andersk at mit dot edu 2015-08-22 21:36 ` [Bug dynamic-link/11787] " jsm28 at gcc dot gnu.org 2020-06-15 16:23 ` john.wellesz at hiventy dot com 2021-06-19 8:05 ` a3at.mail at gmail dot com 2022-01-26 6:44 ` sam at gentoo dot org 2022-06-07 8:09 ` i at maskray dot me 2022-11-06 20:12 ` i at maskray dot me 2010-07-02 23:02 [Bug libc/11787] New: Program with large TLS segment fails aio_write ppluzhnikov at google dot com 2010-07-02 23:03 ` [Bug libc/11787] " ppluzhnikov at google dot com
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=bug-11787-131-dXN69qGvng@http.sourceware.org/bugzilla/ \ --to=sourceware-bugzilla@sourceware.org \ --cc=glibc-bugs@sources.redhat.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).