public inbox for glibc-bugs@sourceware.org
help / color / mirror / Atom feed
* [Bug admin/17813] New: Incorrect Expression
@ 2015-01-08 4:35 sourceware-bugs at internot dot info
2015-01-08 5:43 ` [Bug libc/17813] " ldv at altlinux dot org
` (2 more replies)
0 siblings, 3 replies; 4+ messages in thread
From: sourceware-bugs at internot dot info @ 2015-01-08 4:35 UTC (permalink / raw)
To: glibc-bugs
https://sourceware.org/bugzilla/show_bug.cgi?id=17813
Bug ID: 17813
Summary: Incorrect Expression
Product: glibc
Version: unspecified
Status: NEW
Severity: normal
Priority: P2
Component: admin
Assignee: unassigned at sourceware dot org
Reporter: sourceware-bugs at internot dot info
CC: carlos at redhat dot com, roland at gnu dot org
Hi,
In /time/strftime_l.c:
1280 if (modifier == L_('O'))
1281 goto bad_format;
1282 else
1283 DO_NUMBER (1, tp->tm_year + TM_YEAR_BASE);
but DO_NUMBER is a macro:
741#define DO_NUMBER(d, v) \
742 digits = d > width ? d : width;
\
743 number_value = v; goto do_number
which will not run correctly unless DO_NUMBER is in { }'s.
Thanks,
--
You are receiving this mail because:
You are on the CC list for the bug.
^ permalink raw reply [flat|nested] 4+ messages in thread
* [Bug libc/17813] Incorrect Expression
2015-01-08 4:35 [Bug admin/17813] New: Incorrect Expression sourceware-bugs at internot dot info
@ 2015-01-08 5:43 ` ldv at altlinux dot org
2015-01-08 9:13 ` mikpelinux at gmail dot com
2015-08-27 22:25 ` [Bug time/17813] " jsm28 at gcc dot gnu.org
2 siblings, 0 replies; 4+ messages in thread
From: ldv at altlinux dot org @ 2015-01-08 5:43 UTC (permalink / raw)
To: glibc-bugs
https://sourceware.org/bugzilla/show_bug.cgi?id=17813
Dmitry V. Levin <ldv at altlinux dot org> changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |drepper.fsp at gmail dot com
Component|admin |libc
--
You are receiving this mail because:
You are on the CC list for the bug.
^ permalink raw reply [flat|nested] 4+ messages in thread
* [Bug libc/17813] Incorrect Expression
2015-01-08 4:35 [Bug admin/17813] New: Incorrect Expression sourceware-bugs at internot dot info
2015-01-08 5:43 ` [Bug libc/17813] " ldv at altlinux dot org
@ 2015-01-08 9:13 ` mikpelinux at gmail dot com
2015-08-27 22:25 ` [Bug time/17813] " jsm28 at gcc dot gnu.org
2 siblings, 0 replies; 4+ messages in thread
From: mikpelinux at gmail dot com @ 2015-01-08 9:13 UTC (permalink / raw)
To: glibc-bugs
https://sourceware.org/bugzilla/show_bug.cgi?id=17813
Mikael Pettersson <mikpelinux at gmail dot com> changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |mikpelinux at gmail dot com
--- Comment #1 from Mikael Pettersson <mikpelinux at gmail dot com> ---
In general, yes, but in this specific case the "then" statement is a goto so it
doesn't matter (except for readability) that the "else" statement gets broken
up.
Fixing DO_NUMBER to wrap its body in a do{}while(0) would nevertheless be a
good change.
--
You are receiving this mail because:
You are on the CC list for the bug.
^ permalink raw reply [flat|nested] 4+ messages in thread
* [Bug time/17813] Incorrect Expression
2015-01-08 4:35 [Bug admin/17813] New: Incorrect Expression sourceware-bugs at internot dot info
2015-01-08 5:43 ` [Bug libc/17813] " ldv at altlinux dot org
2015-01-08 9:13 ` mikpelinux at gmail dot com
@ 2015-08-27 22:25 ` jsm28 at gcc dot gnu.org
2 siblings, 0 replies; 4+ messages in thread
From: jsm28 at gcc dot gnu.org @ 2015-08-27 22:25 UTC (permalink / raw)
To: glibc-bugs
https://sourceware.org/bugzilla/show_bug.cgi?id=17813
Joseph Myers <jsm28 at gcc dot gnu.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Component|libc |time
--
You are receiving this mail because:
You are on the CC list for the bug.
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2015-08-27 22:25 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2015-01-08 4:35 [Bug admin/17813] New: Incorrect Expression sourceware-bugs at internot dot info
2015-01-08 5:43 ` [Bug libc/17813] " ldv at altlinux dot org
2015-01-08 9:13 ` mikpelinux at gmail dot com
2015-08-27 22:25 ` [Bug time/17813] " jsm28 at gcc dot gnu.org
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).