[Bug admin/17813] New: Incorrect Expression

[Bug admin/17813] New: Incorrect Expression

[sourceware-bugs at internot dot info]

https://sourceware.org/bugzilla/show_bug.cgi?id=17813

            Bug ID: 17813
           Summary: Incorrect Expression
           Product: glibc
           Version: unspecified
            Status: NEW
          Severity: normal
          Priority: P2
         Component: admin
          Assignee: unassigned at sourceware dot org
          Reporter: sourceware-bugs at internot dot info
                CC: carlos at redhat dot com, roland at gnu dot org

Hi,

In /time/strftime_l.c:

1280          if (modifier == L_('O'))
1281            goto bad_format;
1282          else
1283            DO_NUMBER (1, tp->tm_year + TM_YEAR_BASE);

but DO_NUMBER is a macro:

741#define DO_NUMBER(d, v) \
742          digits = d > width ? d : width;                                   
 \
743          number_value = v; goto do_number


which will not run correctly unless DO_NUMBER is in { }'s.


Thanks,

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug libc/17813] Incorrect Expression

[ldv at altlinux dot org]

https://sourceware.org/bugzilla/show_bug.cgi?id=17813

Dmitry V. Levin <ldv at altlinux dot org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |drepper.fsp at gmail dot com
          Component|admin                       |libc

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug libc/17813] Incorrect Expression

[mikpelinux at gmail dot com]

https://sourceware.org/bugzilla/show_bug.cgi?id=17813

Mikael Pettersson <mikpelinux at gmail dot com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |mikpelinux at gmail dot com

--- Comment #1 from Mikael Pettersson <mikpelinux at gmail dot com> ---
In general, yes, but in this specific case the "then" statement is a goto so it
doesn't matter (except for readability) that the "else" statement gets broken
up.

Fixing DO_NUMBER to wrap its body in a do{}while(0) would nevertheless be a
good change.

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug time/17813] Incorrect Expression

[jsm28 at gcc dot gnu.org]

https://sourceware.org/bugzilla/show_bug.cgi?id=17813

Joseph Myers <jsm28 at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
          Component|libc                        |time

-- 
You are receiving this mail because:
You are on the CC list for the bug.