public inbox for glibc-bugs@sourceware.org
help / color / mirror / Atom feed
* [Bug nss/27416] New: __nss_database_lookup2 ignores defconfig
@ 2021-02-14 19:58 schwab@linux-m68k.org
  2021-02-14 20:05 ` [Bug nss/27416] __nss_database_lookup2 ignores defconfig and alternate_name schwab@linux-m68k.org
                   ` (2 more replies)
  0 siblings, 3 replies; 4+ messages in thread
From: schwab@linux-m68k.org @ 2021-02-14 19:58 UTC (permalink / raw)
  To: glibc-bugs

https://sourceware.org/bugzilla/show_bug.cgi?id=27416

            Bug ID: 27416
           Summary: __nss_database_lookup2 ignores defconfig
           Product: glibc
           Version: 2.33
            Status: NEW
          Severity: normal
          Priority: P2
         Component: nss
          Assignee: unassigned at sourceware dot org
          Reporter: schwab@linux-m68k.org
                CC: dj at redhat dot com
  Target Milestone: ---

If nsswitch.conf contains no entry for a nonstandard database it is assumed
empty, even if the caller of __nss_database_lookup2 provides a default config. 
This breaks nss_compat.

-- 
You are receiving this mail because:
You are on the CC list for the bug.

^ permalink raw reply	[flat|nested] 4+ messages in thread

* [Bug nss/27416] __nss_database_lookup2 ignores defconfig and alternate_name
  2021-02-14 19:58 [Bug nss/27416] New: __nss_database_lookup2 ignores defconfig schwab@linux-m68k.org
@ 2021-02-14 20:05 ` schwab@linux-m68k.org
  2022-01-09 21:38 ` aurelien at aurel32 dot net
  2022-01-10 12:37 ` fweimer at redhat dot com
  2 siblings, 0 replies; 4+ messages in thread
From: schwab@linux-m68k.org @ 2021-02-14 20:05 UTC (permalink / raw)
  To: glibc-bugs

https://sourceware.org/bugzilla/show_bug.cgi?id=27416

Andreas Schwab <schwab@linux-m68k.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Summary|__nss_database_lookup2      |__nss_database_lookup2
                   |ignores defconfig           |ignores defconfig and
                   |                            |alternate_name

--- Comment #1 from Andreas Schwab <schwab@linux-m68k.org> ---
It also ignores alternate_name.

-- 
You are receiving this mail because:
You are on the CC list for the bug.

^ permalink raw reply	[flat|nested] 4+ messages in thread

* [Bug nss/27416] __nss_database_lookup2 ignores defconfig and alternate_name
  2021-02-14 19:58 [Bug nss/27416] New: __nss_database_lookup2 ignores defconfig schwab@linux-m68k.org
  2021-02-14 20:05 ` [Bug nss/27416] __nss_database_lookup2 ignores defconfig and alternate_name schwab@linux-m68k.org
@ 2022-01-09 21:38 ` aurelien at aurel32 dot net
  2022-01-10 12:37 ` fweimer at redhat dot com
  2 siblings, 0 replies; 4+ messages in thread
From: aurelien at aurel32 dot net @ 2022-01-09 21:38 UTC (permalink / raw)
  To: glibc-bugs

https://sourceware.org/bugzilla/show_bug.cgi?id=27416

Aurelien Jarno <aurelien at aurel32 dot net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |aurelien at aurel32 dot net

--- Comment #2 from Aurelien Jarno <aurelien at aurel32 dot net> ---
It seems the following commit is a fix for this bug:

https://sourceware.org/git/?p=glibc.git;a=commit;h=9b456c5da968ee832ea4b2b73a18a5bf6d2118a6

Maybe it should be closed?

-- 
You are receiving this mail because:
You are on the CC list for the bug.

^ permalink raw reply	[flat|nested] 4+ messages in thread

* [Bug nss/27416] __nss_database_lookup2 ignores defconfig and alternate_name
  2021-02-14 19:58 [Bug nss/27416] New: __nss_database_lookup2 ignores defconfig schwab@linux-m68k.org
  2021-02-14 20:05 ` [Bug nss/27416] __nss_database_lookup2 ignores defconfig and alternate_name schwab@linux-m68k.org
  2022-01-09 21:38 ` aurelien at aurel32 dot net
@ 2022-01-10 12:37 ` fweimer at redhat dot com
  2 siblings, 0 replies; 4+ messages in thread
From: fweimer at redhat dot com @ 2022-01-10 12:37 UTC (permalink / raw)
  To: glibc-bugs

https://sourceware.org/bugzilla/show_bug.cgi?id=27416

Florian Weimer <fweimer at redhat dot com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Target Milestone|---                         |2.34
         Resolution|---                         |FIXED
              Flags|                            |security-
                 CC|                            |fweimer at redhat dot com
             Status|NEW                         |RESOLVED

--- Comment #3 from Florian Weimer <fweimer at redhat dot com> ---
Thanks for the suggestion.

Fixed for 2.34 using:

commit 9b456c5da968ee832ea4b2b73a18a5bf6d2118a6
Author: DJ Delorie <dj@redhat.com>
Date:   Mon Feb 15 21:34:23 2021 -0500

    nss: fix nss_database_lookup2's alternate handling [BZ #27416]

    __nss_database_lookup2's extra arguments were left unused in the
    nsswitch reloading patch set; this broke compat (default config
    ignored) and shadow files (secondary name ignored) which relies on
    these fallbacks.

    This patch adds in the previous behavior by correcting the
    initialization of the database list to reflect the fallbacks.  This
    means that the nss_database_lookup2 interface no longer needs to be
    passed the fallback info, so API and callers were adjusted.

    Since all callers needed to be edited anyway, the calls were changed
    from __nss_database_lookup2 to the faster __nss_database_get.  This
    was an intended optimization which was deferred during the initial
    lookup changes to avoid touching so many files.

    The test case verifies that compat targets work (passwd) and that the
    default configuration works (group).  Tested on x86-64.

-- 
You are receiving this mail because:
You are on the CC list for the bug.

^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2022-01-10 12:37 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-02-14 19:58 [Bug nss/27416] New: __nss_database_lookup2 ignores defconfig schwab@linux-m68k.org
2021-02-14 20:05 ` [Bug nss/27416] __nss_database_lookup2 ignores defconfig and alternate_name schwab@linux-m68k.org
2022-01-09 21:38 ` aurelien at aurel32 dot net
2022-01-10 12:37 ` fweimer at redhat dot com

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).