[Bug libc/28572] Misaligned accesses in test-memcpy and test-mempcpy on hppa

["adhemerval.zanella at linaro dot org" <sourceware-bugzilla@sourceware.org>]

https://sourceware.org/bugzilla/show_bug.cgi?id=28572

--- Comment #12 from Adhemerval Zanella <adhemerval.zanella at linaro dot org> ---
The misaligned access come from string/test-memcpy-support.h, which uses the
input alignment to create 'uint32_t*' pointers.  This is the issue we should
fix for this bug report, but I don't think the patch proposed is the best
approach. I think the following should work, but I did not tested on machine
that does not support unaligned access:

diff --git a/string/test-memcpy-support.h b/string/test-memcpy-support.h
index 419158a420..69c983957f 100644
--- a/string/test-memcpy-support.h
+++ b/string/test-memcpy-support.h
@@ -141,7 +141,7 @@ do_test1 (size_t align1, size_t align2, size_t size)
   for (repeats = 0; repeats < 2; repeats++)
     {
       for (i = 0; i < array_size; i++)
-        src[i] = (uint32_t)i;
+        memcpy (&src[i], & (uint32_t){i}, sizeof (uint32_t));
       FOR_EACH_IMPL (impl, 0)
       {
         memset (dest, -1, size);
@@ -149,7 +149,7 @@ do_test1 (size_t align1, size_t align2, size_t size)
         if (memcmp (src, dest, size))
           {
             for (i = 0; i < array_size; i++)
-              if (dest[i] != src[i])
+             if (memcmp (&dest[i], &src[i], sizeof (uint32_t)) != 0)
                 {
                   error (0, 0,
                          "Wrong result in function %s dst \"%p\" src \"%p\" "


For the test-memcpy taking too much time, I think we should track it on another
bug.

-- 
You are receiving this mail because:
You are on the CC list for the bug.