[Bug libc/28572] Misaligned accesses in test-memcpy and test-mempcpy on hppa

["dave.anglin at bell dot net" <sourceware-bugzilla@sourceware.org>]

https://sourceware.org/bugzilla/show_bug.cgi?id=28572

--- Comment #13 from dave.anglin at bell dot net ---
On 2021-11-11 2:52 p.m., goldstein.w.n at gmail dot com wrote:
> https://sourceware.org/bugzilla/show_bug.cgi?id=28572
>
> --- Comment #9 from Noah Goldstein <goldstein.w.n at gmail dot com> ---
> (In reply to H.J. Lu from comment #8)
>> memcpy should work on unaligned addresses.  Also we need to increase
>> TIMEOUT for memcpy.
> It does "work" still. But if it takes 400+ minutes its not really a useful
> test.
That only happens when the unaligned accesses fault.  What's wrong with marking
the src
and dst types as unaligned pointers (i.e., alignment of 1)?

It's easy to modify the typedef in the patch to only use alignment 1 on hppa
and other strict
alignment architectures.
>
> I think these tests are important for x86 but if the burden on other targets
> is too high it doesn't seem reasonable to have them in `string/`
I agree.  HJL already bumped timeout.  How much impact does patch have on x86?

commit a6a9c1a36b48f304c8a2138c147d88a448161366
Author: H.J. Lu <hjl.tools@gmail.com>
Date:   Sun Nov 7 06:41:16 2021 -0800

     test-memcpy.c: Double TIMEOUT to (8 * 60)

     commit d585ba47fcda99fdf228e3e45a01b11a15efbc5a
     Author: Noah Goldstein <goldstein.w.n@gmail.com>
     Date:   Mon Nov 1 00:49:48 2021 -0500

         string: Make tests birdirectional test-memcpy.c

         This commit updates the memcpy tests to test both dst > src and dst <
         src. This is because there is logic in the code based on the

         Signed-off-by: Noah Goldstein <goldstein.w.n@gmail.com>
         Reviewed-by: H.J. Lu <hjl.tools@gmail.com>

     significantly increased the number of tests.  On Intel Core i7-1165G7,
     test-memcpy takes 120 seconds to run when machine is idle. Double
     TIMEOUT to (8 * 60) for test-memcpy to avoid timeout when machine is
     under heavy load.

Dave

-- 
You are receiving this mail because:
You are on the CC list for the bug.