public inbox for glibc-bugs@sourceware.org
help / color / mirror / Atom feed
From: "dave.anglin at bell dot net" <sourceware-bugzilla@sourceware.org>
To: glibc-bugs@sourceware.org
Subject: [Bug libc/28572] Misaligned accesses in test-memcpy and test-mempcpy on hppa
Date: Thu, 11 Nov 2021 17:53:18 +0000	[thread overview]
Message-ID: <bug-28572-131-Wv15rbwogM@http.sourceware.org/bugzilla/> (raw)
In-Reply-To: <bug-28572-131@http.sourceware.org/bugzilla/>

https://sourceware.org/bugzilla/show_bug.cgi?id=28572

--- Comment #6 from dave.anglin at bell dot net ---
On 2021-11-11 12:39 p.m., goldstein.w.n at gmail dot com wrote:
> commit d585ba47fcda99fdf228e3e45a01b11a15efbc5a
> Author: Noah Goldstein<goldstein.w.n@gmail.com>
> Date:   Mon Nov 1 00:49:48 2021 -0500
>
>      string: Make tests birdirectional test-memcpy.c
>
>
> If its d585ba47fcda99fdf228e3e45a01b11a15efbc5a then the issue is simply with
> the new tests.
It's the new tests that introduced the unaligned accesses.  That works okay on
x86 but not
on targets like PA-RISC that require strict alignment.  Even on x86, I believe
unaligned accesses
are slower than aligned ones.

There's a unaligned handler in PA-RISC Linux kernel but it's slow.
>
> I added them really just for x86_64 because the large memcpy case has some
> complicated logic that was not previously tested.
>
> Possibly for the large memcpy tests we could only iterate through
> implementations returned by the ifunc and skip the generic/simple
> implementations to speed things up?
Test passes on hppa with change change attached to bug but takes about 13
minutes.

-- 
You are receiving this mail because:
You are on the CC list for the bug.

  parent reply	other threads:[~2021-11-11 17:53 UTC|newest]

Thread overview: 23+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-11-09 17:32 [Bug libc/28572] New: " danglin at gcc dot gnu.org
2021-11-09 17:42 ` [Bug libc/28572] " adhemerval.zanella at linaro dot org
2021-11-09 20:56 ` dave.anglin at bell dot net
2021-11-11 17:02 ` danglin at gcc dot gnu.org
2021-11-11 17:17 ` danglin at gcc dot gnu.org
2021-11-11 17:25 ` danglin at gcc dot gnu.org
2021-11-11 17:39 ` goldstein.w.n at gmail dot com
2021-11-11 17:53 ` dave.anglin at bell dot net [this message]
2021-11-11 18:22 ` goldstein.w.n at gmail dot com
2021-11-11 18:27 ` goldstein.w.n at gmail dot com
2021-11-11 19:50 ` hjl.tools at gmail dot com
2021-11-11 19:52 ` goldstein.w.n at gmail dot com
2021-11-11 20:03 ` hjl.tools at gmail dot com
2021-11-11 20:04 ` goldstein.w.n at gmail dot com
2021-11-11 20:05 ` adhemerval.zanella at linaro dot org
2021-11-11 20:05 ` dave.anglin at bell dot net
2021-11-11 20:24 ` dave.anglin at bell dot net
2021-11-11 20:30 ` goldstein.w.n at gmail dot com
2021-11-11 20:31 ` goldstein.w.n at gmail dot com
2021-11-12 14:51 ` danglin at gcc dot gnu.org
2021-12-08  4:21 ` goldstein.w.n at gmail dot com
2021-12-08 14:11 ` dave.anglin at bell dot net
2022-01-05 13:39 ` hjl.tools at gmail dot com

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=bug-28572-131-Wv15rbwogM@http.sourceware.org/bugzilla/ \
    --to=sourceware-bugzilla@sourceware.org \
    --cc=glibc-bugs@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).