[Bug string/29162] New: [PATCH] string.h syntactic error: include/bits/string_fortified.h:110: error: expected ',' or ';' before '__fortified_attr_access'

[Bug string/29162] New: [PATCH] string.h syntactic error: include/bits/string_fortified.h:110: error: expected ',' or ';' before '__fortified_attr_access'

[slyich at gmail dot com]

https://sourceware.org/bugzilla/show_bug.cgi?id=29162

            Bug ID: 29162
           Summary: [PATCH] string.h syntactic error:
                    include/bits/string_fortified.h:110: error: expected
                    ',' or ';' before '__fortified_attr_access'
           Product: glibc
           Version: 2.35
            Status: UNCONFIRMED
          Severity: normal
          Priority: P2
         Component: string
          Assignee: unassigned at sourceware dot org
          Reporter: slyich at gmail dot com
                CC: siddhesh at sourceware dot org
  Target Milestone: ---

Created attachment 14109
  --> https://sourceware.org/bugzilla/attachment.cgi?id=14109&action=edit
0001-string.h-fix-__fortified_attr_access-macro-call.patch

Initially noticed as a gnat-6 build failure:
https://hydra.nixos.org/log/1rya10nw23lm6im8frkk5z3ic9ibb80m-gnat-6.5.0.drv

/nix/store/hd3j5xfvffs4vaa74l1har94q10fpnm5-glibc-2.34-210-dev/include/bits/string_fortified.h:110:50:
error: macro "__fortified_attr_access" requires 3 arguments, but only 1 given

I think it's a recent glibc regression from commit
e938c02748402c50f60ba0eb983273e7b52937d1 "Don't add access size hints to
fortifiable functions".

I'm testing locally the following fix:

--- a/string/bits/string_fortified.h
+++ b/string/bits/string_fortified.h
@@ -107,7 +107,7 @@ __NTH (stpncpy (char *__dest, const char *__src, size_t
__n))
 # else
 extern char *__stpncpy_chk (char *__dest, const char *__src, size_t __n,
                            size_t __destlen) __THROW
-  __fortified_attr_access ((__write_only__, 1, 3))
+  __fortified_attr_access (__write_only__, 1, 3)
   __attr_access ((__read_only__, 2));
 extern char *__REDIRECT_NTH (__stpncpy_alias, (char *__dest, const char
*__src,
                                               size_t __n), stpncpy);

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug string/29162] [PATCH] string.h syntactic error: include/bits/string_fortified.h:110: error: expected ',' or ';' before '__fortified_attr_access'

[slyich at gmail dot com]

https://sourceware.org/bugzilla/show_bug.cgi?id=29162

--- Comment #1 from Sergei Trofimovich <slyich at gmail dot com> ---
Sent to mailing list as
https://sourceware.org/pipermail/libc-alpha/2022-May/138943.html

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug string/29162] [PATCH] string.h syntactic error: include/bits/string_fortified.h:110: error: expected ',' or ';' before '__fortified_attr_access'

[siddhesh at sourceware dot org]

https://sourceware.org/bugzilla/show_bug.cgi?id=29162

Siddhesh Poyarekar <siddhesh at sourceware dot org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Target Milestone|---                         |2.36
         Resolution|---                         |FIXED
             Status|UNCONFIRMED                 |RESOLVED

--- Comment #2 from Siddhesh Poyarekar <siddhesh at sourceware dot org> ---
Fixed in master, 2.35 and 2.34.

-- 
You are receiving this mail because:
You are on the CC list for the bug.