[Bug libc/29330] New: hp-timing not correct for graviton

[Bug libc/29330] New: hp-timing not correct for graviton

[juntangc at amazon dot com]

https://sourceware.org/bugzilla/show_bug.cgi?id=29330

            Bug ID: 29330
           Summary: hp-timing not correct for graviton
           Product: glibc
           Version: unspecified
            Status: UNCONFIRMED
          Severity: minor
          Priority: P2
         Component: libc
          Assignee: unassigned at sourceware dot org
          Reporter: juntangc at amazon dot com
                CC: drepper.fsp at gmail dot com
  Target Milestone: ---

hp-timing is only used on benchtests today, but it can be used on other things
in the future. It's broken on graviton beacuse the freq we have is 1050000000.
1000000000ULL/1050000000ULL = 0 and thus benchtests output are all 0.

The following patch can fix the bug:

```
diff --git a/sysdeps/aarch64/hp-timing.h b/sysdeps/aarch64/hp-timing.h
index f7f7ac7cae..270e0c2e24 100644
--- a/sysdeps/aarch64/hp-timing.h
+++ b/sysdeps/aarch64/hp-timing.h
@@ -41,7 +41,7 @@ typedef uint64_t hp_timing_t;
 #define HP_TIMING_DIFF(Diff, Start, End)                       \
 ({  hp_timing_t freq;                                          \
     __asm__ __volatile__ ("mrs %0, cntfrq_el0" : "=r" (freq)); \
-   (Diff) = ((End) - (Start)) * (UINT64_C(1000000000) / freq); \
+   (Diff) = (hp_timing_t)((End) - (Start)) * ((1000000000.0) / freq);  \
 })

 #endif /* hp-timing.h */
```

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug libc/29330] hp-timing not correct for graviton

[fweimer at redhat dot com]

https://sourceware.org/bugzilla/show_bug.cgi?id=29330

Florian Weimer <fweimer at redhat dot com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
              Flags|                            |security-
                 CC|                            |fweimer at redhat dot com
         Resolution|---                         |DUPLICATE
             Status|UNCONFIRMED                 |RESOLVED

--- Comment #1 from Florian Weimer <fweimer at redhat dot com> ---
Looks like an exact duplicate.

*** This bug has been marked as a duplicate of bug 29329 ***

-- 
You are receiving this mail because:
You are on the CC list for the bug.