public inbox for glibc-bugs@sourceware.org
help / color / mirror / Atom feed
* [Bug libc/29330] New: hp-timing not correct for graviton
@ 2022-07-07 16:42 juntangc at amazon dot com
2022-07-07 17:50 ` [Bug libc/29330] " fweimer at redhat dot com
0 siblings, 1 reply; 2+ messages in thread
From: juntangc at amazon dot com @ 2022-07-07 16:42 UTC (permalink / raw)
To: glibc-bugs
https://sourceware.org/bugzilla/show_bug.cgi?id=29330
Bug ID: 29330
Summary: hp-timing not correct for graviton
Product: glibc
Version: unspecified
Status: UNCONFIRMED
Severity: minor
Priority: P2
Component: libc
Assignee: unassigned at sourceware dot org
Reporter: juntangc at amazon dot com
CC: drepper.fsp at gmail dot com
Target Milestone: ---
hp-timing is only used on benchtests today, but it can be used on other things
in the future. It's broken on graviton beacuse the freq we have is 1050000000.
1000000000ULL/1050000000ULL = 0 and thus benchtests output are all 0.
The following patch can fix the bug:
```
diff --git a/sysdeps/aarch64/hp-timing.h b/sysdeps/aarch64/hp-timing.h
index f7f7ac7cae..270e0c2e24 100644
--- a/sysdeps/aarch64/hp-timing.h
+++ b/sysdeps/aarch64/hp-timing.h
@@ -41,7 +41,7 @@ typedef uint64_t hp_timing_t;
#define HP_TIMING_DIFF(Diff, Start, End) \
({ hp_timing_t freq; \
__asm__ __volatile__ ("mrs %0, cntfrq_el0" : "=r" (freq)); \
- (Diff) = ((End) - (Start)) * (UINT64_C(1000000000) / freq); \
+ (Diff) = (hp_timing_t)((End) - (Start)) * ((1000000000.0) / freq); \
})
#endif /* hp-timing.h */
```
--
You are receiving this mail because:
You are on the CC list for the bug.
^ permalink raw reply [flat|nested] 2+ messages in thread
* [Bug libc/29330] hp-timing not correct for graviton
2022-07-07 16:42 [Bug libc/29330] New: hp-timing not correct for graviton juntangc at amazon dot com
@ 2022-07-07 17:50 ` fweimer at redhat dot com
0 siblings, 0 replies; 2+ messages in thread
From: fweimer at redhat dot com @ 2022-07-07 17:50 UTC (permalink / raw)
To: glibc-bugs
https://sourceware.org/bugzilla/show_bug.cgi?id=29330
Florian Weimer <fweimer at redhat dot com> changed:
What |Removed |Added
----------------------------------------------------------------------------
Flags| |security-
CC| |fweimer at redhat dot com
Resolution|--- |DUPLICATE
Status|UNCONFIRMED |RESOLVED
--- Comment #1 from Florian Weimer <fweimer at redhat dot com> ---
Looks like an exact duplicate.
*** This bug has been marked as a duplicate of bug 29329 ***
--
You are receiving this mail because:
You are on the CC list for the bug.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2022-07-07 17:50 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-07-07 16:42 [Bug libc/29330] New: hp-timing not correct for graviton juntangc at amazon dot com
2022-07-07 17:50 ` [Bug libc/29330] " fweimer at redhat dot com
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).