* [Bug build/29454] dl-cache.c:513: undefined reference to `strcpy' with -Og or -O1 (doesn't happen with -O2)
2022-08-07 13:50 [Bug build/29454] New: dl-cache.c:513: undefined reference to `strcpy' with -Og or -O1 (doesn't happen with -O2) Martin.Jansa at gmail dot com
@ 2022-08-07 13:51 ` Martin.Jansa at gmail dot com
2022-08-07 14:36 ` Martin.Jansa at gmail dot com
` (26 subsequent siblings)
27 siblings, 0 replies; 29+ messages in thread
From: Martin.Jansa at gmail dot com @ 2022-08-07 13:51 UTC (permalink / raw)
To: glibc-bugs
https://sourceware.org/bugzilla/show_bug.cgi?id=29454
Martin Jansa <Martin.Jansa at gmail dot com> changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |goldstein.w.n at gmail dot com
--
You are receiving this mail because:
You are on the CC list for the bug.
^ permalink raw reply [flat|nested] 29+ messages in thread* [Bug build/29454] dl-cache.c:513: undefined reference to `strcpy' with -Og or -O1 (doesn't happen with -O2)
2022-08-07 13:50 [Bug build/29454] New: dl-cache.c:513: undefined reference to `strcpy' with -Og or -O1 (doesn't happen with -O2) Martin.Jansa at gmail dot com
2022-08-07 13:51 ` [Bug build/29454] " Martin.Jansa at gmail dot com
@ 2022-08-07 14:36 ` Martin.Jansa at gmail dot com
2022-08-07 14:43 ` goldstein.w.n at gmail dot com
` (25 subsequent siblings)
27 siblings, 0 replies; 29+ messages in thread
From: Martin.Jansa at gmail dot com @ 2022-08-07 14:36 UTC (permalink / raw)
To: glibc-bugs
https://sourceware.org/bugzilla/show_bug.cgi?id=29454
--- Comment #1 from Martin Jansa <Martin.Jansa at gmail dot com> ---
diffoscope output when comparing elf/dl-cache.os built with -Og and O2.
| /usr/src/debug/glibc/2.36-r0/git/elf/dl-cache.c:513
│ - call 881 <_dl_load_cache_lookup+0xa1>
│ - R_X86_64_PLT32 memcpy-0x4
│ - mov %rax,%rdi
│ + mov %rbx,%rsi
│ + mov %r12,%rdi
│ + call 7c9 <_dl_load_cache_lookup+0xaa>
│ + R_X86_64_PLT32 strcpy-0x4
│ /usr/src/debug/glibc/2.36-r0/git/elf/dl-cache.c:514
│ - call 889 <_dl_load_cache_lookup+0xa9>
│ + mov %r12,%rdi
│ + call 7d1 <_dl_load_cache_lookup+0xb2>
│ R_X86_64_PLT32 __strdup-0x4
And then it's also reproducible with dl-cache.os rebuilt using "-O2
-fno-builtin-strcpy"
--
You are receiving this mail because:
You are on the CC list for the bug.
^ permalink raw reply [flat|nested] 29+ messages in thread* [Bug build/29454] dl-cache.c:513: undefined reference to `strcpy' with -Og or -O1 (doesn't happen with -O2)
2022-08-07 13:50 [Bug build/29454] New: dl-cache.c:513: undefined reference to `strcpy' with -Og or -O1 (doesn't happen with -O2) Martin.Jansa at gmail dot com
2022-08-07 13:51 ` [Bug build/29454] " Martin.Jansa at gmail dot com
2022-08-07 14:36 ` Martin.Jansa at gmail dot com
@ 2022-08-07 14:43 ` goldstein.w.n at gmail dot com
2022-08-07 14:44 ` goldstein.w.n at gmail dot com
` (24 subsequent siblings)
27 siblings, 0 replies; 29+ messages in thread
From: goldstein.w.n at gmail dot com @ 2022-08-07 14:43 UTC (permalink / raw)
To: glibc-bugs
https://sourceware.org/bugzilla/show_bug.cgi?id=29454
--- Comment #2 from Noah Goldstein <goldstein.w.n at gmail dot com> ---
Created attachment 14258
--> https://sourceware.org/bugzilla/attachment.cgi?id=14258&action=edit
Fix strcpy ifndef guard
--
You are receiving this mail because:
You are on the CC list for the bug.
^ permalink raw reply [flat|nested] 29+ messages in thread* [Bug build/29454] dl-cache.c:513: undefined reference to `strcpy' with -Og or -O1 (doesn't happen with -O2)
2022-08-07 13:50 [Bug build/29454] New: dl-cache.c:513: undefined reference to `strcpy' with -Og or -O1 (doesn't happen with -O2) Martin.Jansa at gmail dot com
` (2 preceding siblings ...)
2022-08-07 14:43 ` goldstein.w.n at gmail dot com
@ 2022-08-07 14:44 ` goldstein.w.n at gmail dot com
2022-08-07 15:00 ` Martin.Jansa at gmail dot com
` (23 subsequent siblings)
27 siblings, 0 replies; 29+ messages in thread
From: goldstein.w.n at gmail dot com @ 2022-08-07 14:44 UTC (permalink / raw)
To: glibc-bugs
https://sourceware.org/bugzilla/show_bug.cgi?id=29454
--- Comment #3 from Noah Goldstein <goldstein.w.n at gmail dot com> ---
(In reply to Martin Jansa from comment #1)
> diffoscope output when comparing elf/dl-cache.os built with -Og and O2.
>
> | /usr/src/debug/glibc/2.36-r0/git/elf/dl-cache.c:513
> │ - call 881 <_dl_load_cache_lookup+0xa1>
> │ - R_X86_64_PLT32 memcpy-0x4
> │ - mov %rax,%rdi
> │ + mov %rbx,%rsi
> │ + mov %r12,%rdi
> │ + call 7c9 <_dl_load_cache_lookup+0xaa>
> │ + R_X86_64_PLT32 strcpy-0x4
> │ /usr/src/debug/glibc/2.36-r0/git/elf/dl-cache.c:514
> │ - call 889 <_dl_load_cache_lookup+0xa9>
> │ + mov %r12,%rdi
> │ + call 7d1 <_dl_load_cache_lookup+0xb2>
> │ R_X86_64_PLT32 __strdup-0x4
>
> And then it's also reproducible with dl-cache.os rebuilt using "-O2
> -fno-builtin-strcpy"
Attached a patch can you test if that fixes it?
--
You are receiving this mail because:
You are on the CC list for the bug.
^ permalink raw reply [flat|nested] 29+ messages in thread* [Bug build/29454] dl-cache.c:513: undefined reference to `strcpy' with -Og or -O1 (doesn't happen with -O2)
2022-08-07 13:50 [Bug build/29454] New: dl-cache.c:513: undefined reference to `strcpy' with -Og or -O1 (doesn't happen with -O2) Martin.Jansa at gmail dot com
` (3 preceding siblings ...)
2022-08-07 14:44 ` goldstein.w.n at gmail dot com
@ 2022-08-07 15:00 ` Martin.Jansa at gmail dot com
2022-08-07 15:05 ` goldstein.w.n at gmail dot com
` (22 subsequent siblings)
27 siblings, 0 replies; 29+ messages in thread
From: Martin.Jansa at gmail dot com @ 2022-08-07 15:00 UTC (permalink / raw)
To: glibc-bugs
https://sourceware.org/bugzilla/show_bug.cgi?id=29454
--- Comment #4 from Martin Jansa <Martin.Jansa at gmail dot com> ---
Thanks for super fast reply, but the attached patch doesn't seem to fix it.
Also this "ifndef STPCPY" was introduced few commits later in:
49889fb256 x86: Add support to build st{p|r}{n}{cpy|cat} with explicit ISA
level
Cheers,
--
You are receiving this mail because:
You are on the CC list for the bug.
^ permalink raw reply [flat|nested] 29+ messages in thread* [Bug build/29454] dl-cache.c:513: undefined reference to `strcpy' with -Og or -O1 (doesn't happen with -O2)
2022-08-07 13:50 [Bug build/29454] New: dl-cache.c:513: undefined reference to `strcpy' with -Og or -O1 (doesn't happen with -O2) Martin.Jansa at gmail dot com
` (4 preceding siblings ...)
2022-08-07 15:00 ` Martin.Jansa at gmail dot com
@ 2022-08-07 15:05 ` goldstein.w.n at gmail dot com
2022-08-07 15:12 ` Martin.Jansa at gmail dot com
` (21 subsequent siblings)
27 siblings, 0 replies; 29+ messages in thread
From: goldstein.w.n at gmail dot com @ 2022-08-07 15:05 UTC (permalink / raw)
To: glibc-bugs
https://sourceware.org/bugzilla/show_bug.cgi?id=29454
--- Comment #5 from Noah Goldstein <goldstein.w.n at gmail dot com> ---
(In reply to Martin Jansa from comment #4)
> Thanks for super fast reply, but the attached patch doesn't seem to fix it.
>
> Also this "ifndef STPCPY" was introduced few commits later in:
> 49889fb256 x86: Add support to build st{p|r}{n}{cpy|cat} with explicit ISA
> level
>
> Cheers,
What is the exact command you are using?
I tried:
```
rm -rf /home/noah/programs/opensource/glibc-dev/build; mkdir -p
/home/noah/programs/opensource/glibc-dev/build/glibc/; (cd
/home/noah/programs/opensource/glibc-dev/build/glibc/; unset LD_LIBRARY_PATH;
/home/noah/programs/opensource/glibc-dev/src/glibc/configure --prefix=/usr
CC="gcc -march=core2 -Og"; CXX="g++ -march=core2 -Og"; make -j3 --silent;);
```
And wasn't able to reproduce this.
--
You are receiving this mail because:
You are on the CC list for the bug.
^ permalink raw reply [flat|nested] 29+ messages in thread* [Bug build/29454] dl-cache.c:513: undefined reference to `strcpy' with -Og or -O1 (doesn't happen with -O2)
2022-08-07 13:50 [Bug build/29454] New: dl-cache.c:513: undefined reference to `strcpy' with -Og or -O1 (doesn't happen with -O2) Martin.Jansa at gmail dot com
` (5 preceding siblings ...)
2022-08-07 15:05 ` goldstein.w.n at gmail dot com
@ 2022-08-07 15:12 ` Martin.Jansa at gmail dot com
2022-08-07 15:13 ` Martin.Jansa at gmail dot com
` (20 subsequent siblings)
27 siblings, 0 replies; 29+ messages in thread
From: Martin.Jansa at gmail dot com @ 2022-08-07 15:12 UTC (permalink / raw)
To: glibc-bugs
https://sourceware.org/bugzilla/show_bug.cgi?id=29454
--- Comment #6 from Martin Jansa <Martin.Jansa at gmail dot com> ---
Created attachment 14259
--> https://sourceware.org/bugzilla/attachment.cgi?id=14259&action=edit
config.status
--
You are receiving this mail because:
You are on the CC list for the bug.
^ permalink raw reply [flat|nested] 29+ messages in thread* [Bug build/29454] dl-cache.c:513: undefined reference to `strcpy' with -Og or -O1 (doesn't happen with -O2)
2022-08-07 13:50 [Bug build/29454] New: dl-cache.c:513: undefined reference to `strcpy' with -Og or -O1 (doesn't happen with -O2) Martin.Jansa at gmail dot com
` (6 preceding siblings ...)
2022-08-07 15:12 ` Martin.Jansa at gmail dot com
@ 2022-08-07 15:13 ` Martin.Jansa at gmail dot com
2022-08-07 15:26 ` goldstein.w.n at gmail dot com
` (19 subsequent siblings)
27 siblings, 0 replies; 29+ messages in thread
From: Martin.Jansa at gmail dot com @ 2022-08-07 15:13 UTC (permalink / raw)
To: glibc-bugs
https://sourceware.org/bugzilla/show_bug.cgi?id=29454
--- Comment #7 from Martin Jansa <Martin.Jansa at gmail dot com> ---
I'm using OpenEmbedded cross-compilation, whole log is here:
http://errors.yoctoproject.org/Errors/Details/663898/
The flags are used from config.status (attached) generated in do_configure,
then it runs 'make PARALLELMFLAGS="-j 70 -l 140" SHELL=/bin/bash KSHELL=/bin/sh
"$@"' in the build-x86_64-oe-linux created by do_configure.
I'll try to reproduce it in native build on gentoo (which will be closer to
what you're using).
--
You are receiving this mail because:
You are on the CC list for the bug.
^ permalink raw reply [flat|nested] 29+ messages in thread* [Bug build/29454] dl-cache.c:513: undefined reference to `strcpy' with -Og or -O1 (doesn't happen with -O2)
2022-08-07 13:50 [Bug build/29454] New: dl-cache.c:513: undefined reference to `strcpy' with -Og or -O1 (doesn't happen with -O2) Martin.Jansa at gmail dot com
` (7 preceding siblings ...)
2022-08-07 15:13 ` Martin.Jansa at gmail dot com
@ 2022-08-07 15:26 ` goldstein.w.n at gmail dot com
2022-08-07 15:28 ` goldstein.w.n at gmail dot com
` (18 subsequent siblings)
27 siblings, 0 replies; 29+ messages in thread
From: goldstein.w.n at gmail dot com @ 2022-08-07 15:26 UTC (permalink / raw)
To: glibc-bugs
https://sourceware.org/bugzilla/show_bug.cgi?id=29454
--- Comment #8 from Noah Goldstein <goldstein.w.n at gmail dot com> ---
(In reply to Martin Jansa from comment #6)
> Created attachment 14259 [details]
> config.status
Thanks.
H.J do you know why rtld-strcpy-sse2 is being built at all?
I was under the impression it would only be built with an rtld-... hook.
strcpy-sse2.S should not be built for rtld/non-multiarch directly, it should go
through
sysdeps/x86_64/strcpy.S
--
You are receiving this mail because:
You are on the CC list for the bug.
^ permalink raw reply [flat|nested] 29+ messages in thread* [Bug build/29454] dl-cache.c:513: undefined reference to `strcpy' with -Og or -O1 (doesn't happen with -O2)
2022-08-07 13:50 [Bug build/29454] New: dl-cache.c:513: undefined reference to `strcpy' with -Og or -O1 (doesn't happen with -O2) Martin.Jansa at gmail dot com
` (8 preceding siblings ...)
2022-08-07 15:26 ` goldstein.w.n at gmail dot com
@ 2022-08-07 15:28 ` goldstein.w.n at gmail dot com
2022-08-07 15:28 ` goldstein.w.n at gmail dot com
` (17 subsequent siblings)
27 siblings, 0 replies; 29+ messages in thread
From: goldstein.w.n at gmail dot com @ 2022-08-07 15:28 UTC (permalink / raw)
To: glibc-bugs
https://sourceware.org/bugzilla/show_bug.cgi?id=29454
--- Comment #9 from Noah Goldstein <goldstein.w.n at gmail dot com> ---
(In reply to Martin Jansa from comment #7)
> I'm using OpenEmbedded cross-compilation, whole log is here:
> http://errors.yoctoproject.org/Errors/Details/663898/
>
> The flags are used from config.status (attached) generated in do_configure,
> then it runs 'make PARALLELMFLAGS="-j 70 -l 140" SHELL=/bin/bash
> KSHELL=/bin/sh "$@"' in the build-x86_64-oe-linux created by do_configure.
>
> I'll try to reproduce it in native build on gentoo (which will be closer to
> what you're using).
Thanks.
I see whats causing this in the code but am not sure why it's occurring. H.J
may have an idea.
--
You are receiving this mail because:
You are on the CC list for the bug.
^ permalink raw reply [flat|nested] 29+ messages in thread* [Bug build/29454] dl-cache.c:513: undefined reference to `strcpy' with -Og or -O1 (doesn't happen with -O2)
2022-08-07 13:50 [Bug build/29454] New: dl-cache.c:513: undefined reference to `strcpy' with -Og or -O1 (doesn't happen with -O2) Martin.Jansa at gmail dot com
` (9 preceding siblings ...)
2022-08-07 15:28 ` goldstein.w.n at gmail dot com
@ 2022-08-07 15:28 ` goldstein.w.n at gmail dot com
2022-08-07 15:38 ` Martin.Jansa at gmail dot com
` (16 subsequent siblings)
27 siblings, 0 replies; 29+ messages in thread
From: goldstein.w.n at gmail dot com @ 2022-08-07 15:28 UTC (permalink / raw)
To: glibc-bugs
https://sourceware.org/bugzilla/show_bug.cgi?id=29454
Noah Goldstein <goldstein.w.n at gmail dot com> changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |hjl.tools at gmail dot com
--
You are receiving this mail because:
You are on the CC list for the bug.
^ permalink raw reply [flat|nested] 29+ messages in thread* [Bug build/29454] dl-cache.c:513: undefined reference to `strcpy' with -Og or -O1 (doesn't happen with -O2)
2022-08-07 13:50 [Bug build/29454] New: dl-cache.c:513: undefined reference to `strcpy' with -Og or -O1 (doesn't happen with -O2) Martin.Jansa at gmail dot com
` (10 preceding siblings ...)
2022-08-07 15:28 ` goldstein.w.n at gmail dot com
@ 2022-08-07 15:38 ` Martin.Jansa at gmail dot com
2022-08-07 15:38 ` Martin.Jansa at gmail dot com
` (15 subsequent siblings)
27 siblings, 0 replies; 29+ messages in thread
From: Martin.Jansa at gmail dot com @ 2022-08-07 15:38 UTC (permalink / raw)
To: glibc-bugs
https://sourceware.org/bugzilla/show_bug.cgi?id=29454
--- Comment #10 from Martin Jansa <Martin.Jansa at gmail dot com> ---
I was able to reproduce it in native build after exporting CFLAGS="-Og"
my build.sh attached.
--
You are receiving this mail because:
You are on the CC list for the bug.
^ permalink raw reply [flat|nested] 29+ messages in thread* [Bug build/29454] dl-cache.c:513: undefined reference to `strcpy' with -Og or -O1 (doesn't happen with -O2)
2022-08-07 13:50 [Bug build/29454] New: dl-cache.c:513: undefined reference to `strcpy' with -Og or -O1 (doesn't happen with -O2) Martin.Jansa at gmail dot com
` (11 preceding siblings ...)
2022-08-07 15:38 ` Martin.Jansa at gmail dot com
@ 2022-08-07 15:38 ` Martin.Jansa at gmail dot com
2022-08-07 15:39 ` Martin.Jansa at gmail dot com
` (14 subsequent siblings)
27 siblings, 0 replies; 29+ messages in thread
From: Martin.Jansa at gmail dot com @ 2022-08-07 15:38 UTC (permalink / raw)
To: glibc-bugs
https://sourceware.org/bugzilla/show_bug.cgi?id=29454
--- Comment #11 from Martin Jansa <Martin.Jansa at gmail dot com> ---
Created attachment 14260
--> https://sourceware.org/bugzilla/attachment.cgi?id=14260&action=edit
build.sh
--
You are receiving this mail because:
You are on the CC list for the bug.
^ permalink raw reply [flat|nested] 29+ messages in thread* [Bug build/29454] dl-cache.c:513: undefined reference to `strcpy' with -Og or -O1 (doesn't happen with -O2)
2022-08-07 13:50 [Bug build/29454] New: dl-cache.c:513: undefined reference to `strcpy' with -Og or -O1 (doesn't happen with -O2) Martin.Jansa at gmail dot com
` (12 preceding siblings ...)
2022-08-07 15:38 ` Martin.Jansa at gmail dot com
@ 2022-08-07 15:39 ` Martin.Jansa at gmail dot com
2022-08-07 15:39 ` Martin.Jansa at gmail dot com
` (13 subsequent siblings)
27 siblings, 0 replies; 29+ messages in thread
From: Martin.Jansa at gmail dot com @ 2022-08-07 15:39 UTC (permalink / raw)
To: glibc-bugs
https://sourceware.org/bugzilla/show_bug.cgi?id=29454
Martin Jansa <Martin.Jansa at gmail dot com> changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #14260|application/x-shellscript |text/plain
mime type| |
--
You are receiving this mail because:
You are on the CC list for the bug.
^ permalink raw reply [flat|nested] 29+ messages in thread* [Bug build/29454] dl-cache.c:513: undefined reference to `strcpy' with -Og or -O1 (doesn't happen with -O2)
2022-08-07 13:50 [Bug build/29454] New: dl-cache.c:513: undefined reference to `strcpy' with -Og or -O1 (doesn't happen with -O2) Martin.Jansa at gmail dot com
` (13 preceding siblings ...)
2022-08-07 15:39 ` Martin.Jansa at gmail dot com
@ 2022-08-07 15:39 ` Martin.Jansa at gmail dot com
2022-08-07 15:56 ` goldstein.w.n at gmail dot com
` (12 subsequent siblings)
27 siblings, 0 replies; 29+ messages in thread
From: Martin.Jansa at gmail dot com @ 2022-08-07 15:39 UTC (permalink / raw)
To: glibc-bugs
https://sourceware.org/bugzilla/show_bug.cgi?id=29454
Martin Jansa <Martin.Jansa at gmail dot com> changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #14259|application/x-shellscript |text/plain
mime type| |
--
You are receiving this mail because:
You are on the CC list for the bug.
^ permalink raw reply [flat|nested] 29+ messages in thread* [Bug build/29454] dl-cache.c:513: undefined reference to `strcpy' with -Og or -O1 (doesn't happen with -O2)
2022-08-07 13:50 [Bug build/29454] New: dl-cache.c:513: undefined reference to `strcpy' with -Og or -O1 (doesn't happen with -O2) Martin.Jansa at gmail dot com
` (14 preceding siblings ...)
2022-08-07 15:39 ` Martin.Jansa at gmail dot com
@ 2022-08-07 15:56 ` goldstein.w.n at gmail dot com
2022-08-07 15:56 ` goldstein.w.n at gmail dot com
` (11 subsequent siblings)
27 siblings, 0 replies; 29+ messages in thread
From: goldstein.w.n at gmail dot com @ 2022-08-07 15:56 UTC (permalink / raw)
To: glibc-bugs
https://sourceware.org/bugzilla/show_bug.cgi?id=29454
--- Comment #12 from Noah Goldstein <goldstein.w.n at gmail dot com> ---
(In reply to Martin Jansa from comment #11)
> Created attachment 14260 [details]
> build.sh
Thanks was able to reproduce with that.
Attached is another patch that I think fixes it. Now fail at
```
/usr/bin/ld:
/home/noah/programs/opensource/glibc-dev/build/glibc/libc.a(libc-tls.o): in
function `__libc_setup_tls':
libc-tls.c:(.text+0x2f2): undefined reference to `_startup_fatal_not_constant'
collect2: error: ld returned 1 exit status
```
which I think is a different issue.
H.J I will post this patch (and the other one for the ifdef tomorrow morning).
Do you know why this was necessary for the non-optimized build?
--
You are receiving this mail because:
You are on the CC list for the bug.
^ permalink raw reply [flat|nested] 29+ messages in thread* [Bug build/29454] dl-cache.c:513: undefined reference to `strcpy' with -Og or -O1 (doesn't happen with -O2)
2022-08-07 13:50 [Bug build/29454] New: dl-cache.c:513: undefined reference to `strcpy' with -Og or -O1 (doesn't happen with -O2) Martin.Jansa at gmail dot com
` (15 preceding siblings ...)
2022-08-07 15:56 ` goldstein.w.n at gmail dot com
@ 2022-08-07 15:56 ` goldstein.w.n at gmail dot com
2022-08-07 16:03 ` Martin.Jansa at gmail dot com
` (10 subsequent siblings)
27 siblings, 0 replies; 29+ messages in thread
From: goldstein.w.n at gmail dot com @ 2022-08-07 15:56 UTC (permalink / raw)
To: glibc-bugs
https://sourceware.org/bugzilla/show_bug.cgi?id=29454
--- Comment #13 from Noah Goldstein <goldstein.w.n at gmail dot com> ---
Created attachment 14261
--> https://sourceware.org/bugzilla/attachment.cgi?id=14261&action=edit
RTLD strcpy hook
--
You are receiving this mail because:
You are on the CC list for the bug.
^ permalink raw reply [flat|nested] 29+ messages in thread* [Bug build/29454] dl-cache.c:513: undefined reference to `strcpy' with -Og or -O1 (doesn't happen with -O2)
2022-08-07 13:50 [Bug build/29454] New: dl-cache.c:513: undefined reference to `strcpy' with -Og or -O1 (doesn't happen with -O2) Martin.Jansa at gmail dot com
` (16 preceding siblings ...)
2022-08-07 15:56 ` goldstein.w.n at gmail dot com
@ 2022-08-07 16:03 ` Martin.Jansa at gmail dot com
2022-08-07 16:07 ` goldstein.w.n at gmail dot com
` (9 subsequent siblings)
27 siblings, 0 replies; 29+ messages in thread
From: Martin.Jansa at gmail dot com @ 2022-08-07 16:03 UTC (permalink / raw)
To: glibc-bugs
https://sourceware.org/bugzilla/show_bug.cgi?id=29454
--- Comment #14 from Martin Jansa <Martin.Jansa at gmail dot com> ---
> Attached is another patch that I think fixes it.
Yes, it fixes it for me as well in native as well as OpenEmbedded build, thanks
a lot for quick update!
> undefined reference to `_startup_fatal_not_constant'
> which I think is a different issue.
Yes, I'm seeing this one as well, that's bug 29249
--
You are receiving this mail because:
You are on the CC list for the bug.
^ permalink raw reply [flat|nested] 29+ messages in thread* [Bug build/29454] dl-cache.c:513: undefined reference to `strcpy' with -Og or -O1 (doesn't happen with -O2)
2022-08-07 13:50 [Bug build/29454] New: dl-cache.c:513: undefined reference to `strcpy' with -Og or -O1 (doesn't happen with -O2) Martin.Jansa at gmail dot com
` (17 preceding siblings ...)
2022-08-07 16:03 ` Martin.Jansa at gmail dot com
@ 2022-08-07 16:07 ` goldstein.w.n at gmail dot com
2022-08-07 19:39 ` hjl.tools at gmail dot com
` (8 subsequent siblings)
27 siblings, 0 replies; 29+ messages in thread
From: goldstein.w.n at gmail dot com @ 2022-08-07 16:07 UTC (permalink / raw)
To: glibc-bugs
https://sourceware.org/bugzilla/show_bug.cgi?id=29454
--- Comment #15 from Noah Goldstein <goldstein.w.n at gmail dot com> ---
(In reply to Martin Jansa from comment #14)
> > Attached is another patch that I think fixes it.
>
> Yes, it fixes it for me as well in native as well as OpenEmbedded build,
> thanks a lot for quick update!
Great. Will keep this open until changes reach master / are potentially
backported.
Thanks for the report.
>
> > undefined reference to `_startup_fatal_not_constant'
> > which I think is a different issue.
>
> Yes, I'm seeing this one as well, that's bug 29249
--
You are receiving this mail because:
You are on the CC list for the bug.
^ permalink raw reply [flat|nested] 29+ messages in thread* [Bug build/29454] dl-cache.c:513: undefined reference to `strcpy' with -Og or -O1 (doesn't happen with -O2)
2022-08-07 13:50 [Bug build/29454] New: dl-cache.c:513: undefined reference to `strcpy' with -Og or -O1 (doesn't happen with -O2) Martin.Jansa at gmail dot com
` (18 preceding siblings ...)
2022-08-07 16:07 ` goldstein.w.n at gmail dot com
@ 2022-08-07 19:39 ` hjl.tools at gmail dot com
2022-08-08 2:52 ` goldstein.w.n at gmail dot com
` (7 subsequent siblings)
27 siblings, 0 replies; 29+ messages in thread
From: hjl.tools at gmail dot com @ 2022-08-07 19:39 UTC (permalink / raw)
To: glibc-bugs
https://sourceware.org/bugzilla/show_bug.cgi?id=29454
--- Comment #16 from H.J. Lu <hjl.tools at gmail dot com> ---
(In reply to Noah Goldstein from comment #12)
> which I think is a different issue.
>
> H.J I will post this patch (and the other one for the ifdef tomorrow
> morning). Do you know why this was necessary for the non-optimized build?
Some parts of glibc must be compiled with optimization. If there is foo.[cS]
under sysdeps/x86_64/multiarch, the one in sysdeps/x86_64 will be ignored.
Does GCC inline strcpy with -O2 in dl-cache.c?
--
You are receiving this mail because:
You are on the CC list for the bug.
^ permalink raw reply [flat|nested] 29+ messages in thread* [Bug build/29454] dl-cache.c:513: undefined reference to `strcpy' with -Og or -O1 (doesn't happen with -O2)
2022-08-07 13:50 [Bug build/29454] New: dl-cache.c:513: undefined reference to `strcpy' with -Og or -O1 (doesn't happen with -O2) Martin.Jansa at gmail dot com
` (19 preceding siblings ...)
2022-08-07 19:39 ` hjl.tools at gmail dot com
@ 2022-08-08 2:52 ` goldstein.w.n at gmail dot com
2022-08-08 3:27 ` goldstein.w.n at gmail dot com
` (6 subsequent siblings)
27 siblings, 0 replies; 29+ messages in thread
From: goldstein.w.n at gmail dot com @ 2022-08-08 2:52 UTC (permalink / raw)
To: glibc-bugs
https://sourceware.org/bugzilla/show_bug.cgi?id=29454
--- Comment #17 from Noah Goldstein <goldstein.w.n at gmail dot com> ---
(In reply to H.J. Lu from comment #16)
> (In reply to Noah Goldstein from comment #12)
>
> > which I think is a different issue.
> >
> > H.J I will post this patch (and the other one for the ifdef tomorrow
> > morning). Do you know why this was necessary for the non-optimized build?
>
> Some parts of glibc must be compiled with optimization. If there is foo.[cS]
> under sysdeps/x86_64/multiarch, the one in sysdeps/x86_64 will be ignored.
> Does GCC inline strcpy with -O2 in dl-cache.c?
Yeah the usage is:
```
char *temp;
temp = alloca (strlen (best) + 1);
strcpy (temp, best);
return __strdup (temp);
```
Which gets converted to `memcpy` (because of already computed strlen) in
strlen_pass::handle_builtin_strcpy.
--
You are receiving this mail because:
You are on the CC list for the bug.
^ permalink raw reply [flat|nested] 29+ messages in thread* [Bug build/29454] dl-cache.c:513: undefined reference to `strcpy' with -Og or -O1 (doesn't happen with -O2)
2022-08-07 13:50 [Bug build/29454] New: dl-cache.c:513: undefined reference to `strcpy' with -Og or -O1 (doesn't happen with -O2) Martin.Jansa at gmail dot com
` (20 preceding siblings ...)
2022-08-08 2:52 ` goldstein.w.n at gmail dot com
@ 2022-08-08 3:27 ` goldstein.w.n at gmail dot com
2022-08-08 10:27 ` yann at droneaud dot fr
` (5 subsequent siblings)
27 siblings, 0 replies; 29+ messages in thread
From: goldstein.w.n at gmail dot com @ 2022-08-08 3:27 UTC (permalink / raw)
To: glibc-bugs
https://sourceware.org/bugzilla/show_bug.cgi?id=29454
--- Comment #18 from Noah Goldstein <goldstein.w.n at gmail dot com> ---
Patch posted. Ended up just replacing the strcpy call with memcpy directly so
we don't need to include strcpy in the rtld build.
--
You are receiving this mail because:
You are on the CC list for the bug.
^ permalink raw reply [flat|nested] 29+ messages in thread* [Bug build/29454] dl-cache.c:513: undefined reference to `strcpy' with -Og or -O1 (doesn't happen with -O2)
2022-08-07 13:50 [Bug build/29454] New: dl-cache.c:513: undefined reference to `strcpy' with -Og or -O1 (doesn't happen with -O2) Martin.Jansa at gmail dot com
` (21 preceding siblings ...)
2022-08-08 3:27 ` goldstein.w.n at gmail dot com
@ 2022-08-08 10:27 ` yann at droneaud dot fr
2022-08-08 19:59 ` sam at gentoo dot org
` (4 subsequent siblings)
27 siblings, 0 replies; 29+ messages in thread
From: yann at droneaud dot fr @ 2022-08-08 10:27 UTC (permalink / raw)
To: glibc-bugs
https://sourceware.org/bugzilla/show_bug.cgi?id=29454
Yann Droneaud <yann at droneaud dot fr> changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |yann at droneaud dot fr
--
You are receiving this mail because:
You are on the CC list for the bug.
^ permalink raw reply [flat|nested] 29+ messages in thread* [Bug build/29454] dl-cache.c:513: undefined reference to `strcpy' with -Og or -O1 (doesn't happen with -O2)
2022-08-07 13:50 [Bug build/29454] New: dl-cache.c:513: undefined reference to `strcpy' with -Og or -O1 (doesn't happen with -O2) Martin.Jansa at gmail dot com
` (22 preceding siblings ...)
2022-08-08 10:27 ` yann at droneaud dot fr
@ 2022-08-08 19:59 ` sam at gentoo dot org
2022-08-09 10:16 ` goldstein.w.n at gmail dot com
` (3 subsequent siblings)
27 siblings, 0 replies; 29+ messages in thread
From: sam at gentoo dot org @ 2022-08-08 19:59 UTC (permalink / raw)
To: glibc-bugs
https://sourceware.org/bugzilla/show_bug.cgi?id=29454
Sam James <sam at gentoo dot org> changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |sam at gentoo dot org
--
You are receiving this mail because:
You are on the CC list for the bug.
^ permalink raw reply [flat|nested] 29+ messages in thread* [Bug build/29454] dl-cache.c:513: undefined reference to `strcpy' with -Og or -O1 (doesn't happen with -O2)
2022-08-07 13:50 [Bug build/29454] New: dl-cache.c:513: undefined reference to `strcpy' with -Og or -O1 (doesn't happen with -O2) Martin.Jansa at gmail dot com
` (23 preceding siblings ...)
2022-08-08 19:59 ` sam at gentoo dot org
@ 2022-08-09 10:16 ` goldstein.w.n at gmail dot com
2022-08-09 14:49 ` hjl.tools at gmail dot com
` (2 subsequent siblings)
27 siblings, 0 replies; 29+ messages in thread
From: goldstein.w.n at gmail dot com @ 2022-08-09 10:16 UTC (permalink / raw)
To: glibc-bugs
https://sourceware.org/bugzilla/show_bug.cgi?id=29454
--- Comment #19 from Noah Goldstein <goldstein.w.n at gmail dot com> ---
(In reply to Noah Goldstein from comment #18)
> Patch posted. Ended up just replacing the strcpy call with memcpy directly
> so we don't need to include strcpy in the rtld build.
Pushed patch:
https://sourceware.org/git/?p=glibc.git;a=commit;h=483cfe1a6a33d6335b1901581b41040d2d412511
H.J should we backport this?
--
You are receiving this mail because:
You are on the CC list for the bug.
^ permalink raw reply [flat|nested] 29+ messages in thread* [Bug build/29454] dl-cache.c:513: undefined reference to `strcpy' with -Og or -O1 (doesn't happen with -O2)
2022-08-07 13:50 [Bug build/29454] New: dl-cache.c:513: undefined reference to `strcpy' with -Og or -O1 (doesn't happen with -O2) Martin.Jansa at gmail dot com
` (24 preceding siblings ...)
2022-08-09 10:16 ` goldstein.w.n at gmail dot com
@ 2022-08-09 14:49 ` hjl.tools at gmail dot com
2022-08-09 14:51 ` Martin.Jansa at gmail dot com
2022-08-11 15:33 ` goldstein.w.n at gmail dot com
27 siblings, 0 replies; 29+ messages in thread
From: hjl.tools at gmail dot com @ 2022-08-09 14:49 UTC (permalink / raw)
To: glibc-bugs
https://sourceware.org/bugzilla/show_bug.cgi?id=29454
--- Comment #20 from H.J. Lu <hjl.tools at gmail dot com> ---
(In reply to Noah Goldstein from comment #19)
> (In reply to Noah Goldstein from comment #18)
> > Patch posted. Ended up just replacing the strcpy call with memcpy directly
> > so we don't need to include strcpy in the rtld build.
>
> Pushed patch:
> https://sourceware.org/git/?p=glibc.git;a=commit;
> h=483cfe1a6a33d6335b1901581b41040d2d412511
>
> H.J should we backport this?
It doesn't look like a regression. Please ask it on the mailing list.
--
You are receiving this mail because:
You are on the CC list for the bug.
^ permalink raw reply [flat|nested] 29+ messages in thread* [Bug build/29454] dl-cache.c:513: undefined reference to `strcpy' with -Og or -O1 (doesn't happen with -O2)
2022-08-07 13:50 [Bug build/29454] New: dl-cache.c:513: undefined reference to `strcpy' with -Og or -O1 (doesn't happen with -O2) Martin.Jansa at gmail dot com
` (25 preceding siblings ...)
2022-08-09 14:49 ` hjl.tools at gmail dot com
@ 2022-08-09 14:51 ` Martin.Jansa at gmail dot com
2022-08-11 15:33 ` goldstein.w.n at gmail dot com
27 siblings, 0 replies; 29+ messages in thread
From: Martin.Jansa at gmail dot com @ 2022-08-09 14:51 UTC (permalink / raw)
To: glibc-bugs
https://sourceware.org/bugzilla/show_bug.cgi?id=29454
--- Comment #21 from Martin Jansa <Martin.Jansa at gmail dot com> ---
Please backport it, this part was building with -Og in 2.35 and with 2.36 it
doesn't, so I would stay it's an regression, right?
--
You are receiving this mail because:
You are on the CC list for the bug.
^ permalink raw reply [flat|nested] 29+ messages in thread* [Bug build/29454] dl-cache.c:513: undefined reference to `strcpy' with -Og or -O1 (doesn't happen with -O2)
2022-08-07 13:50 [Bug build/29454] New: dl-cache.c:513: undefined reference to `strcpy' with -Og or -O1 (doesn't happen with -O2) Martin.Jansa at gmail dot com
` (26 preceding siblings ...)
2022-08-09 14:51 ` Martin.Jansa at gmail dot com
@ 2022-08-11 15:33 ` goldstein.w.n at gmail dot com
27 siblings, 0 replies; 29+ messages in thread
From: goldstein.w.n at gmail dot com @ 2022-08-11 15:33 UTC (permalink / raw)
To: glibc-bugs
https://sourceware.org/bugzilla/show_bug.cgi?id=29454
--- Comment #22 from Noah Goldstein <goldstein.w.n at gmail dot com> ---
(In reply to Martin Jansa from comment #21)
> Please backport it, this part was building with -Og in 2.35 and with 2.36 it
> doesn't, so I would stay it's an regression, right?
backported:
https://sourceware.org/git/?p=glibc.git;a=commit;h=302bc33bc53c787da6e74162a7092e9c0fb964a8
--
You are receiving this mail because:
You are on the CC list for the bug.
^ permalink raw reply [flat|nested] 29+ messages in thread