public inbox for glibc-bugs@sourceware.org
help / color / mirror / Atom feed
From: "siddhesh at sourceware dot org" <sourceware-bugzilla@sourceware.org>
To: glibc-bugs@sourceware.org
Subject: [Bug build/29564] Incorrect way to change MAKEFLAGS in Makerules
Date: Tue, 13 Sep 2022 17:59:48 +0000 [thread overview]
Message-ID: <bug-29564-131-78Y9Xg3sft@http.sourceware.org/bugzilla/> (raw)
In-Reply-To: <bug-29564-131@http.sourceware.org/bugzilla/>
https://sourceware.org/bugzilla/show_bug.cgi?id=29564
Siddhesh Poyarekar <siddhesh at sourceware dot org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Target Milestone|--- |2.37
Resolution|--- |FIXED
Status|NEW |RESOLVED
--- Comment #3 from Siddhesh Poyarekar <siddhesh at sourceware dot org> ---
Fixed.
https://sourceware.org/git/?p=glibc.git;a=commit;h=2d7ed98add14f75041499ac189696c9bd3d757fe
author Sergei Trofimovich <slyich@gmail.com>
Tue, 13 Sep 2022 17:39:13 +0000 (13:39 -0400)
committer Siddhesh Poyarekar <siddhesh@sourceware.org>
Tue, 13 Sep 2022 17:45:32 +0000 (13:45 -0400)
commit 2d7ed98add14f75041499ac189696c9bd3d757fe
tree 2f9d6695d288f31666f7aaad5c52add48b8a6470 tree
parent a30e960328fc60e066967d1224ecd5b6e173cda3 commit | diff
Makerules: fix MAKEFLAGS assignment for upcoming make-4.4 [BZ# 29564]
make-4.4 will add long flags to MAKEFLAGS variable:
* WARNING: Backward-incompatibility!
Previously only simple (one-letter) options were added to the MAKEFLAGS
variable that was visible while parsing makefiles. Now, all options
are available in MAKEFLAGS.
This causes locale builds to fail when long options are used:
$ make --shuffle
...
make -C localedata install-locales
make: invalid shuffle mode: '1662724426r'
The change fixes it by passing eash option via whitespace and dashes.
That way option is appended to both single-word form and whitespace
separated form.
While at it fixed --silent mode detection in $(MAKEFLAGS) by filtering
out --long-options. Otherwise options like --shuffle flag enable silent
mode unintentionally. $(silent-make) variable consolidates the checks.
Resolves: BZ# 29564
CC: Paul Smith <psmith@gnu.org>
CC: Siddhesh Poyarekar <siddhesh@gotplt.org>
Signed-off-by: Sergei Trofimovich <slyich@gmail.com>
Reviewed-by: Siddhesh Poyarekar <siddhesh@sourceware.org>
--
You are receiving this mail because:
You are on the CC list for the bug.
next prev parent reply other threads:[~2022-09-13 17:59 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-11 17:18 [Bug build/29564] New: " psmith at gnu dot org
2022-09-11 19:04 ` [Bug build/29564] " toralf.foerster at gmx dot de
2022-09-11 22:15 ` sam at gentoo dot org
2022-09-12 20:35 ` slyich at gmail dot com
2022-09-12 20:38 ` siddhesh at sourceware dot org
2022-09-13 17:59 ` siddhesh at sourceware dot org [this message]
2024-02-07 22:10 ` sam at gentoo dot org
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=bug-29564-131-78Y9Xg3sft@http.sourceware.org/bugzilla/ \
--to=sourceware-bugzilla@sourceware.org \
--cc=glibc-bugs@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).