public inbox for glibc-bugs@sourceware.org help / color / mirror / Atom feed
From: "psmith at gnu dot org" <sourceware-bugzilla@sourceware.org> To: glibc-bugs@sourceware.org Subject: [Bug build/29564] New: Incorrect way to change MAKEFLAGS in Makerules Date: Sun, 11 Sep 2022 17:18:30 +0000 [thread overview] Message-ID: <bug-29564-131@http.sourceware.org/bugzilla/> (raw) https://sourceware.org/bugzilla/show_bug.cgi?id=29564 Bug ID: 29564 Summary: Incorrect way to change MAKEFLAGS in Makerules Product: glibc Version: unspecified Status: NEW Severity: normal Priority: P2 Component: build Assignee: unassigned at sourceware dot org Reporter: psmith at gnu dot org CC: carlos at redhat dot com Target Milestone: --- The glibc Makerules file contains this: # Don't define any builtin rules. MAKEFLAGS := $(MAKEFLAGS)r This is not a valid way to modify the MAKEFLAGS variable. GNU make always ensures that all options which have single-letter forms are used as the first argument, however there are options to GNU make which do NOT have single-letter forms and those are added after the single-letter forms in MAKEFLAGS. If you use the above structure, the "r" is just appended to the end of whatever the last option happens to be, which will result in an error if the person invoking make provided a long option without a single-letter form. This should be: MAKEFLAGS := $(MAKEFLAGS) -r or probably even better: MAKEFLAGS += -r -- You are receiving this mail because: You are on the CC list for the bug.
next reply other threads:[~2022-09-11 17:18 UTC|newest] Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top 2022-09-11 17:18 psmith at gnu dot org [this message] 2022-09-11 19:04 ` [Bug build/29564] " toralf.foerster at gmx dot de 2022-09-11 22:15 ` sam at gentoo dot org 2022-09-12 20:35 ` slyich at gmail dot com 2022-09-12 20:38 ` siddhesh at sourceware dot org 2022-09-13 17:59 ` siddhesh at sourceware dot org 2024-02-07 22:10 ` sam at gentoo dot org
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=bug-29564-131@http.sourceware.org/bugzilla/ \ --to=sourceware-bugzilla@sourceware.org \ --cc=glibc-bugs@sourceware.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).