public inbox for glibc-bugs@sourceware.org
help / color / mirror / Atom feed
From: "adhemerval.zanella at linaro dot org" <sourceware-bugzilla@sourceware.org>
To: glibc-bugs@sourceware.org
Subject: [Bug math/30988] fesetexcept raises floating-point exception traps on ppc, ppc64, ppc64le
Date: Mon, 23 Oct 2023 14:11:40 +0000	[thread overview]
Message-ID: <bug-30988-131-p31dqi90Sd@http.sourceware.org/bugzilla/> (raw)
In-Reply-To: <bug-30988-131@http.sourceware.org/bugzilla/>

https://sourceware.org/bugzilla/show_bug.cgi?id=30988

Adhemerval Zanella <adhemerval.zanella at linaro dot org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |adhemerval.zanella at linaro dot o
                   |                            |rg

--- Comment #2 from Adhemerval Zanella <adhemerval.zanella at linaro dot org> ---
Indeed, this seems to be an unexpected side-effect of how we implement the GNU
extension feenableexcept and returning an error seems the best option indeed.

Maybe something like:

diff --git a/sysdeps/powerpc/fpu/fesetexcept.c
b/sysdeps/powerpc/fpu/fesetexcept.c
index 609a148a95..e5396daf44 100644
--- a/sysdeps/powerpc/fpu/fesetexcept.c
+++ b/sysdeps/powerpc/fpu/fesetexcept.c
@@ -29,6 +29,10 @@ fesetexcept (int excepts)
         /* Turn FE_INVALID into FE_INVALID_SOFTWARE.  */
         | (excepts >> ((31 - FPSCR_VX) - (31 - FPSCR_VXSOFT))
            & FE_INVALID_SOFTWARE));
+
+  if (u.l & FPSCR_ENABLES_MASK)
+    return -1;
+
   if (n.l != u.l)
     {
       fesetenv_register (n.fenv);

-- 
You are receiving this mail because:
You are on the CC list for the bug.

  parent reply	other threads:[~2023-10-23 14:11 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-10-22 22:31 [Bug math/30988] New: " bruno at clisp dot org
2023-10-22 22:35 ` [Bug math/30988] " bruno at clisp dot org
2023-10-23 14:11 ` adhemerval.zanella at linaro dot org [this message]
2023-10-23 14:28 ` bruno at clisp dot org
2023-10-23 14:51 ` adhemerval.zanella at linaro dot org
2023-10-23 15:05 ` bruno at clisp dot org
2023-12-19 18:36 ` adhemerval.zanella at linaro dot org

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=bug-30988-131-p31dqi90Sd@http.sourceware.org/bugzilla/ \
    --to=sourceware-bugzilla@sourceware.org \
    --cc=glibc-bugs@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).