public inbox for glibc-bugs@sourceware.org
help / color / mirror / Atom feed
* [Bug dynamic-link/31187] New: Some CET tests fail with GCC 14
@ 2023-12-22 16:27 hjl.tools at gmail dot com
  2024-01-01 23:56 ` [Bug dynamic-link/31187] " cvs-commit at gcc dot gnu.org
  2024-01-01 23:58 ` hjl.tools at gmail dot com
  0 siblings, 2 replies; 3+ messages in thread
From: hjl.tools at gmail dot com @ 2023-12-22 16:27 UTC (permalink / raw)
  To: glibc-bugs

https://sourceware.org/bugzilla/show_bug.cgi?id=31187

            Bug ID: 31187
           Summary: Some CET tests fail with GCC 14
           Product: glibc
           Version: 2.39
            Status: NEW
          Severity: normal
          Priority: P2
         Component: dynamic-link
          Assignee: unassigned at sourceware dot org
          Reporter: hjl.tools at gmail dot com
  Target Milestone: ---
            Target: x86_64

Some CET tests failed when compiled with GCC 14:

FAIL: elf/tst-cet-legacy-4
FAIL: elf/tst-cet-legacy-5a
FAIL: elf/tst-cet-legacy-6a

which are caused by

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=113039

These tests use -fcf-protection -fcf-protection=branch and
assume -fcf-protection=branch will override -fcf-protection.
But

https://gcc.gnu.org/git/gitweb.cgi?p=gcc.git;h=1c6231c05bdcca

changed the -fcf-protection behavior such that

-fcf-protection -fcf-protection=branch

is the same as

-fcf-protection

The workaround is to use

-fcf-protection -fcf-protection=none -fcf-protection=branch

-- 
You are receiving this mail because:
You are on the CC list for the bug.

^ permalink raw reply	[flat|nested] 3+ messages in thread

* [Bug dynamic-link/31187] Some CET tests fail with GCC 14
  2023-12-22 16:27 [Bug dynamic-link/31187] New: Some CET tests fail with GCC 14 hjl.tools at gmail dot com
@ 2024-01-01 23:56 ` cvs-commit at gcc dot gnu.org
  2024-01-01 23:58 ` hjl.tools at gmail dot com
  1 sibling, 0 replies; 3+ messages in thread
From: cvs-commit at gcc dot gnu.org @ 2024-01-01 23:56 UTC (permalink / raw)
  To: glibc-bugs

https://sourceware.org/bugzilla/show_bug.cgi?id=31187

--- Comment #1 from Sourceware Commits <cvs-commit at gcc dot gnu.org> ---
The master branch has been updated by H.J. Lu <hjl@sourceware.org>:

https://sourceware.org/git/gitweb.cgi?p=glibc.git;h=b5dcccfb12385ee492eb074f6beb9ead56b5e5fd

commit b5dcccfb12385ee492eb074f6beb9ead56b5e5fd
Author: H.J. Lu <hjl.tools@gmail.com>
Date:   Mon Jan 1 07:55:18 2024 -0800

    x86/cet: Add -fcf-protection=none before -fcf-protection=branch

    When shadow stack is enabled, some CET tests failed when compiled with
    GCC 14:

    FAIL: elf/tst-cet-legacy-4
    FAIL: elf/tst-cet-legacy-5a
    FAIL: elf/tst-cet-legacy-6a

    which are caused by

    https://gcc.gnu.org/bugzilla/show_bug.cgi?id=113039

    These tests use -fcf-protection -fcf-protection=branch and assume that
    -fcf-protection=branch will override -fcf-protection.  But this GCC 14
    commit:

    https://gcc.gnu.org/git/gitweb.cgi?p=gcc.git;h=1c6231c05bdcca

    changed the -fcf-protection behavior such that

    -fcf-protection -fcf-protection=branch

    is treated the same as

    -fcf-protection

    Use

    -fcf-protection -fcf-protection=none -fcf-protection=branch

    as the workaround.  This fixes BZ #31187.

    Tested with GCC 13 and GCC 14 on Intel Tiger Lake.
    Reviewed-by: Noah Goldstein <goldstein.w.n@gmail.com>

-- 
You are receiving this mail because:
You are on the CC list for the bug.

^ permalink raw reply	[flat|nested] 3+ messages in thread

* [Bug dynamic-link/31187] Some CET tests fail with GCC 14
  2023-12-22 16:27 [Bug dynamic-link/31187] New: Some CET tests fail with GCC 14 hjl.tools at gmail dot com
  2024-01-01 23:56 ` [Bug dynamic-link/31187] " cvs-commit at gcc dot gnu.org
@ 2024-01-01 23:58 ` hjl.tools at gmail dot com
  1 sibling, 0 replies; 3+ messages in thread
From: hjl.tools at gmail dot com @ 2024-01-01 23:58 UTC (permalink / raw)
  To: glibc-bugs

https://sourceware.org/bugzilla/show_bug.cgi?id=31187

H.J. Lu <hjl.tools at gmail dot com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Target Milestone|---                         |2.39
             Status|NEW                         |RESOLVED
         Resolution|---                         |FIXED

--- Comment #2 from H.J. Lu <hjl.tools at gmail dot com> ---
Fixed for 2.39.

-- 
You are receiving this mail because:
You are on the CC list for the bug.

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2024-01-01 23:58 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-12-22 16:27 [Bug dynamic-link/31187] New: Some CET tests fail with GCC 14 hjl.tools at gmail dot com
2024-01-01 23:56 ` [Bug dynamic-link/31187] " cvs-commit at gcc dot gnu.org
2024-01-01 23:58 ` hjl.tools at gmail dot com

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).