public inbox for glibc-cvs@sourceware.org
help / color / mirror / Atom feed
From: Florian Weimer <fw@sourceware.org>
To: glibc-cvs@sourceware.org
Subject: [glibc] resolv: Remove unnecessary res_isourserver_p call from send_dg
Date: Thu, 15 Jul 2021 08:10:30 +0000 (GMT)	[thread overview]
Message-ID: <20210715081030.609EE3AA9422@sourceware.org> (raw)

https://sourceware.org/git/gitweb.cgi?p=glibc.git;h=ee3639e0fe61a3692adf660e04f9e6d56475ff52

commit ee3639e0fe61a3692adf660e04f9e6d56475ff52
Author: Florian Weimer <fweimer@redhat.com>
Date:   Thu Jul 15 08:28:51 2021 +0200

    resolv: Remove unnecessary res_isourserver_p call from send_dg
    
    As the comment indicates, the check is unnecessary due to the way the
    UDP socket is set up.
    
    Reviewed-by: Carlos O'Donell <carlos@redhat.com>
    Tested-by: Carlos O'Donell <carlos@redhat.com>

Diff:
---
 resolv/res_send.c | 6 ------
 1 file changed, 6 deletions(-)

diff --git a/resolv/res_send.c b/resolv/res_send.c
index 9a3bc5804a..a70f3dec05 100644
--- a/resolv/res_send.c
+++ b/resolv/res_send.c
@@ -1343,12 +1343,6 @@ send_dg(res_state statp,
 			return close_and_return_error (statp, resplen2);
 		}
 
-		/* Paranoia check.  Due to the connected UDP socket,
-		   the kernel has already filtered invalid addresses
-		   for us.  */
-		if (!res_ourserver_p(statp, &from))
-		  goto wait;
-
 		/* Check for the correct header layout and a matching
 		   question.  */
 		int matching_query = 0; /* Default to no matching query.  */


                 reply	other threads:[~2021-07-15  8:10 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210715081030.609EE3AA9422@sourceware.org \
    --to=fw@sourceware.org \
    --cc=glibc-cvs@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).