public inbox for glibc-cvs@sourceware.org
help / color / mirror / Atom feed
* [glibc] resolv: Remove unnecessary res_isourserver_p call from send_dg
@ 2021-07-15  8:10 Florian Weimer
  0 siblings, 0 replies; only message in thread
From: Florian Weimer @ 2021-07-15  8:10 UTC (permalink / raw)
  To: glibc-cvs

https://sourceware.org/git/gitweb.cgi?p=glibc.git;h=ee3639e0fe61a3692adf660e04f9e6d56475ff52

commit ee3639e0fe61a3692adf660e04f9e6d56475ff52
Author: Florian Weimer <fweimer@redhat.com>
Date:   Thu Jul 15 08:28:51 2021 +0200

    resolv: Remove unnecessary res_isourserver_p call from send_dg
    
    As the comment indicates, the check is unnecessary due to the way the
    UDP socket is set up.
    
    Reviewed-by: Carlos O'Donell <carlos@redhat.com>
    Tested-by: Carlos O'Donell <carlos@redhat.com>

Diff:
---
 resolv/res_send.c | 6 ------
 1 file changed, 6 deletions(-)

diff --git a/resolv/res_send.c b/resolv/res_send.c
index 9a3bc5804a..a70f3dec05 100644
--- a/resolv/res_send.c
+++ b/resolv/res_send.c
@@ -1343,12 +1343,6 @@ send_dg(res_state statp,
 			return close_and_return_error (statp, resplen2);
 		}
 
-		/* Paranoia check.  Due to the connected UDP socket,
-		   the kernel has already filtered invalid addresses
-		   for us.  */
-		if (!res_ourserver_p(statp, &from))
-		  goto wait;
-
 		/* Check for the correct header layout and a matching
 		   question.  */
 		int matching_query = 0; /* Default to no matching query.  */


^ permalink raw reply	[flat|nested] only message in thread

only message in thread, other threads:[~2021-07-15  8:10 UTC | newest]

Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-07-15  8:10 [glibc] resolv: Remove unnecessary res_isourserver_p call from send_dg Florian Weimer

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).