public inbox for glibc-cvs@sourceware.org
help / color / mirror / Atom feed
* [glibc/arm/morello/main] TODO(sprof): cheri: disable profiling shared libraries
@ 2022-08-05 19:38 Szabolcs Nagy
  0 siblings, 0 replies; 4+ messages in thread
From: Szabolcs Nagy @ 2022-08-05 19:38 UTC (permalink / raw)
  To: glibc-cvs

https://sourceware.org/git/gitweb.cgi?p=glibc.git;h=5ef98a99001f411448fef8cdf87a9f1d40b3db32

commit 5ef98a99001f411448fef8cdf87a9f1d40b3db32
Author: Szabolcs Nagy <szabolcs.nagy@arm.com>
Date:   Thu May 12 09:05:30 2022 +0100

    TODO(sprof): cheri: disable profiling shared libraries
    
    This is needed now to avoid referencing abort in ld.so.
    
    TODO: Fixing shared library profiling for capabilities requires
    type fixes so capabilities are not stored into shared memory
    (maybe purecap layout can match the lp64 one and then no file format
    and external tooling change is required.)
    TODO: Proper fix also depends on _dl_runtime_profile plt entry

Diff:
---
 elf/dl-profile.c | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/elf/dl-profile.c b/elf/dl-profile.c
index ec57e3a965..2cb66e83c6 100644
--- a/elf/dl-profile.c
+++ b/elf/dl-profile.c
@@ -182,6 +182,9 @@ static unsigned int log_hashfraction;
 void
 _dl_start_profile (void)
 {
+#ifdef __CHERI_PURE_CAPABILITY__
+  __libc_fatal ("Profiling is not supported on capability architectures.");
+#else
   char *filename;
   int fd;
   struct __stat64_t64 st;
@@ -482,6 +485,7 @@ _dl_start_profile (void)
 
   /* Turn on profiling.  */
   running = 1;
+#endif
 }


^ permalink raw reply	[flat|nested] 4+ messages in thread
* [glibc/arm/morello/main] TODO(sprof): cheri: disable profiling shared libraries
@ 2022-11-23 14:48 Szabolcs Nagy
  0 siblings, 0 replies; 4+ messages in thread
From: Szabolcs Nagy @ 2022-11-23 14:48 UTC (permalink / raw)
  To: glibc-cvs

https://sourceware.org/git/gitweb.cgi?p=glibc.git;h=82f650eec80df339f1a8144039623a575f756161

commit 82f650eec80df339f1a8144039623a575f756161
Author: Szabolcs Nagy <szabolcs.nagy@arm.com>
Date:   Thu May 12 09:05:30 2022 +0100

    TODO(sprof): cheri: disable profiling shared libraries
    
    This is needed now to avoid referencing abort in ld.so.
    
    TODO: Fixing shared library profiling for capabilities requires
    type fixes so capabilities are not stored into shared memory
    (maybe purecap layout can match the lp64 one and then no file format
    and external tooling change is required.)
    TODO: Proper fix also depends on _dl_runtime_profile plt entry

Diff:
---
 elf/dl-profile.c | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/elf/dl-profile.c b/elf/dl-profile.c
index ec57e3a965..2cb66e83c6 100644
--- a/elf/dl-profile.c
+++ b/elf/dl-profile.c
@@ -182,6 +182,9 @@ static unsigned int log_hashfraction;
 void
 _dl_start_profile (void)
 {
+#ifdef __CHERI_PURE_CAPABILITY__
+  __libc_fatal ("Profiling is not supported on capability architectures.");
+#else
   char *filename;
   int fd;
   struct __stat64_t64 st;
@@ -482,6 +485,7 @@ _dl_start_profile (void)
 
   /* Turn on profiling.  */
   running = 1;
+#endif
 }

^ permalink raw reply	[flat|nested] 4+ messages in thread
* [glibc/arm/morello/main] TODO(sprof): cheri: disable profiling shared libraries
@ 2022-10-27 13:58 Szabolcs Nagy
  0 siblings, 0 replies; 4+ messages in thread
From: Szabolcs Nagy @ 2022-10-27 13:58 UTC (permalink / raw)
  To: glibc-cvs

https://sourceware.org/git/gitweb.cgi?p=glibc.git;h=010cf0128e02429c8686772f20cf80b2ca678939

commit 010cf0128e02429c8686772f20cf80b2ca678939
Author: Szabolcs Nagy <szabolcs.nagy@arm.com>
Date:   Thu May 12 09:05:30 2022 +0100

    TODO(sprof): cheri: disable profiling shared libraries
    
    This is needed now to avoid referencing abort in ld.so.
    
    TODO: Fixing shared library profiling for capabilities requires
    type fixes so capabilities are not stored into shared memory
    (maybe purecap layout can match the lp64 one and then no file format
    and external tooling change is required.)
    TODO: Proper fix also depends on _dl_runtime_profile plt entry

Diff:
---
 elf/dl-profile.c | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/elf/dl-profile.c b/elf/dl-profile.c
index ec57e3a965..2cb66e83c6 100644
--- a/elf/dl-profile.c
+++ b/elf/dl-profile.c
@@ -182,6 +182,9 @@ static unsigned int log_hashfraction;
 void
 _dl_start_profile (void)
 {
+#ifdef __CHERI_PURE_CAPABILITY__
+  __libc_fatal ("Profiling is not supported on capability architectures.");
+#else
   char *filename;
   int fd;
   struct __stat64_t64 st;
@@ -482,6 +485,7 @@ _dl_start_profile (void)
 
   /* Turn on profiling.  */
   running = 1;
+#endif
 }

^ permalink raw reply	[flat|nested] 4+ messages in thread
* [glibc/arm/morello/main] TODO(sprof): cheri: disable profiling shared libraries
@ 2022-10-26 15:19 Szabolcs Nagy
  0 siblings, 0 replies; 4+ messages in thread
From: Szabolcs Nagy @ 2022-10-26 15:19 UTC (permalink / raw)
  To: glibc-cvs

https://sourceware.org/git/gitweb.cgi?p=glibc.git;h=7eafdab20da5957666acfdf2ac1c5ac3840374a2

commit 7eafdab20da5957666acfdf2ac1c5ac3840374a2
Author: Szabolcs Nagy <szabolcs.nagy@arm.com>
Date:   Thu May 12 09:05:30 2022 +0100

    TODO(sprof): cheri: disable profiling shared libraries
    
    This is needed now to avoid referencing abort in ld.so.
    
    TODO: Fixing shared library profiling for capabilities requires
    type fixes so capabilities are not stored into shared memory
    (maybe purecap layout can match the lp64 one and then no file format
    and external tooling change is required.)
    TODO: Proper fix also depends on _dl_runtime_profile plt entry

Diff:
---
 elf/dl-profile.c | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/elf/dl-profile.c b/elf/dl-profile.c
index ec57e3a965..2cb66e83c6 100644
--- a/elf/dl-profile.c
+++ b/elf/dl-profile.c
@@ -182,6 +182,9 @@ static unsigned int log_hashfraction;
 void
 _dl_start_profile (void)
 {
+#ifdef __CHERI_PURE_CAPABILITY__
+  __libc_fatal ("Profiling is not supported on capability architectures.");
+#else
   char *filename;
   int fd;
   struct __stat64_t64 st;
@@ -482,6 +485,7 @@ _dl_start_profile (void)
 
   /* Turn on profiling.  */
   running = 1;
+#endif
 }

^ permalink raw reply	[flat|nested] 4+ messages in thread
end of thread, other threads:[~2022-11-23 14:48 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-08-05 19:38 [glibc/arm/morello/main] TODO(sprof): cheri: disable profiling shared libraries Szabolcs Nagy
2022-10-26 15:19 Szabolcs Nagy
2022-10-27 13:58 Szabolcs Nagy
2022-11-23 14:48 Szabolcs Nagy

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).