public inbox for glibc-cvs@sourceware.org
help / color / mirror / Atom feed
* [glibc] Benchtests: Remove simple_strcpy_chk
@ 2023-03-08 18:46 Wilco Dijkstra
0 siblings, 0 replies; only message in thread
From: Wilco Dijkstra @ 2023-03-08 18:46 UTC (permalink / raw)
To: glibc-cvs
https://sourceware.org/git/gitweb.cgi?p=glibc.git;h=73a284f618aa81d2bd1f93b299ac5dbf95f396b1
commit 73a284f618aa81d2bd1f93b299ac5dbf95f396b1
Author: Wilco Dijkstra <wilco.dijkstra@arm.com>
Date: Fri Mar 3 12:44:46 2023 +0000
Benchtests: Remove simple_strcpy_chk
Remove the slow byte oriented simple_strcpy_chk and simple_stpcpy_chk.
Adjust iteration count to increase benchmark time.
Reviewed-by: Adhemerval Zanella <adhemerval.zanella@linaro.org>
Diff:
---
benchtests/bench-stpcpy_chk.c | 13 -------------
benchtests/bench-strcpy_chk.c | 15 +--------------
2 files changed, 1 insertion(+), 27 deletions(-)
diff --git a/benchtests/bench-stpcpy_chk.c b/benchtests/bench-stpcpy_chk.c
index aaacd336ba..85d5a5e924 100644
--- a/benchtests/bench-stpcpy_chk.c
+++ b/benchtests/bench-stpcpy_chk.c
@@ -22,24 +22,11 @@
#include "bench-string.h"
extern void __attribute__ ((noreturn)) __chk_fail (void);
-char *simple_stpcpy_chk (char *, const char *, size_t);
extern char *normal_stpcpy (char *, const char *, size_t)
__asm ("stpcpy");
extern char *__stpcpy_chk (char *, const char *, size_t);
-IMPL (simple_stpcpy_chk, 0)
IMPL (normal_stpcpy, 1)
IMPL (__stpcpy_chk, 2)
-char *
-simple_stpcpy_chk (char *dst, const char *src, size_t len)
-{
- if (! len)
- __chk_fail ();
- while ((*dst++ = *src++) != '\0')
- if (--len == 0)
- __chk_fail ();
- return dst - 1;
-}
-
#include "bench-strcpy_chk.c"
diff --git a/benchtests/bench-strcpy_chk.c b/benchtests/bench-strcpy_chk.c
index 6fce90cc98..48ecaaf392 100644
--- a/benchtests/bench-strcpy_chk.c
+++ b/benchtests/bench-strcpy_chk.c
@@ -26,26 +26,13 @@
symbol, which is part of the public ABI and may be used
externally. */
extern void __attribute__ ((noreturn)) __chk_fail (void);
-char *simple_strcpy_chk (char *, const char *, size_t);
extern char *normal_strcpy (char *, const char *, size_t)
__asm ("strcpy");
extern char *__strcpy_chk (char *, const char *, size_t);
-IMPL (simple_strcpy_chk, 0)
IMPL (normal_strcpy, 1)
IMPL (__strcpy_chk, 2)
-char *
-simple_strcpy_chk (char *dst, const char *src, size_t len)
-{
- char *ret = dst;
- if (! len)
- __chk_fail ();
- while ((*dst++ = *src++) != '\0')
- if (--len == 0)
- __chk_fail ();
- return ret;
-}
#endif
#include <fcntl.h>
@@ -77,7 +64,7 @@ do_one_test (impl_t *impl, char *dst, const char *src,
size_t len, size_t dlen)
{
char *res;
- size_t i, iters = INNER_LOOP_ITERS8;
+ size_t i, iters = INNER_LOOP_ITERS_LARGE;
timing_t start, stop, cur;
if (dlen <= len)
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2023-03-08 18:46 UTC | newest]
Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-03-08 18:46 [glibc] Benchtests: Remove simple_strcpy_chk Wilco Dijkstra
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).