public inbox for glibc-cvs@sourceware.org
help / color / mirror / Atom feed
* [glibc] Benchtests: Remove simple_str(n)casecmp
@ 2023-03-08 18:46 Wilco Dijkstra
  0 siblings, 0 replies; only message in thread
From: Wilco Dijkstra @ 2023-03-08 18:46 UTC (permalink / raw)
  To: glibc-cvs

https://sourceware.org/git/gitweb.cgi?p=glibc.git;h=9ab7c42387409d5cf8facd0a56cfd98ce55b8cc3

commit 9ab7c42387409d5cf8facd0a56cfd98ce55b8cc3
Author: Wilco Dijkstra <wilco.dijkstra@arm.com>
Date:   Fri Mar 3 13:21:05 2023 +0000

    Benchtests: Remove simple_str(n)casecmp
    
    Remove the slow byte oriented loops.  Adjust iteration count to reduce
    benchmark time.
    
    Reviewed-by: Adhemerval Zanella  <adhemerval.zanella@linaro.org>

Diff:
---
 benchtests/bench-strcasecmp.c  | 16 +---------------
 benchtests/bench-strncasecmp.c | 23 +----------------------
 2 files changed, 2 insertions(+), 37 deletions(-)

diff --git a/benchtests/bench-strcasecmp.c b/benchtests/bench-strcasecmp.c
index fcfffdea42..abc6a216e3 100644
--- a/benchtests/bench-strcasecmp.c
+++ b/benchtests/bench-strcasecmp.c
@@ -23,28 +23,14 @@
 #include "json-lib.h"
 
 typedef int (*proto_t) (const char *, const char *);
-static int simple_strcasecmp (const char *, const char *);
 
-IMPL (simple_strcasecmp, 0)
 IMPL (strcasecmp, 1)
 
-static int
-simple_strcasecmp (const char *s1, const char *s2)
-{
-  int ret;
-
-  while ((ret = ((unsigned char) tolower (*s1)
-		 - (unsigned char) tolower (*s2))) == 0
-	 && *s1++)
-    ++s2;
-  return ret;
-}
-
 static void
 do_one_test (json_ctx_t *json_ctx, impl_t *impl, const char *s1,
              const char *s2, int exp_result)
 {
-  size_t i, iters = INNER_LOOP_ITERS;
+  size_t i, iters = INNER_LOOP_ITERS8;
   timing_t start, stop, cur;
   int result = CALL (impl, s1, s2);
   if ((exp_result == 0 && result != 0)
diff --git a/benchtests/bench-strncasecmp.c b/benchtests/bench-strncasecmp.c
index 5689a22901..051c17d9f7 100644
--- a/benchtests/bench-strncasecmp.c
+++ b/benchtests/bench-strncasecmp.c
@@ -23,35 +23,14 @@
 #include "json-lib.h"
 
 typedef int (*proto_t) (const char *, const char *, size_t);
-static int simple_strncasecmp (const char *, const char *, size_t);
 
-IMPL (simple_strncasecmp, 0)
 IMPL (strncasecmp, 1)
 
-static int
-simple_strncasecmp (const char *s1, const char *s2, size_t n)
-{
-  int ret;
-
-  if (n == 0)
-    return 0;
-
-  while ((ret = ((unsigned char) tolower (*s1)
-		 - (unsigned char) tolower (*s2))) == 0
-	 && *s1++)
-    {
-      if (--n == 0)
-	return 0;
-      ++s2;
-    }
-  return ret;
-}
-
 static void
 do_one_test (json_ctx_t *json_ctx, impl_t *impl, const char *s1,
              const char *s2, size_t n, int exp_result)
 {
-  size_t i, iters = INNER_LOOP_ITERS;
+  size_t i, iters = INNER_LOOP_ITERS8;
   timing_t start, stop, cur;
 
   TIMING_NOW (start);

^ permalink raw reply	[flat|nested] only message in thread

only message in thread, other threads:[~2023-03-08 18:46 UTC | newest]

Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-03-08 18:46 [glibc] Benchtests: Remove simple_str(n)casecmp Wilco Dijkstra

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).