public inbox for glibc-cvs@sourceware.org help / color / mirror / Atom feed
From: Florian Weimer <fw@sourceware.org> To: glibc-cvs@sourceware.org Subject: [glibc] nss: Remove unused allocation from get_nscd_addresses in getaddrinfo Date: Wed, 20 Dec 2023 15:14:45 +0000 (GMT) [thread overview] Message-ID: <20231220151445.754C63858D20@sourceware.org> (raw) https://sourceware.org/git/gitweb.cgi?p=glibc.git;h=61bac1a9d2ab80ebcbc51484722e6ea43414bec7 commit 61bac1a9d2ab80ebcbc51484722e6ea43414bec7 Author: Florian Weimer <fweimer@redhat.com> Date: Wed Dec 20 16:14:33 2023 +0100 nss: Remove unused allocation from get_nscd_addresses in getaddrinfo No bug because this is not visible if glibc is built with optimization. Otherwise this would be a critical resource leak. Reviewed-by: Carlos O'Donell <carlos@redhat.com> Diff: --- nss/getaddrinfo.c | 1 - 1 file changed, 1 deletion(-) diff --git a/nss/getaddrinfo.c b/nss/getaddrinfo.c index 531124958d..ce3af931b2 100644 --- a/nss/getaddrinfo.c +++ b/nss/getaddrinfo.c @@ -514,7 +514,6 @@ get_nscd_addresses (const char *name, const struct addrinfo *req, int result = 0; char *addrs = air->addrs; - struct gaih_addrtuple *addrfree = calloc (air->naddrs, sizeof (*addrfree)); struct gaih_addrtuple *at = calloc (air->naddrs, sizeof (*at)); if (at == NULL) {
reply other threads:[~2023-12-20 15:14 UTC|newest] Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20231220151445.754C63858D20@sourceware.org \ --to=fw@sourceware.org \ --cc=glibc-cvs@sourceware.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).