public inbox for glibc-cvs@sourceware.org
help / color / mirror / Atom feed
* [glibc] nss: Remove unused allocation from get_nscd_addresses in getaddrinfo
@ 2023-12-20 15:14 Florian Weimer
  0 siblings, 0 replies; only message in thread
From: Florian Weimer @ 2023-12-20 15:14 UTC (permalink / raw)
  To: glibc-cvs

https://sourceware.org/git/gitweb.cgi?p=glibc.git;h=61bac1a9d2ab80ebcbc51484722e6ea43414bec7

commit 61bac1a9d2ab80ebcbc51484722e6ea43414bec7
Author: Florian Weimer <fweimer@redhat.com>
Date:   Wed Dec 20 16:14:33 2023 +0100

    nss: Remove unused allocation from get_nscd_addresses in getaddrinfo
    
    No bug because this is not visible if glibc is built with
    optimization.  Otherwise this would be a critical resource leak.
    
    Reviewed-by: Carlos O'Donell <carlos@redhat.com>

Diff:
---
 nss/getaddrinfo.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/nss/getaddrinfo.c b/nss/getaddrinfo.c
index 531124958d..ce3af931b2 100644
--- a/nss/getaddrinfo.c
+++ b/nss/getaddrinfo.c
@@ -514,7 +514,6 @@ get_nscd_addresses (const char *name, const struct addrinfo *req,
   int result = 0;
   char *addrs = air->addrs;
 
-  struct gaih_addrtuple *addrfree = calloc (air->naddrs, sizeof (*addrfree));
   struct gaih_addrtuple *at = calloc (air->naddrs, sizeof (*at));
   if (at == NULL)
     {

^ permalink raw reply	[flat|nested] only message in thread

only message in thread, other threads:[~2023-12-20 15:14 UTC | newest]

Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-12-20 15:14 [glibc] nss: Remove unused allocation from get_nscd_addresses in getaddrinfo Florian Weimer

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).