public inbox for glibc-cvs@sourceware.org
help / color / mirror / Atom feed
* [glibc/google/grte/v5-2.27/master] CVE-2018-19591: if_nametoindex: Fix descriptor for overlong name [BZ #23927]
@ 2024-01-12 23:23 Pranav Kant
0 siblings, 0 replies; only message in thread
From: Pranav Kant @ 2024-01-12 23:23 UTC (permalink / raw)
To: glibc-cvs
https://sourceware.org/git/gitweb.cgi?p=glibc.git;h=ac5b88042331d3a6ba0e44f8ebcc41a35ec1dab2
commit ac5b88042331d3a6ba0e44f8ebcc41a35ec1dab2
Author: Florian Weimer <fweimer@redhat.com>
Date: Tue Nov 27 16:12:43 2018 +0100
CVE-2018-19591: if_nametoindex: Fix descriptor for overlong name [BZ #23927]
Diff:
---
ChangeLog | 8 ++++++++
NEWS | 4 ++++
sysdeps/unix/sysv/linux/if_index.c | 11 ++++++-----
3 files changed, 18 insertions(+), 5 deletions(-)
diff --git a/ChangeLog b/ChangeLog
index 7cf21922f0..0306f0caaf 100644
--- a/ChangeLog
+++ b/ChangeLog
@@ -31,6 +31,13 @@
* resolv/tst-resolv-nondecimal.c: Likewise.
* sysdeps/posix/getaddrinfo.c (gaih_inet): Call __inet_aton_exact.
+2018-11-27 Florian Weimer <fweimer@redhat.com>
+
+ [BZ #23927]
+ CVE-2018-19591
+ * sysdeps/unix/sysv/linux/if_index.c (__if_nametoindex): Avoid
+ descriptor leak in case of ENODEV error.
+
2018-05-18 Joseph Myers <joseph@codesourcery.com>
[BZ #22639]
@@ -38,6 +45,7 @@
* time/tst-y2039.c: New file.
* time/Makefile (tests): Add tst-y2039.
+
2018-02-12 Zack Weinberg <zackw@panix.com>
[BZ #19239]
diff --git a/NEWS b/NEWS
index 162a845cc0..46b5a2d8d8 100644
--- a/NEWS
+++ b/NEWS
@@ -32,6 +32,10 @@ Security related changes:
addresses with arbitrary trailing characters, potentially leading to data
or command injection issues in applications.
+ CVE-2018-19591: A file descriptor leak in if_nametoindex can lead to a
+ denial of service due to resource exhaustion when processing getaddrinfo
+ calls with crafted host names. Reported by Guido Vranken.
+
CVE-2017-18269: An SSE2-based memmove implementation for the i386
architecture could corrupt memory. Reported by Max Horn.
diff --git a/sysdeps/unix/sysv/linux/if_index.c b/sysdeps/unix/sysv/linux/if_index.c
index e3d08982d9..782fc5e175 100644
--- a/sysdeps/unix/sysv/linux/if_index.c
+++ b/sysdeps/unix/sysv/linux/if_index.c
@@ -38,11 +38,6 @@ __if_nametoindex (const char *ifname)
return 0;
#else
struct ifreq ifr;
- int fd = __opensock ();
-
- if (fd < 0)
- return 0;
-
if (strlen (ifname) >= IFNAMSIZ)
{
__set_errno (ENODEV);
@@ -50,6 +45,12 @@ __if_nametoindex (const char *ifname)
}
strncpy (ifr.ifr_name, ifname, sizeof (ifr.ifr_name));
+
+ int fd = __opensock ();
+
+ if (fd < 0)
+ return 0;
+
if (__ioctl (fd, SIOCGIFINDEX, &ifr) < 0)
{
int saved_errno = errno;
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2024-01-12 23:23 UTC | newest]
Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2024-01-12 23:23 [glibc/google/grte/v5-2.27/master] CVE-2018-19591: if_nametoindex: Fix descriptor for overlong name [BZ #23927] Pranav Kant
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).