public inbox for glibc-cvs@sourceware.org
help / color / mirror / Atom feed
* [glibc/azanella/clang] benchtests: Add attribute_optimize
@ 2024-04-17 20:14 Adhemerval Zanella
0 siblings, 0 replies; 4+ messages in thread
From: Adhemerval Zanella @ 2024-04-17 20:14 UTC (permalink / raw)
To: glibc-cvs
https://sourceware.org/git/gitweb.cgi?p=glibc.git;h=b1be860cbc76a9c8053c23b578891b7cf70c6f49
commit b1be860cbc76a9c8053c23b578891b7cf70c6f49
Author: Adhemerval Zanella <adhemerval.zanella@linaro.org>
Date: Tue Feb 6 16:51:25 2024 -0300
benchtests: Add attribute_optimize
Similar to tst-printf-bz18872.sh, add the attribute_optimize to avoid
build failures with compilers that do not support "GCC optimize" pragma.
Diff:
---
benchtests/bench-pthread-lock-base.c | 11 +++++------
benchtests/bench-pthread-locks.c | 10 +++-------
benchtests/bench-util.h | 6 ++++++
3 files changed, 14 insertions(+), 13 deletions(-)
diff --git a/benchtests/bench-pthread-lock-base.c b/benchtests/bench-pthread-lock-base.c
index 0a6155714a..e94a69321c 100644
--- a/benchtests/bench-pthread-lock-base.c
+++ b/benchtests/bench-pthread-lock-base.c
@@ -28,6 +28,7 @@
#include <sys/time.h>
#include <sys/sysinfo.h>
#include "bench-timing.h"
+#include "bench-util.h"
#include "json-lib.h"
static bench_lock_t lock;
@@ -36,10 +37,8 @@ static pthread_barrier_t barrier;
#define START_ITERS 1000
-#pragma GCC push_options
-#pragma GCC optimize(1)
-
-static int __attribute__ ((noinline)) fibonacci (int i)
+static int __attribute__ ((noinline)) attribute_optimize (1)
+fibonacci (int i)
{
asm("");
if (i > 2)
@@ -48,6 +47,7 @@ static int __attribute__ ((noinline)) fibonacci (int i)
}
static void
+attribute_optimize (1)
do_filler (void)
{
char buf1[512], buf2[512];
@@ -56,6 +56,7 @@ do_filler (void)
}
static void
+attribute_optimize (1)
do_filler_shared (void)
{
static char buf1[512], buf2[512];
@@ -63,8 +64,6 @@ do_filler_shared (void)
memcpy (buf1, buf2, f);
}
-#pragma GCC pop_options
-
#define UNIT_WORK_CRT do_filler_shared ()
#define UNIT_WORK_NON_CRT do_filler ()
diff --git a/benchtests/bench-pthread-locks.c b/benchtests/bench-pthread-locks.c
index 9cfe08604a..c7e82d1d81 100644
--- a/benchtests/bench-pthread-locks.c
+++ b/benchtests/bench-pthread-locks.c
@@ -29,6 +29,7 @@
#include <sys/time.h>
#include <math.h>
#include "bench-timing.h"
+#include "bench-util.h"
#include "json-lib.h"
/* The point of this benchmark is to measure the overhead of an empty
@@ -61,10 +62,7 @@ typedef timing_t (*test_t)(long, int);
total time each test iteration takes, so as to not swamp the useful
timings. */
-#pragma GCC push_options
-#pragma GCC optimize(1)
-
-static int __attribute__((noinline))
+static int __attribute__((noinline)) attribute_optimize (1)
fibonacci (int i)
{
asm("");
@@ -73,7 +71,7 @@ fibonacci (int i)
return 10+i;
}
-static void
+static void attribute_optimize (1)
do_filler (void)
{
static char buf1[512], buf2[512];
@@ -81,8 +79,6 @@ do_filler (void)
memcpy (buf1, buf2, f);
}
-#pragma GCC pop_options
-
static timing_t
test_mutex (long iters, int filler)
{
diff --git a/benchtests/bench-util.h b/benchtests/bench-util.h
index 91d9089237..66a677ac9b 100644
--- a/benchtests/bench-util.h
+++ b/benchtests/bench-util.h
@@ -24,6 +24,12 @@
__v; \
})
+#if __GNUC_PREREQ (4, 4) || __glibc_has_attribute (__optimize__)
+# define attribute_optimize(level) __attribute__ ((optimize (level)))
+#else
+# define attribute_optimize(level)
+#endif
+
#ifndef START_ITER
# define START_ITER (100000000)
#endif
^ permalink raw reply [flat|nested] 4+ messages in thread
* [glibc/azanella/clang] benchtests: Add attribute_optimize
@ 2024-04-02 16:01 Adhemerval Zanella
0 siblings, 0 replies; 4+ messages in thread
From: Adhemerval Zanella @ 2024-04-02 16:01 UTC (permalink / raw)
To: glibc-cvs
https://sourceware.org/git/gitweb.cgi?p=glibc.git;h=60151748f4af14f5e84baf0d5938fbb720bea0b8
commit 60151748f4af14f5e84baf0d5938fbb720bea0b8
Author: Adhemerval Zanella <adhemerval.zanella@linaro.org>
Date: Tue Feb 6 16:51:25 2024 -0300
benchtests: Add attribute_optimize
Similar to tst-printf-bz18872.sh, add the attribute_optimize to avoid
build failures with compilers that do not support "GCC optimize" pragma.
Diff:
---
benchtests/bench-pthread-lock-base.c | 11 +++++------
benchtests/bench-pthread-locks.c | 10 +++-------
benchtests/bench-util.h | 6 ++++++
3 files changed, 14 insertions(+), 13 deletions(-)
diff --git a/benchtests/bench-pthread-lock-base.c b/benchtests/bench-pthread-lock-base.c
index 0a6155714a..e94a69321c 100644
--- a/benchtests/bench-pthread-lock-base.c
+++ b/benchtests/bench-pthread-lock-base.c
@@ -28,6 +28,7 @@
#include <sys/time.h>
#include <sys/sysinfo.h>
#include "bench-timing.h"
+#include "bench-util.h"
#include "json-lib.h"
static bench_lock_t lock;
@@ -36,10 +37,8 @@ static pthread_barrier_t barrier;
#define START_ITERS 1000
-#pragma GCC push_options
-#pragma GCC optimize(1)
-
-static int __attribute__ ((noinline)) fibonacci (int i)
+static int __attribute__ ((noinline)) attribute_optimize (1)
+fibonacci (int i)
{
asm("");
if (i > 2)
@@ -48,6 +47,7 @@ static int __attribute__ ((noinline)) fibonacci (int i)
}
static void
+attribute_optimize (1)
do_filler (void)
{
char buf1[512], buf2[512];
@@ -56,6 +56,7 @@ do_filler (void)
}
static void
+attribute_optimize (1)
do_filler_shared (void)
{
static char buf1[512], buf2[512];
@@ -63,8 +64,6 @@ do_filler_shared (void)
memcpy (buf1, buf2, f);
}
-#pragma GCC pop_options
-
#define UNIT_WORK_CRT do_filler_shared ()
#define UNIT_WORK_NON_CRT do_filler ()
diff --git a/benchtests/bench-pthread-locks.c b/benchtests/bench-pthread-locks.c
index 9cfe08604a..c7e82d1d81 100644
--- a/benchtests/bench-pthread-locks.c
+++ b/benchtests/bench-pthread-locks.c
@@ -29,6 +29,7 @@
#include <sys/time.h>
#include <math.h>
#include "bench-timing.h"
+#include "bench-util.h"
#include "json-lib.h"
/* The point of this benchmark is to measure the overhead of an empty
@@ -61,10 +62,7 @@ typedef timing_t (*test_t)(long, int);
total time each test iteration takes, so as to not swamp the useful
timings. */
-#pragma GCC push_options
-#pragma GCC optimize(1)
-
-static int __attribute__((noinline))
+static int __attribute__((noinline)) attribute_optimize (1)
fibonacci (int i)
{
asm("");
@@ -73,7 +71,7 @@ fibonacci (int i)
return 10+i;
}
-static void
+static void attribute_optimize (1)
do_filler (void)
{
static char buf1[512], buf2[512];
@@ -81,8 +79,6 @@ do_filler (void)
memcpy (buf1, buf2, f);
}
-#pragma GCC pop_options
-
static timing_t
test_mutex (long iters, int filler)
{
diff --git a/benchtests/bench-util.h b/benchtests/bench-util.h
index 91d9089237..66a677ac9b 100644
--- a/benchtests/bench-util.h
+++ b/benchtests/bench-util.h
@@ -24,6 +24,12 @@
__v; \
})
+#if __GNUC_PREREQ (4, 4) || __glibc_has_attribute (__optimize__)
+# define attribute_optimize(level) __attribute__ ((optimize (level)))
+#else
+# define attribute_optimize(level)
+#endif
+
#ifndef START_ITER
# define START_ITER (100000000)
#endif
^ permalink raw reply [flat|nested] 4+ messages in thread
* [glibc/azanella/clang] benchtests: Add attribute_optimize
@ 2024-02-09 17:39 Adhemerval Zanella
0 siblings, 0 replies; 4+ messages in thread
From: Adhemerval Zanella @ 2024-02-09 17:39 UTC (permalink / raw)
To: glibc-cvs
https://sourceware.org/git/gitweb.cgi?p=glibc.git;h=a2017486800dece423cfbacbb52836cae84af018
commit a2017486800dece423cfbacbb52836cae84af018
Author: Adhemerval Zanella <adhemerval.zanella@linaro.org>
Date: Tue Feb 6 16:51:25 2024 -0300
benchtests: Add attribute_optimize
Similar to tst-printf-bz18872.sh, add the attribute_optimize to avoid
build failures with compilers that do not support "GCC optimize" pragma.
Diff:
---
benchtests/bench-pthread-lock-base.c | 11 +++++------
benchtests/bench-pthread-locks.c | 10 +++-------
benchtests/bench-util.h | 6 ++++++
3 files changed, 14 insertions(+), 13 deletions(-)
diff --git a/benchtests/bench-pthread-lock-base.c b/benchtests/bench-pthread-lock-base.c
index 0a6155714a..e94a69321c 100644
--- a/benchtests/bench-pthread-lock-base.c
+++ b/benchtests/bench-pthread-lock-base.c
@@ -28,6 +28,7 @@
#include <sys/time.h>
#include <sys/sysinfo.h>
#include "bench-timing.h"
+#include "bench-util.h"
#include "json-lib.h"
static bench_lock_t lock;
@@ -36,10 +37,8 @@ static pthread_barrier_t barrier;
#define START_ITERS 1000
-#pragma GCC push_options
-#pragma GCC optimize(1)
-
-static int __attribute__ ((noinline)) fibonacci (int i)
+static int __attribute__ ((noinline)) attribute_optimize (1)
+fibonacci (int i)
{
asm("");
if (i > 2)
@@ -48,6 +47,7 @@ static int __attribute__ ((noinline)) fibonacci (int i)
}
static void
+attribute_optimize (1)
do_filler (void)
{
char buf1[512], buf2[512];
@@ -56,6 +56,7 @@ do_filler (void)
}
static void
+attribute_optimize (1)
do_filler_shared (void)
{
static char buf1[512], buf2[512];
@@ -63,8 +64,6 @@ do_filler_shared (void)
memcpy (buf1, buf2, f);
}
-#pragma GCC pop_options
-
#define UNIT_WORK_CRT do_filler_shared ()
#define UNIT_WORK_NON_CRT do_filler ()
diff --git a/benchtests/bench-pthread-locks.c b/benchtests/bench-pthread-locks.c
index 9cfe08604a..c7e82d1d81 100644
--- a/benchtests/bench-pthread-locks.c
+++ b/benchtests/bench-pthread-locks.c
@@ -29,6 +29,7 @@
#include <sys/time.h>
#include <math.h>
#include "bench-timing.h"
+#include "bench-util.h"
#include "json-lib.h"
/* The point of this benchmark is to measure the overhead of an empty
@@ -61,10 +62,7 @@ typedef timing_t (*test_t)(long, int);
total time each test iteration takes, so as to not swamp the useful
timings. */
-#pragma GCC push_options
-#pragma GCC optimize(1)
-
-static int __attribute__((noinline))
+static int __attribute__((noinline)) attribute_optimize (1)
fibonacci (int i)
{
asm("");
@@ -73,7 +71,7 @@ fibonacci (int i)
return 10+i;
}
-static void
+static void attribute_optimize (1)
do_filler (void)
{
static char buf1[512], buf2[512];
@@ -81,8 +79,6 @@ do_filler (void)
memcpy (buf1, buf2, f);
}
-#pragma GCC pop_options
-
static timing_t
test_mutex (long iters, int filler)
{
diff --git a/benchtests/bench-util.h b/benchtests/bench-util.h
index 91d9089237..66a677ac9b 100644
--- a/benchtests/bench-util.h
+++ b/benchtests/bench-util.h
@@ -24,6 +24,12 @@
__v; \
})
+#if __GNUC_PREREQ (4, 4) || __glibc_has_attribute (__optimize__)
+# define attribute_optimize(level) __attribute__ ((optimize (level)))
+#else
+# define attribute_optimize(level)
+#endif
+
#ifndef START_ITER
# define START_ITER (100000000)
#endif
^ permalink raw reply [flat|nested] 4+ messages in thread
* [glibc/azanella/clang] benchtests: Add attribute_optimize
@ 2024-02-07 14:14 Adhemerval Zanella
0 siblings, 0 replies; 4+ messages in thread
From: Adhemerval Zanella @ 2024-02-07 14:14 UTC (permalink / raw)
To: glibc-cvs
https://sourceware.org/git/gitweb.cgi?p=glibc.git;h=218c3d999f55aa0149104a44444834a68dfbe546
commit 218c3d999f55aa0149104a44444834a68dfbe546
Author: Adhemerval Zanella <adhemerval.zanella@linaro.org>
Date: Tue Feb 6 16:51:25 2024 -0300
benchtests: Add attribute_optimize
Similar to tst-printf-bz18872.sh, add the attribute_optimize to avoid
build failures with compilers that do not support "GCC optimize" pragma.
Diff:
---
benchtests/bench-pthread-lock-base.c | 11 +++++------
benchtests/bench-pthread-locks.c | 10 +++-------
benchtests/bench-util.h | 6 ++++++
3 files changed, 14 insertions(+), 13 deletions(-)
diff --git a/benchtests/bench-pthread-lock-base.c b/benchtests/bench-pthread-lock-base.c
index 0a6155714a..e94a69321c 100644
--- a/benchtests/bench-pthread-lock-base.c
+++ b/benchtests/bench-pthread-lock-base.c
@@ -28,6 +28,7 @@
#include <sys/time.h>
#include <sys/sysinfo.h>
#include "bench-timing.h"
+#include "bench-util.h"
#include "json-lib.h"
static bench_lock_t lock;
@@ -36,10 +37,8 @@ static pthread_barrier_t barrier;
#define START_ITERS 1000
-#pragma GCC push_options
-#pragma GCC optimize(1)
-
-static int __attribute__ ((noinline)) fibonacci (int i)
+static int __attribute__ ((noinline)) attribute_optimize (1)
+fibonacci (int i)
{
asm("");
if (i > 2)
@@ -48,6 +47,7 @@ static int __attribute__ ((noinline)) fibonacci (int i)
}
static void
+attribute_optimize (1)
do_filler (void)
{
char buf1[512], buf2[512];
@@ -56,6 +56,7 @@ do_filler (void)
}
static void
+attribute_optimize (1)
do_filler_shared (void)
{
static char buf1[512], buf2[512];
@@ -63,8 +64,6 @@ do_filler_shared (void)
memcpy (buf1, buf2, f);
}
-#pragma GCC pop_options
-
#define UNIT_WORK_CRT do_filler_shared ()
#define UNIT_WORK_NON_CRT do_filler ()
diff --git a/benchtests/bench-pthread-locks.c b/benchtests/bench-pthread-locks.c
index 9cfe08604a..c7e82d1d81 100644
--- a/benchtests/bench-pthread-locks.c
+++ b/benchtests/bench-pthread-locks.c
@@ -29,6 +29,7 @@
#include <sys/time.h>
#include <math.h>
#include "bench-timing.h"
+#include "bench-util.h"
#include "json-lib.h"
/* The point of this benchmark is to measure the overhead of an empty
@@ -61,10 +62,7 @@ typedef timing_t (*test_t)(long, int);
total time each test iteration takes, so as to not swamp the useful
timings. */
-#pragma GCC push_options
-#pragma GCC optimize(1)
-
-static int __attribute__((noinline))
+static int __attribute__((noinline)) attribute_optimize (1)
fibonacci (int i)
{
asm("");
@@ -73,7 +71,7 @@ fibonacci (int i)
return 10+i;
}
-static void
+static void attribute_optimize (1)
do_filler (void)
{
static char buf1[512], buf2[512];
@@ -81,8 +79,6 @@ do_filler (void)
memcpy (buf1, buf2, f);
}
-#pragma GCC pop_options
-
static timing_t
test_mutex (long iters, int filler)
{
diff --git a/benchtests/bench-util.h b/benchtests/bench-util.h
index 91d9089237..66a677ac9b 100644
--- a/benchtests/bench-util.h
+++ b/benchtests/bench-util.h
@@ -24,6 +24,12 @@
__v; \
})
+#if __GNUC_PREREQ (4, 4) || __glibc_has_attribute (__optimize__)
+# define attribute_optimize(level) __attribute__ ((optimize (level)))
+#else
+# define attribute_optimize(level)
+#endif
+
#ifndef START_ITER
# define START_ITER (100000000)
#endif
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2024-04-17 20:14 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2024-04-17 20:14 [glibc/azanella/clang] benchtests: Add attribute_optimize Adhemerval Zanella
-- strict thread matches above, loose matches on Subject: below --
2024-04-02 16:01 Adhemerval Zanella
2024-02-09 17:39 Adhemerval Zanella
2024-02-07 14:14 Adhemerval Zanella
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).