public inbox for glibc-cvs@sourceware.org
help / color / mirror / Atom feed
From: Andreas Schwab <schwab@suse.de>
To: Adhemerval Zanella via Glibc-cvs <glibc-cvs@sourceware.org>
Cc: Adhemerval Zanella <azanella@sourceware.org>
Subject: Re: [glibc/release/2.34/master] elf: Fix wrong break removal from 8ee878592c
Date: Mon, 12 Feb 2024 14:36:53 +0100	[thread overview]
Message-ID: <mvmil2t3itm.fsf@suse.de> (raw)
In-Reply-To: <20240212132237.2AB663858D32@sourceware.org> (Adhemerval Zanella via Glibc-cvs's message of "Mon, 12 Feb 2024 13:22:37 +0000 (GMT)")

On Feb 12 2024, Adhemerval Zanella via Glibc-cvs wrote:

> https://sourceware.org/git/gitweb.cgi?p=glibc.git;h=62ac4b09c4ee66c91478212359b8ac44b4f6a9e2
>
> commit 62ac4b09c4ee66c91478212359b8ac44b4f6a9e2
> Author: Adhemerval Zanella <adhemerval.zanella@linaro.org>
> Date:   Thu Dec 7 11:17:35 2023 -0300
>
>     elf: Fix wrong break removal from 8ee878592c
>     
>     Reported-by: Alexander Monakov <amonakov@ispras.ru>
>     (cherry picked from commit 546a1ba664626603660b595662249d524e429013)
>
> Diff:
> ---
>  elf/readelflib.c | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/elf/readelflib.c b/elf/readelflib.c
> index c09425a574..2c0bae9fc0 100644
> --- a/elf/readelflib.c
> +++ b/elf/readelflib.c
> @@ -112,6 +112,7 @@ process_elf_file (const char *file_name, const char *lib, int *flag,
>  	case PT_INTERP:
>  	  program_interpreter = (char *) (file_contents + segment->p_offset);
>  	  check_ptr (program_interpreter);
> +	  break;
>  
>  	  /* Check if this is enough to classify the binary.  */
>  	  for (j = 0; j < sizeof (interpreters) / sizeof (interpreters [0]);

This needs to be reverted, 2.34 does *not* have 8ee878592c.

-- 
Andreas Schwab, SUSE Labs, schwab@suse.de
GPG Key fingerprint = 0196 BAD8 1CE9 1970 F4BE  1748 E4D4 88E3 0EEA B9D7
"And now for something completely different."

  reply	other threads:[~2024-02-12 13:36 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-02-12 13:22 Adhemerval Zanella
2024-02-12 13:36 ` Andreas Schwab [this message]
2024-02-12 13:47   ` Adhemerval Zanella Netto

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=mvmil2t3itm.fsf@suse.de \
    --to=schwab@suse.de \
    --cc=azanella@sourceware.org \
    --cc=glibc-cvs@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).