public inbox for glibc-cvs@sourceware.org
help / color / mirror / Atom feed
* [glibc/release/2.34/master] elf: Fix wrong break removal from 8ee878592c
@ 2024-02-12 13:22 Adhemerval Zanella
2024-02-12 13:36 ` Andreas Schwab
0 siblings, 1 reply; 3+ messages in thread
From: Adhemerval Zanella @ 2024-02-12 13:22 UTC (permalink / raw)
To: glibc-cvs
https://sourceware.org/git/gitweb.cgi?p=glibc.git;h=62ac4b09c4ee66c91478212359b8ac44b4f6a9e2
commit 62ac4b09c4ee66c91478212359b8ac44b4f6a9e2
Author: Adhemerval Zanella <adhemerval.zanella@linaro.org>
Date: Thu Dec 7 11:17:35 2023 -0300
elf: Fix wrong break removal from 8ee878592c
Reported-by: Alexander Monakov <amonakov@ispras.ru>
(cherry picked from commit 546a1ba664626603660b595662249d524e429013)
Diff:
---
elf/readelflib.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/elf/readelflib.c b/elf/readelflib.c
index c09425a574..2c0bae9fc0 100644
--- a/elf/readelflib.c
+++ b/elf/readelflib.c
@@ -112,6 +112,7 @@ process_elf_file (const char *file_name, const char *lib, int *flag,
case PT_INTERP:
program_interpreter = (char *) (file_contents + segment->p_offset);
check_ptr (program_interpreter);
+ break;
/* Check if this is enough to classify the binary. */
for (j = 0; j < sizeof (interpreters) / sizeof (interpreters [0]);
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [glibc/release/2.34/master] elf: Fix wrong break removal from 8ee878592c
2024-02-12 13:22 [glibc/release/2.34/master] elf: Fix wrong break removal from 8ee878592c Adhemerval Zanella
@ 2024-02-12 13:36 ` Andreas Schwab
2024-02-12 13:47 ` Adhemerval Zanella Netto
0 siblings, 1 reply; 3+ messages in thread
From: Andreas Schwab @ 2024-02-12 13:36 UTC (permalink / raw)
To: Adhemerval Zanella via Glibc-cvs; +Cc: Adhemerval Zanella
On Feb 12 2024, Adhemerval Zanella via Glibc-cvs wrote:
> https://sourceware.org/git/gitweb.cgi?p=glibc.git;h=62ac4b09c4ee66c91478212359b8ac44b4f6a9e2
>
> commit 62ac4b09c4ee66c91478212359b8ac44b4f6a9e2
> Author: Adhemerval Zanella <adhemerval.zanella@linaro.org>
> Date: Thu Dec 7 11:17:35 2023 -0300
>
> elf: Fix wrong break removal from 8ee878592c
>
> Reported-by: Alexander Monakov <amonakov@ispras.ru>
> (cherry picked from commit 546a1ba664626603660b595662249d524e429013)
>
> Diff:
> ---
> elf/readelflib.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/elf/readelflib.c b/elf/readelflib.c
> index c09425a574..2c0bae9fc0 100644
> --- a/elf/readelflib.c
> +++ b/elf/readelflib.c
> @@ -112,6 +112,7 @@ process_elf_file (const char *file_name, const char *lib, int *flag,
> case PT_INTERP:
> program_interpreter = (char *) (file_contents + segment->p_offset);
> check_ptr (program_interpreter);
> + break;
>
> /* Check if this is enough to classify the binary. */
> for (j = 0; j < sizeof (interpreters) / sizeof (interpreters [0]);
This needs to be reverted, 2.34 does *not* have 8ee878592c.
--
Andreas Schwab, SUSE Labs, schwab@suse.de
GPG Key fingerprint = 0196 BAD8 1CE9 1970 F4BE 1748 E4D4 88E3 0EEA B9D7
"And now for something completely different."
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [glibc/release/2.34/master] elf: Fix wrong break removal from 8ee878592c
2024-02-12 13:36 ` Andreas Schwab
@ 2024-02-12 13:47 ` Adhemerval Zanella Netto
0 siblings, 0 replies; 3+ messages in thread
From: Adhemerval Zanella Netto @ 2024-02-12 13:47 UTC (permalink / raw)
To: Andreas Schwab, Adhemerval Zanella via Glibc-cvs; +Cc: Adhemerval Zanella
On 12/02/24 10:36, Andreas Schwab wrote:
> On Feb 12 2024, Adhemerval Zanella via Glibc-cvs wrote:
>
>> https://sourceware.org/git/gitweb.cgi?p=glibc.git;h=62ac4b09c4ee66c91478212359b8ac44b4f6a9e2
>>
>> commit 62ac4b09c4ee66c91478212359b8ac44b4f6a9e2
>> Author: Adhemerval Zanella <adhemerval.zanella@linaro.org>
>> Date: Thu Dec 7 11:17:35 2023 -0300
>>
>> elf: Fix wrong break removal from 8ee878592c
>>
>> Reported-by: Alexander Monakov <amonakov@ispras.ru>
>> (cherry picked from commit 546a1ba664626603660b595662249d524e429013)
>>
>> Diff:
>> ---
>> elf/readelflib.c | 1 +
>> 1 file changed, 1 insertion(+)
>>
>> diff --git a/elf/readelflib.c b/elf/readelflib.c
>> index c09425a574..2c0bae9fc0 100644
>> --- a/elf/readelflib.c
>> +++ b/elf/readelflib.c
>> @@ -112,6 +112,7 @@ process_elf_file (const char *file_name, const char *lib, int *flag,
>> case PT_INTERP:
>> program_interpreter = (char *) (file_contents + segment->p_offset);
>> check_ptr (program_interpreter);
>> + break;
>>
>> /* Check if this is enough to classify the binary. */
>> for (j = 0; j < sizeof (interpreters) / sizeof (interpreters [0]);
>
> This needs to be reverted, 2.34 does *not* have 8ee878592c.
>
Done.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2024-02-12 13:47 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2024-02-12 13:22 [glibc/release/2.34/master] elf: Fix wrong break removal from 8ee878592c Adhemerval Zanella
2024-02-12 13:36 ` Andreas Schwab
2024-02-12 13:47 ` Adhemerval Zanella Netto
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).