gnats/gnats ChangeLog Makefile.in adm.c adm.h ...

gnats/gnats ChangeLog Makefile.in adm.c adm.h ...

[bmanson]

CVSROOT:	/cvs/gnats
Module name:	gnats
Changes by:	bmanson@sourceware.cygnus.com	99/12/21 20:44:24

Modified files:
	gnats          : ChangeLog Makefile.in adm.c adm.h at-pr.sh 
	                 btime.c check-db.sh client.c cmds.c config.h 
	                 configure configure.in delete-pr.sh edit.c 
	                 fconfig.y fconfigl.l field.h file-pr.c files.c 
	                 files.h gen-closed-date.c gen-index.c 
	                 getclose.c getdate.y globals.h gnats-edit-pr.sh 
	                 gnats-file-pr.sh gnats.h gnatsd.access gnatsd.c 
	                 gnatsd.h index.c index.h internal.c lists.c 
	                 mail-query.sh misc.c mkcat.sh mkdist.sh 
	                 npr-addr.c npr-edit.c pcodes.h pr-addr.c 
	                 pr-age.c pr-edit.c pr-init.c pr-mail.c 
	                 pr-stat.c pr.c pr.h query-pr.c query.c query.h 
	                 queue-pr.c responsible rmcat.sh sub-type.c 
	                 submitters 
Added files:
	gnats          : database.c database.h field-config.in 
	                 gnatsd.host_access 
Removed files:
	gnats          : config.c config.c.in config.m4 db_conf.c 
	                 db_conf.h field-config gnats-db.conf 
	                 gnatsd.conf xmalloc.c 

Log message:
	* Removed config file and associated trappings, and now most of the
	config that was previously there is now in field-config (which
	will probably be renamed shortly).
	
	GNATS_ROOT is no longer.  The GNATSDB environment variable is now
	used to determine which database to use (or the -d option to the
	clients).
	
	Databases must now be specified by name.  The list of database
	names is now in ${datadir}/gnats_databases by default.  It is
	formatted similarly to the other adm files, and uses the same
	routines.  Since there is one other GNATS file in ${datadir},
	namely gnatsd.access, it may make sense to make a gnats/
	subdirectory there but I'm reluctant to do it for two files.
	
	Currently GNATSDB only contains a database name; eventually it
	will also be of the form
	host:port:name
	which is used for remote access.  Someday some sort of ssh
	tunneling functionality will be added, especially now that the
	emphasis is on remote access.
	
	The default database is now located in ${sharedstatedir}/gnatsdb.
	I may change things to allow the datafiles to be located
	indepndently from the database.  The only major change would be
	to the scripts, and the vast majority shouldn't need to be changed
	now.
	
	query-pr now supports specifying a format string on the
	command line with the --format option:
	
	query-pr --format '"%s %s" Number State'
	
	prints out the Number: and State: field values with
	a space between the two.  Also,
	
	query-pr --format State
	
	prints out the State field.
	
	A new server command, QFMT, has been added.  The query format is
	now specified with QFMT (and must be specified before QUER is
	invoked).  I have not tested remote access lately, it may
	very well be broken (tho gnatsd seems to be working from the
	command line).
	
	A few new options have been added to query-pr, to print out the
	directory where a database is located, and to dump a sh-compatible
	set of variables describing things like the name of the database,
	its location, etc.
	
	The NOTIFY, ACKNOWLEDGE and DEFAULT_SUBMITTER configure options
	have been deleted.  DEFAULT_SUBMITTER is gotten from the submitters
	list instead--it's the first entry.  (It always was, it's just
	not being kept in two places now).  There's also no longer a
	default port number--if you need to set a default port, add it
	to /etc/services as a service instead.
	
	MAIL_AGENT is also gone; the mail-agent script is used instead
	(the script is installed in ${libexecdir}/gnats/mail-agent).
	
	lists.c has been reoverhauled; it's much better now.  It no longer
	dumps out files directly, except for the field-config file.
	
	db_conf* have been removed (functionality replaced in database.c).
	
	Many of the scripts are currently broken (they refer to GNATS_ROOT,
	and they need to call query-pr to get the directory name for the
	database instead).
	
	Many, many, many prototype fixes.  10 hours worth, in fact.
	Enabled several anal pedantic warnings in gcc.  Eventually these
	will only be enabled when --enable-maintainer-mode is turned on
	(some systems have broken headers and things simply won't
	compile otherwise).
	
	Removed xmalloc.[ch]; xmalloc is used from libiberty, and free is
	called directly.  There will probably be problems because of this,
	because some libcs are unhappy about freeing NULL pointers; the
	code in GNATS should be fixed instead of using a wrapper.
	
	gnatsd.conf is now renamed to gnatsd.host_access; a slightly more
	descriptive name.  It also uses the adm.c routines for reading.
	
	Most of delete-pr is in pr-edit now; delete-pr still handles
	deleting all closed PRs.
	
	Most of the scripts have been fixed.  Some of them are almost
	certainly still busted.  Scripts that still directly refer to
	files are (mostly) \hbadness 10000 and need to be fixed.  None
	of the scripts should be manipulating PRs or the index file
	directly.  I know that check-db is massively not working
	right now.
	
	edit-pr is kind of suckage right now, but it should still
	work.  It still knows about which fields need to have
	audit-trail entries added; I had planned on fixing this
	for 4.0, but it won't happen.  Most of the functionality is
	actually in the server, except for sending mail when changes
	occur.
	
	The "site" functionality has been removed.  It never was implemented
	very well or thoroughly.  Something similar may be reimplemented,
	but not in 4.0.
	
	This is likely the last major set of changes before 4.0 beta
	is released.  The only planned changes are to filenames, and
	of course the major associated documentation cleanups.  I
	also need to track down memory leaks, tho given the nature of
	the programs involved this actually isn't all that crucial.
	
	Gah.

gnats/gnats ChangeLog Makefile.in adm.c adm.h ...

[bmanson]

CVSROOT:	/cvs/gnats
Module name:	gnats
Changes by:	bmanson@sourceware.cygnus.com	00/01/26 16:21:47

Modified files:
	gnats          : ChangeLog Makefile.in adm.c adm.h client.c 
	                 cmds.c config.h database.c database.h edit.c 
	                 fconfig.y fconfigl.l field-config.in field.c 
	                 field.h file-pr.c gen-closed-date.c gen-index.c 
	                 getclose.c gnats.h gnatsd.c gnatsd.h index.c 
	                 index.h internal.c lists.c mail.c mail.h misc.c 
	                 pr-age.c pr-edit.c pr-init.c pr-stat.c pr.c 
	                 pr.h query-pr.c query.c query.h queue-pr.c 
Removed files:
	gnats          : pathmax.h 

Log message:
	* Remove all line length limits.  Change the error handling to be
	much cleaner; remove all calls to punt() from library code.  Use
	asprintf() extensively.
	
	* internal.c (fileExists): New function.
	
	* gnatsd.c (serverMainLoop): New function; move most of
	the code out of main().  Don't call exit() here.
	
	* fconfig.y: Remove index-field-is-optional.
	
	* gnatsd.c (gnatsd_argify): Restructure. Don't needlessly allocate
	4x the length of the line.  (Read: rewrite really crappy code.)
	
	* index.c (format_field): Don't fail if the date is invalid; put a
	0 in the index instead.
	
	* config.h: Delete STR_MAX et al.
	
	* pathmax.h: Deleted, no longer used.

gnats/gnats ChangeLog Makefile.in adm.c adm.h ...

[bmanson]

CVSROOT:	/cvs/gnats
Module name:	gnats
Changes by:	bmanson@sourceware.cygnus.com	00/01/13 23:32:47

Modified files:
	gnats          : ChangeLog Makefile.in adm.c adm.h check-db.sh 
	                 client.c cmds.c config.h configure configure.in 
	                 database.c database.h delete-pr.sh edit-pr.sh 
	                 edit.c fconfig.y fconfigl.l field-config.in 
	                 field.h file-pr.c files.c files.h 
	                 gen-closed-date.c getclose.c gnats.h gnatsd.c 
	                 gnatsd.h index.c index.h internal.c mail.c 
	                 misc.c pr-edit.c pr-init.c pr.c pr.h query-pr.c 
	                 query.c query.h responsible 
Added files:
	gnats          : diff-prs mail.h 

Log message:
	* pr.c (getFieldFlags): New function.
	(read_header): Fix problem with overwriting array boundaries,
	and make sure the header value has a terminating NUL.
	
	* gnatsd.c (freeArgs): New function.
	(main): Restructure a bit; make sure we're freeing up the arguments
	we parse.
	
	* field.h (struct field_def): Add requireChangeReason flag.
	(The flags should probably be collapsed into a single bitfield.)
	
	* misc.c (init_gnats): Call clearCurrDatabase ().
	
	* database.c: Encapsulate the database state into a struct
	(tho there are still static variables scattered throughout
	the code).
	(clearCurrDatabase): New function.
	
	* configure.in: Did some remaining cleanup; deleted several
	unused options.
	
	* cmds.c (GNATS_fieldflags): New function.
	
	* client.c (netFieldFlags): New function.
	
	* query-pr.c (long_options): Add --field-flags option.
	
	* edit-pr.sh: Use diff-prs; ask about fields that require a
	reason for change, if they've changed.
	
	* diff-prs: New script to list the fields that have changed
	between two PRs.
	
	* delete-pr.sh: Don't send mail about deleted PRs--the server does
	it now.
	
	* Makefile.in, configure.in: Deleted GNATS_ADMIN; it's now wired
	to gnats-admin. (To change gnats-admin's mail address, change it
	in the responsible file.)
	
	* config.h: Delete INDEX define, no longer used.
	
	* index.c: Use the "path" entry in the index descriptor.
	(build_index_entry): Fix index allocation code.
	(free_pr_index): Free the individual field entries if we didn't
	allocate them with a buffer.
	
	* query.c: Change the funny '[' and '%' designators to real words
	(builtinfield: and fieldtype: respectively).  Use FieldList
	instead of FieldIndex for referring to which fields to search;
	this makes it possible to do even more interesting queries.
	Remove the FieldType search ('#' operator), it's no longer needed.
	
	* files.c: Delete a bunch of unused functions.
	
	* query.c (append_string, append_char, do_print): New function.
	(format_pr_field, process_printf_format, process_format): Add the
	ability to produce output into a char* instead of a FILE pointer.
	(allocateNamedParameter, getNamedParameterValue,
	freeFormatParameterList):  New functions, for supporting parameters
	to format statements.
	
	* pr.c (get_field_value): Add PARAMS argument, for format
	parameters.
	
	* edit.c: Add parameters for the email address of the user performing
	the various edit actions.
	(addAuditTrailEnt, sendAuditMail): New functions.
	
	* edit-pr.sh: Simplify--the server now takes care of Audit-Trail:
	entries and sending email for edits.
	
	* cmds.c: Add editEmailAddr static variable (this belongs
	somewhere else...)
	(GNATS_user): Use get_responsible_addr () to set a default edit
	email address for the user.
	(GNATS_editaddr): New function.
	
	* client.c (netSetEditEmailAddr): New function.
	(netEditField): Set the email address of the editing user before
	doing the edit.
	(netModifyPR): Ditto.
	
	* database.c (setAuditTrailFormat, getAuditTrailFormat): New
	functions.
	
	Gack.  This is way too much to check in at once.
	
	Adds formatted mail and audit-trail support.  Fixes several memory
	leaks as well.  (The three checkers I've been using claim there aren't
	any more leaks for the limited testing I've done...I'm sure there are
	more waiting.)

gnats/gnats ChangeLog Makefile.in adm.c adm.h ...

[bmanson]

CVSROOT:	/cvs/gnats
Module name:	gnats
Changes by:	bmanson@sourceware.cygnus.com	99/12/29 17:29:37

Modified files:
	gnats          : ChangeLog Makefile.in adm.c adm.h client.c 
	                 cmds.c config.h configure configure.in 
	                 database.c edit.c file-pr.c gen-closed-date.c 
	                 gen-index.c getclose.c globals.h gnats.h 
	                 gnatsd.c gnatsd.h internal.c lists.c mkdb.sh 
	                 npr-edit.c pr-age.c pr-edit.c pr-init.c 
	                 pr-stat.c pr.c query-pr.c query.c queue-pr.c 
Removed files:
	gnats          : npr-addr.c pr-addr.c pr-mail.c sub-type.c 

Log message:
	* query.c: Added support for parsing FieldType operator (assigned
	to '#'); needed for checking for closed PRs.
	
	* query-pr.c: Added new options --adm-field, --adm-subfield and
	--adm-key.
	(main): Default username and password are now NULL.
	
	* pr-stat.c: Minor fixes; it's still pretty badly broken.  Not sure
	if it's worth fixing.
	
	* npr-edit.c (main): Default username and password are NULL now.
	
	* lists.c (getGnatsFile): Fixed erroneous fallthrough to abort ().
	
	* internal.c (gnatsdbHasNetconn): New function.
	
	* edit.c (validateFieldValue): New function.
	(check_pr): Massively simplified; uses validateFieldValue ().
	(edit_field): Use validateFieldValue ().
	
	* database.c (getHostList): Add a call to initHostList ().
	
	* cmds.c(GNATS_mlct, GNATS_mlsu, GNATS_mlrs, GNATS_type,
	GNATS_resp, GNATS_catg, GNATS_vdat, GNATS_nocl): Deleted.
	(GNATS_admv, GNATS_vfld, GNATS_expr): New functions.
	
	* client.c (client_get_field_config): Use sendRemoteListQuery ().
	(sendRemoteQuery): Send a string expression with the EXPR command
	instead of sending individual nodes.
	(send_query_field, send_query_node): Deleted.
	(clientGetAdmField): New function.
	
	* adm.c (printAdmSubfield): New function.
	
	* file-pr.c (create_new_pr_file): Replaced sole use of PENDING
	with defaultCategory ().
	
	* sub-type.c, pr-addr.c, pr-mail.c, npr-addr.c: Deleted;
	functionality added to query-pr.
	
	* Replaced --directory options with --database, and edited usage
	strings to match.
	
	* configure.in: Changed with-gnatsd-access-file to
	with-gnatsd-user-access-file.  Added with-gnatsd-host-access-file.
	Moved the gnatsd.host_access file into ${datadir}/gnats; there
	should probably be a per-database version as well, but I'm too lazy
	to add it.