public inbox for gnats-devel@sourceware.org
 help / color / mirror / Atom feed
From: "Mark D. Baushke" <mdb@gnu.org>
To: Mel Hatzis <hatzis@juniper.net>
Cc: help-gnats@gnu.org
Subject: Re: using GNATS with xemacs
Date: Sat, 11 Oct 2003 18:06:00 -0000	[thread overview]
Message-ID: <77212.1065895424@juniper.net> (raw)
In-Reply-To: Mail from Mel Hatzis <hatzis@juniper.net>  dated Fri, 10 Oct 2003 18:41:29 PDT <3F875FC9.4010404@juniper.net>

Mel Hatzis <hatzis@juniper.net> writes:

> Please review the attached patch which fixes a bug
> in the gnats.el file, allowing it to be used with
> xemacs.

Yes, XEmacs has a character type that is separate from an integer type
such that

     (eq 10 (char-to-int ?\n))

is t. 

As GNU Emacs does not have a char-to-int function, Mel's patch seems
reasonable to me to allow both GNU Emacs and XEmacs to use the same
gnats.el file.

I urge adoption of this patch.

	Thanks,
	-- Mark
     
> 
> Currently, if you attempt to use the gnats.el
> functionality with xemacs nothing works because
> every attempt to read the server response is
> failing.
> 
> --
> Mel Hatzis
> --- gnats.el~	6 Dec 2002 10:32:58 -0000	1.1.1.1
> +++ gnats.el	11 Oct 2003 01:09:57 -0000
> @@ -1197,7 +1197,7 @@ gnats-server-conn's `parsed-output' prop
>  parsed, the `output-complete' property is set."
>    (put gnats-server-conn 'curr-output
>         (concat (get gnats-server-conn 'curr-output) output))
> -  (if (eq 10 (string-to-char (substring output -1)))
> +  (if (eq ?\n (string-to-char (substring output -1)))
>        (progn
>  	(gnats-debug-string (get gnats-server-conn 'curr-output))
>  	(let ((our-output (get gnats-server-conn 'curr-output)))


_______________________________________________
Help-gnats mailing list
Help-gnats@gnu.org
http://mail.gnu.org/mailman/listinfo/help-gnats

      reply	other threads:[~2003-10-11 18:06 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2003-10-11  1:43 Mel Hatzis
2003-10-11 18:06 ` Mark D. Baushke [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=77212.1065895424@juniper.net \
    --to=mdb@gnu.org \
    --cc=hatzis@juniper.net \
    --cc=help-gnats@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).