using GNATS with xemacs

using GNATS with xemacs

[Mel Hatzis]

[-- Attachment #1: Type: text/plain, Size: 273 bytes --]

Please review the attached patch which fixes a bug
in the gnats.el file, allowing it to be used with
xemacs.

Currently, if you attempt to use the gnats.el
functionality with xemacs nothing works because
every attempt to read the server response is
failing.

--
Mel Hatzis

[-- Attachment #2: gnats.el.1.patch --]
[-- Type: text/plain, Size: 543 bytes --]

--- gnats.el~	6 Dec 2002 10:32:58 -0000	1.1.1.1
+++ gnats.el	11 Oct 2003 01:09:57 -0000
@@ -1197,7 +1197,7 @@ gnats-server-conn's `parsed-output' prop
 parsed, the `output-complete' property is set."
   (put gnats-server-conn 'curr-output
        (concat (get gnats-server-conn 'curr-output) output))
-  (if (eq 10 (string-to-char (substring output -1)))
+  (if (eq ?\n (string-to-char (substring output -1)))
       (progn
 	(gnats-debug-string (get gnats-server-conn 'curr-output))
 	(let ((our-output (get gnats-server-conn 'curr-output)))

[-- Attachment #3: Type: text/plain, Size: 139 bytes --]

_______________________________________________
Help-gnats mailing list
Help-gnats@gnu.org
http://mail.gnu.org/mailman/listinfo/help-gnats

Re: using GNATS with xemacs

[Mark D. Baushke]

Mel Hatzis <hatzis@juniper.net> writes:

> Please review the attached patch which fixes a bug
> in the gnats.el file, allowing it to be used with
> xemacs.

Yes, XEmacs has a character type that is separate from an integer type
such that

     (eq 10 (char-to-int ?\n))

is t. 

As GNU Emacs does not have a char-to-int function, Mel's patch seems
reasonable to me to allow both GNU Emacs and XEmacs to use the same
gnats.el file.

I urge adoption of this patch.

	Thanks,
	-- Mark
     
> 
> Currently, if you attempt to use the gnats.el
> functionality with xemacs nothing works because
> every attempt to read the server response is
> failing.
> 
> --
> Mel Hatzis
> --- gnats.el~	6 Dec 2002 10:32:58 -0000	1.1.1.1
> +++ gnats.el	11 Oct 2003 01:09:57 -0000
> @@ -1197,7 +1197,7 @@ gnats-server-conn's `parsed-output' prop
>  parsed, the `output-complete' property is set."
>    (put gnats-server-conn 'curr-output
>         (concat (get gnats-server-conn 'curr-output) output))
> -  (if (eq 10 (string-to-char (substring output -1)))
> +  (if (eq ?\n (string-to-char (substring output -1)))
>        (progn
>  	(gnats-debug-string (get gnats-server-conn 'curr-output))
>  	(let ((our-output (get gnats-server-conn 'curr-output)))


_______________________________________________
Help-gnats mailing list
Help-gnats@gnu.org
http://mail.gnu.org/mailman/listinfo/help-gnats