[RFA] gdbtk/library/regwin.itb: add unsigned register display option

[RFA] gdbtk/library/regwin.itb: add unsigned register display option

[Nick Duffek]

Hi,

Some users have requested the option to display registers in unsigned
decimal format, for symmetry with the CLI's print/u option.

gdbtk/ChangeLog:

	* library/regwin.itb (RegWin::build_win): Add radio button
	for unsigned register format.
	(RegWin::reg_select): Iterate through 8 rather than 7 formats.
	(RegWin::but3): Add menu option for unsigned register format.

Okay to apply?

Nick Duffek
<nsd@redhat.com>

[patch follows]

Index: gdb/gdbtk/library/regwin.itb
===================================================================
diff -up gdb/gdbtk/library/regwin.itb gdb/gdbtk/library/regwin.itb
--- gdb/gdbtk/library/regwin.itb	Mon Jul 16 13:26:55 2001
+++ gdb/gdbtk/library/regwin.itb	Mon Jul 16 13:26:50 2001
@@ -165,6 +165,8 @@ body RegWin::build_win {} {
       -command "$this update dummy"
     $f add radio -label "Decimal" -value d -underline 0 -state disabled \
       -command "$this update dummy"
+    $f add radio -label "Unsigned" -value u -underline 0 -state disabled \
+      -command "$this update dummy"
     $f add radio -label "Natural" -value {} -underline 0 -state disabled \
       -command "$this update dummy"
     $f add radio -label "Binary" -value t -underline 0 -state disabled \
@@ -355,7 +357,7 @@ body RegWin::reg_select { r } {
     set selected -1
     $itk_interior.m.reg entryconfigure 0 -state disabled
     $itk_interior.m.reg entryconfigure 2 -state disabled
-    for {set i 0} {$i < 7} {incr i} {
+    for {set i 0} {$i < 8} {incr i} {
       $itk_interior.m.reg.format entryconfigure $i -state disabled
     }
     return
@@ -378,7 +380,7 @@ body RegWin::reg_select { r } {
   } else {
     set state normal
   }
-  for {set i 0} {$i < 7} {incr i} {
+  for {set i 0} {$i < 8} {incr i} {
     debug "format $i $state"
     $itk_interior.m.reg.format entryconfigure $i -state $state \
       -variable reg_display($r,format)
@@ -452,6 +454,8 @@ body RegWin::but3 {rn X Y} {
         -value x -variable reg_display($rn,format)
       $Menu add radio -label "Decimal" -command "$this update dummy" \
         -value d -variable reg_display($rn,format)
+      $Menu add radio -label "Unsigned" -command "$this update dummy" \
+        -value u -variable reg_display($rn,format)
       $Menu add radio -label "Natural" -command "$this update dummy" \
         -value {} -variable reg_display($rn,format)
       $Menu add radio -label "Binary" -command "$this update dummy" \

Re: [RFA] gdbtk/library/regwin.itb: add unsigned register displayoption

[Keith Seitz]

On Mon, 16 Jul 2001, Nick Duffek wrote:

> Hi,
>
> Some users have requested the option to display registers in unsigned
> decimal format, for symmetry with the CLI's print/u option.
>
> gdbtk/ChangeLog:
>
> 	* library/regwin.itb (RegWin::build_win): Add radio button
> 	for unsigned register format.
> 	(RegWin::reg_select): Iterate through 8 rather than 7 formats.
> 	(RegWin::but3): Add menu option for unsigned register format.
>
> Okay to apply?

Sure. Just remind me to incorperate it into the tweak that I'm working on
now. This window is too slow/ugly!

:-)
Keith

Re: [RFA] gdbtk/library/regwin.itb: add unsigned register displayoption

[Nick Duffek]

On 16-Jul-2001, Keith Seitz wrote:

>> Okay to apply?
>
>Sure.

Thanks, applied.

>Just remind me to incorperate it into the tweak that I'm working on
>now. This window is too slow/ugly!

Yeah, it lookd pretty inefficient when I was working on it -- the register
list seems to get rebuilt too many times.

Nick