* [RFA] gdbtk/library/regwin.itb: add unsigned register display option
@ 2001-07-16 10:32 Nick Duffek
2001-07-16 10:38 ` [RFA] gdbtk/library/regwin.itb: add unsigned register displayoption Keith Seitz
0 siblings, 1 reply; 3+ messages in thread
From: Nick Duffek @ 2001-07-16 10:32 UTC (permalink / raw)
To: insight
Hi,
Some users have requested the option to display registers in unsigned
decimal format, for symmetry with the CLI's print/u option.
gdbtk/ChangeLog:
* library/regwin.itb (RegWin::build_win): Add radio button
for unsigned register format.
(RegWin::reg_select): Iterate through 8 rather than 7 formats.
(RegWin::but3): Add menu option for unsigned register format.
Okay to apply?
Nick Duffek
<nsd@redhat.com>
[patch follows]
Index: gdb/gdbtk/library/regwin.itb
===================================================================
diff -up gdb/gdbtk/library/regwin.itb gdb/gdbtk/library/regwin.itb
--- gdb/gdbtk/library/regwin.itb Mon Jul 16 13:26:55 2001
+++ gdb/gdbtk/library/regwin.itb Mon Jul 16 13:26:50 2001
@@ -165,6 +165,8 @@ body RegWin::build_win {} {
-command "$this update dummy"
$f add radio -label "Decimal" -value d -underline 0 -state disabled \
-command "$this update dummy"
+ $f add radio -label "Unsigned" -value u -underline 0 -state disabled \
+ -command "$this update dummy"
$f add radio -label "Natural" -value {} -underline 0 -state disabled \
-command "$this update dummy"
$f add radio -label "Binary" -value t -underline 0 -state disabled \
@@ -355,7 +357,7 @@ body RegWin::reg_select { r } {
set selected -1
$itk_interior.m.reg entryconfigure 0 -state disabled
$itk_interior.m.reg entryconfigure 2 -state disabled
- for {set i 0} {$i < 7} {incr i} {
+ for {set i 0} {$i < 8} {incr i} {
$itk_interior.m.reg.format entryconfigure $i -state disabled
}
return
@@ -378,7 +380,7 @@ body RegWin::reg_select { r } {
} else {
set state normal
}
- for {set i 0} {$i < 7} {incr i} {
+ for {set i 0} {$i < 8} {incr i} {
debug "format $i $state"
$itk_interior.m.reg.format entryconfigure $i -state $state \
-variable reg_display($r,format)
@@ -452,6 +454,8 @@ body RegWin::but3 {rn X Y} {
-value x -variable reg_display($rn,format)
$Menu add radio -label "Decimal" -command "$this update dummy" \
-value d -variable reg_display($rn,format)
+ $Menu add radio -label "Unsigned" -command "$this update dummy" \
+ -value u -variable reg_display($rn,format)
$Menu add radio -label "Natural" -command "$this update dummy" \
-value {} -variable reg_display($rn,format)
$Menu add radio -label "Binary" -command "$this update dummy" \
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [RFA] gdbtk/library/regwin.itb: add unsigned register displayoption
2001-07-16 10:32 [RFA] gdbtk/library/regwin.itb: add unsigned register display option Nick Duffek
@ 2001-07-16 10:38 ` Keith Seitz
2001-07-16 11:09 ` Nick Duffek
0 siblings, 1 reply; 3+ messages in thread
From: Keith Seitz @ 2001-07-16 10:38 UTC (permalink / raw)
To: Nick Duffek; +Cc: insight
On Mon, 16 Jul 2001, Nick Duffek wrote:
> Hi,
>
> Some users have requested the option to display registers in unsigned
> decimal format, for symmetry with the CLI's print/u option.
>
> gdbtk/ChangeLog:
>
> * library/regwin.itb (RegWin::build_win): Add radio button
> for unsigned register format.
> (RegWin::reg_select): Iterate through 8 rather than 7 formats.
> (RegWin::but3): Add menu option for unsigned register format.
>
> Okay to apply?
Sure. Just remind me to incorperate it into the tweak that I'm working on
now. This window is too slow/ugly!
:-)
Keith
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [RFA] gdbtk/library/regwin.itb: add unsigned register displayoption
2001-07-16 10:38 ` [RFA] gdbtk/library/regwin.itb: add unsigned register displayoption Keith Seitz
@ 2001-07-16 11:09 ` Nick Duffek
0 siblings, 0 replies; 3+ messages in thread
From: Nick Duffek @ 2001-07-16 11:09 UTC (permalink / raw)
To: keiths; +Cc: insight
On 16-Jul-2001, Keith Seitz wrote:
>> Okay to apply?
>
>Sure.
Thanks, applied.
>Just remind me to incorperate it into the tweak that I'm working on
>now. This window is too slow/ugly!
Yeah, it lookd pretty inefficient when I was working on it -- the register
list seems to get rebuilt too many times.
Nick
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2001-07-16 11:09 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2001-07-16 10:32 [RFA] gdbtk/library/regwin.itb: add unsigned register display option Nick Duffek
2001-07-16 10:38 ` [RFA] gdbtk/library/regwin.itb: add unsigned register displayoption Keith Seitz
2001-07-16 11:09 ` Nick Duffek
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).