* [patch] Missing newline
@ 2001-10-05 17:00 Andrew Cagney
2001-10-05 17:41 ` Martin M. Hunt
2001-11-30 15:05 ` Andrew Cagney
0 siblings, 2 replies; 4+ messages in thread
From: Andrew Cagney @ 2001-10-05 17:00 UTC (permalink / raw)
To: insight
[-- Attachment #1: Type: text/plain, Size: 59 bytes --]
FYI,
I checked in the attached as obvious.
enjoy,
Andrew
[-- Attachment #2: diffs --]
[-- Type: text/plain, Size: 689 bytes --]
Fri Nov 30 17:57:55 2001 Andrew Cagney <cagney@redhat.com>
* library/interface.tcl: Add missing newline.
Index: library/interface.tcl
===================================================================
RCS file: /cvs/src/src/gdb/gdbtk/library/interface.tcl,v
retrieving revision 1.33
diff -p -r1.33 interface.tcl
*** interface.tcl 2001/11/22 00:26:12 1.33
--- interface.tcl 2001/11/30 22:59:29
*************** proc gdbtk_eval {exp} {
*** 1784,1787 ****
set val [string trimright $val "\n"]
debug "returning \"$val\""
return $val
! }
\ No newline at end of file
--- 1784,1787 ----
set val [string trimright $val "\n"]
debug "returning \"$val\""
return $val
! }
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [patch] Missing newline
2001-10-05 17:00 [patch] Missing newline Andrew Cagney
@ 2001-10-05 17:41 ` Martin M. Hunt
2001-11-30 15:36 ` Martin M. Hunt
2001-11-30 15:05 ` Andrew Cagney
1 sibling, 1 reply; 4+ messages in thread
From: Martin M. Hunt @ 2001-10-05 17:41 UTC (permalink / raw)
To: Andrew Cagney, insight
On Friday 30 November 2001 03:05 pm, Andrew Cagney wrote:
> FYI,
>
> I checked in the attached as obvious.
>
> enjoy,
> Andrew
What isn't obvious is how I checked in that last function accidently.
I am removing the unapproved and unused function.
2001-11-30 Martin M. Hunt <hunt@redhat.com>
* library/interface.tcl (gdbtk_eval): Remove
undocumented debug function.
Index: library/interface.tcl
===================================================================
RCS file: /cvs/src/src/gdb/gdbtk/library/interface.tcl,v
retrieving revision 1.33
retrieving revision 1.34
diff -u -p -r1.33 -r1.34
--- interface.tcl 2001/11/22 00:26:12 1.33
+++ interface.tcl 2001/11/30 23:31:15 1.34
@@ -1767,21 +1767,3 @@ proc gdbtk_tcl_architecture_changed {} {
GDBEventHandler::dispatch $e
delete object $e
}
-
-proc gdbtk_eval {exp} {
- debug $exp
- set ret [catch {gdb_cmd "p/x $exp"} val]
- if {$ret} {
- return ""
- }
-
- debug "val=\"$val\""
- # response looks like "$1 = value\n"
- set ind [string first "=" $val]
- if { $ind == -1 } { return "" }
- set val [string range $val [expr $ind + 1] [string length $val]]
- set val [string trimleft $val]
- set val [string trimright $val "\n"]
- debug "returning \"$val\""
- return $val
-}
\ No newline at end of file
--
Martin Hunt
GDB Engineer
Red Hat, Inc.
^ permalink raw reply [flat|nested] 4+ messages in thread
* [patch] Missing newline
2001-10-05 17:00 [patch] Missing newline Andrew Cagney
2001-10-05 17:41 ` Martin M. Hunt
@ 2001-11-30 15:05 ` Andrew Cagney
1 sibling, 0 replies; 4+ messages in thread
From: Andrew Cagney @ 2001-11-30 15:05 UTC (permalink / raw)
To: insight
FYI,
I checked in the attached as obvious.
enjoy,
Andrew
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [patch] Missing newline
2001-10-05 17:41 ` Martin M. Hunt
@ 2001-11-30 15:36 ` Martin M. Hunt
0 siblings, 0 replies; 4+ messages in thread
From: Martin M. Hunt @ 2001-11-30 15:36 UTC (permalink / raw)
To: Andrew Cagney, insight
On Friday 30 November 2001 03:05 pm, Andrew Cagney wrote:
> FYI,
>
> I checked in the attached as obvious.
>
> enjoy,
> Andrew
What isn't obvious is how I checked in that last function accidently.
I am removing the unapproved and unused function.
2001-11-30 Martin M. Hunt <hunt@redhat.com>
* library/interface.tcl (gdbtk_eval): Remove
undocumented debug function.
Index: library/interface.tcl
===================================================================
RCS file: /cvs/src/src/gdb/gdbtk/library/interface.tcl,v
retrieving revision 1.33
retrieving revision 1.34
diff -u -p -r1.33 -r1.34
--- interface.tcl 2001/11/22 00:26:12 1.33
+++ interface.tcl 2001/11/30 23:31:15 1.34
@@ -1767,21 +1767,3 @@ proc gdbtk_tcl_architecture_changed {} {
GDBEventHandler::dispatch $e
delete object $e
}
-
-proc gdbtk_eval {exp} {
- debug $exp
- set ret [catch {gdb_cmd "p/x $exp"} val]
- if {$ret} {
- return ""
- }
-
- debug "val=\"$val\""
- # response looks like "$1 = value\n"
- set ind [string first "=" $val]
- if { $ind == -1 } { return "" }
- set val [string range $val [expr $ind + 1] [string length $val]]
- set val [string trimleft $val]
- set val [string trimright $val "\n"]
- debug "returning \"$val\""
- return $val
-}
\ No newline at end of file
--
Martin Hunt
GDB Engineer
Red Hat, Inc.
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2001-11-30 23:36 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2001-10-05 17:00 [patch] Missing newline Andrew Cagney
2001-10-05 17:41 ` Martin M. Hunt
2001-11-30 15:36 ` Martin M. Hunt
2001-11-30 15:05 ` Andrew Cagney
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).