* [RFA] breakpoint balloon info
@ 2002-03-07 0:28 Martin M. Hunt
2002-03-07 10:43 ` Keith Seitz
0 siblings, 1 reply; 3+ messages in thread
From: Martin M. Hunt @ 2002-03-07 0:28 UTC (permalink / raw)
To: Insight Mailing List
I added information about ignore count, conditions, and commands
to the breakpoint balloon help in the source window.
--
Martin Hunt
GDB Engineer
Red Hat, Inc.
2002-03-06 Martin M. Hunt <hunt@redhat.com>
* library/srctextwin.itb (SrcTextWin::showBPBalloon):
Reformat output. Add conditions, ignore count, commands.
Index: srctextwin.itb
===================================================================
RCS file: /cvs/src/src/gdb/gdbtk/library/srctextwin.itb,v
retrieving revision 1.32
diff -u -p -r1.32 srctextwin.itb
--- srctextwin.itb 2002/03/05 22:22:20 1.32
+++ srctextwin.itb 2002/03/07 08:25:09
@@ -2310,27 +2310,36 @@ body SrcTextWin::showBPBalloon {win x y}
}
set str ""
- set need_lf 0
foreach b $bps {
set bpinfo [gdb_get_breakpoint_info $b]
lassign $bpinfo file func linenum addr type enabled disposition \
ignore_count commands cond thread hit_count user_specification
- if {$thread == "-1"} {set thread "all"}
set file [lindex [file split $file] end]
if {$enabled} {
set enabled "ENA"
} else {
set enabled "DIS"
}
- if {$cond == ""} {set cond "none"}
- if {$need_lf} {
- append str \n
- } else {
- set need_lf 1
+
+ append str [format "breakpoint %d at %s:%d (%#x)\n %s %s %s" \
+ $b $file $linenum $addr $enabled $type $disposition]
+
+ if {$thread != "-1"} {
+ append str "\n threads: $thread"
+ }
+
+ if {$ignore_count != 0} {
+ append str "\n ignore: $ignore_count"
+ }
+
+ if {$cond != ""} {
+ append str "\n condition: $cond"
+ }
+
+ if {$commands != ""} {
+ append str "\n commands: $commands"
}
- append str [format "breakpoint %d at %s:%d (%#x)\n\t%s %s %s %s %s" \
- $b $file $linenum $addr $enabled $type $disposition \
- threads=$thread cond=$cond]
+
}
# Scope out which break type is set here, and use the tag to get
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [RFA] breakpoint balloon info
2002-03-07 0:28 [RFA] breakpoint balloon info Martin M. Hunt
@ 2002-03-07 10:43 ` Keith Seitz
2002-03-07 12:25 ` Martin M. Hunt
0 siblings, 1 reply; 3+ messages in thread
From: Keith Seitz @ 2002-03-07 10:43 UTC (permalink / raw)
To: Martin M. Hunt; +Cc: Insight Mailing List
On Thu, 7 Mar 2002, Martin M. Hunt wrote:
> 2002-03-06 Martin M. Hunt <hunt@redhat.com>
>
> * library/srctextwin.itb (SrcTextWin::showBPBalloon):
> Reformat output. Add conditions, ignore count, commands.
Don't we need to be a little careful about commands? They could be huge...
Anyway, it all looks innocent enough. Does any of this break the srcwin
tests, by chance? I know we test something about BP balloons in there.
Please commit. Thanks,
Keith
> Index: srctextwin.itb
> ===================================================================
> RCS file: /cvs/src/src/gdb/gdbtk/library/srctextwin.itb,v
> retrieving revision 1.32
> diff -u -p -r1.32 srctextwin.itb
> --- srctextwin.itb 2002/03/05 22:22:20 1.32
> +++ srctextwin.itb 2002/03/07 08:25:09
> @@ -2310,27 +2310,36 @@ body SrcTextWin::showBPBalloon {win x y}
> }
>
> set str ""
> - set need_lf 0
> foreach b $bps {
> set bpinfo [gdb_get_breakpoint_info $b]
> lassign $bpinfo file func linenum addr type enabled disposition \
> ignore_count commands cond thread hit_count user_specification
> - if {$thread == "-1"} {set thread "all"}
> set file [lindex [file split $file] end]
> if {$enabled} {
> set enabled "ENA"
> } else {
> set enabled "DIS"
> }
> - if {$cond == ""} {set cond "none"}
> - if {$need_lf} {
> - append str \n
> - } else {
> - set need_lf 1
> +
> + append str [format "breakpoint %d at %s:%d (%#x)\n %s %s %s" \
> + $b $file $linenum $addr $enabled $type $disposition]
> +
> + if {$thread != "-1"} {
> + append str "\n threads: $thread"
> + }
> +
> + if {$ignore_count != 0} {
> + append str "\n ignore: $ignore_count"
> + }
> +
> + if {$cond != ""} {
> + append str "\n condition: $cond"
> + }
> +
> + if {$commands != ""} {
> + append str "\n commands: $commands"
> }
> - append str [format "breakpoint %d at %s:%d (%#x)\n\t%s %s %s %s %s" \
> - $b $file $linenum $addr $enabled $type $disposition \
> - threads=$thread cond=$cond]
> +
> }
>
> # Scope out which break type is set here, and use the tag to get
>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [RFA] breakpoint balloon info
2002-03-07 10:43 ` Keith Seitz
@ 2002-03-07 12:25 ` Martin M. Hunt
0 siblings, 0 replies; 3+ messages in thread
From: Martin M. Hunt @ 2002-03-07 12:25 UTC (permalink / raw)
To: Keith Seitz; +Cc: Insight Mailing List
On Thursday 07 March 2002 10:43 am, Keith Seitz wrote:
> On Thu, 7 Mar 2002, Martin M. Hunt wrote:
> > 2002-03-06 Martin M. Hunt <hunt@redhat.com>
> >
> > * library/srctextwin.itb (SrcTextWin::showBPBalloon):
> > Reformat output. Add conditions, ignore count, commands.
>
> Don't we need to be a little careful about commands? They could be huge...
I adjusted the final patch to take this into account then checked it in.
--
Martin Hunt
GDB Engineer
Red Hat, Inc.
Index: library/srctextwin.itb
===================================================================
RCS file: /cvs/src/src/gdb/gdbtk/library/srctextwin.itb,v
retrieving revision 1.32
diff -u -p -r1.32 srctextwin.itb
--- srctextwin.itb 2002/03/05 22:22:20 1.32
+++ srctextwin.itb 2002/03/07 20:21:49
@@ -2310,27 +2310,39 @@ body SrcTextWin::showBPBalloon {win x y}
}
set str ""
- set need_lf 0
foreach b $bps {
set bpinfo [gdb_get_breakpoint_info $b]
lassign $bpinfo file func linenum addr type enabled disposition \
ignore_count commands cond thread hit_count user_specification
- if {$thread == "-1"} {set thread "all"}
set file [lindex [file split $file] end]
if {$enabled} {
set enabled "ENA"
} else {
set enabled "DIS"
}
- if {$cond == ""} {set cond "none"}
- if {$need_lf} {
- append str \n
- } else {
- set need_lf 1
+
+ append str [format "breakpoint %d at %s:%d (%#x)\n %s %s %s" \
+ $b $file $linenum $addr $enabled $type $disposition]
+
+ if {$thread != "-1"} {
+ append str "\n threads: $thread"
+ }
+
+ if {$ignore_count != 0} {
+ append str "\n ignore: $ignore_count"
+ }
+
+ if {$cond != ""} {
+ append str "\n condition: $cond"
+ }
+
+ if {$commands != ""} {
+ if {[string length $commands] > 50} {
+ append str "\n commands: [string range $commands 0 50] ..."
+ } else {
+ append str "\n commands: $commands"
+ }
}
- append str [format "breakpoint %d at %s:%d (%#x)\n\t%s %s %s %s %s" \
- $b $file $linenum $addr $enabled $type $disposition \
- threads=$thread cond=$cond]
}
# Scope out which break type is set here, and use the tag to get
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2002-03-07 20:25 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2002-03-07 0:28 [RFA] breakpoint balloon info Martin M. Hunt
2002-03-07 10:43 ` Keith Seitz
2002-03-07 12:25 ` Martin M. Hunt
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).