From: "Christian Biesinger via insight" <insight@sourceware.org>
To: insight@sourceware.org
Cc: Christian Biesinger <cbiesinger@chromium.org>
Subject: [PATCH] Add declarations to gdbtk.h
Date: Mon, 07 Oct 2019 21:09:00 -0000 [thread overview]
Message-ID: <20191007210928.239798-1-cbiesinger@google.com> (raw)
From: Christian Biesinger <cbiesinger@chromium.org>
Currently, gdb/main.c has to declare these two variables in the
.c file. This patch adds the declarations to the header so that
gdb can just use them.
gdbtk/ChangeLog:
2019-10-07 Christian Biesinger <cbiesinger@chromium.org>
* generic/gdbtk.h (gdbtk_test): Declare.
(external_editor_command): Declare.
(file): Prefix Tcl_Interp with "struct"
so that this compiles when Tcl headers aren't included.
* generic/gdbtk-interp.h: Likewise.
---
gdbtk/generic/gdbtk-interp.h | 2 +-
gdbtk/generic/gdbtk.h | 11 +++++++++--
2 files changed, 10 insertions(+), 3 deletions(-)
diff --git a/gdbtk/generic/gdbtk-interp.h b/gdbtk/generic/gdbtk-interp.h
index 3126b91..9abad2e 100644
--- a/gdbtk/generic/gdbtk-interp.h
+++ b/gdbtk/generic/gdbtk-interp.h
@@ -53,7 +53,7 @@ public:
ui_file *_stdtargin;
ui_out *uiout;
- Tcl_Interp *tcl;
+ struct Tcl_Interp *tcl;
};
extern gdbtk_interp *gdbtk_get_interp (void);
diff --git a/gdbtk/generic/gdbtk.h b/gdbtk/generic/gdbtk.h
index 7bb1f79..89ab8bf 100644
--- a/gdbtk/generic/gdbtk.h
+++ b/gdbtk/generic/gdbtk.h
@@ -77,6 +77,12 @@ extern int running_now;
extern long gdbtk_pid;
+/*
+ * This variable controls the interaction with an external editor.
+ */
+
+extern char *external_editor_command;
+
/* These two control how the GUI behaves when tracing or loading
They are defined in gdbtk-cmds.c */
@@ -91,7 +97,7 @@ extern int load_in_progress;
typedef struct gdbtk_result
{
- Tcl_Obj *obj_ptr; /* This will eventually be copied over to the
+ struct Tcl_Obj *obj_ptr; /* This will eventually be copied over to the
Tcl result */
int flags; /* Flag vector to control how the result is
used. */
@@ -151,7 +157,7 @@ extern int gdbtk_force_detach;
*
*/
-extern int Gdbtk_Init (Tcl_Interp * interp);
+extern int Gdbtk_Init (struct Tcl_Interp * interp);
extern void gdbtk_stop_timer (void);
extern void gdbtk_start_timer (void);
extern long gdbtk_getpid(void);
@@ -159,6 +165,7 @@ extern void gdbtk_ignorable_warning (const char *, const char *);
extern int x_event (int);
extern int gdbtk_two_elem_cmd (char *, const char *);
extern int target_is_native (struct target_ops *t);
+extern int gdbtk_test (char *);
extern struct ui_file *gdbtk_fileopen (void);
extern bool gdbtk_disable_write;
extern ptid_t gdbtk_get_ptid (void);
--
2.23.0.581.g78d2f28ef7-goog
next reply other threads:[~2019-10-07 21:09 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-07 21:09 Christian Biesinger via insight [this message]
2019-10-07 22:40 ` Mike Wellington
2019-10-07 22:43 ` Christian Biesinger via insight
2019-10-07 22:48 ` Mike Wellington
2019-10-10 0:20 ` Keith Seitz
2019-10-10 0:35 ` Christian Biesinger via insight
2019-10-10 15:55 ` Keith Seitz
2019-10-10 17:47 ` Christian Biesinger via insight
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191007210928.239798-1-cbiesinger@google.com \
--to=insight@sourceware.org \
--cc=cbiesinger@chromium.org \
--cc=cbiesinger@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).