20010807 won't compile for target=arm-elf

20010807 won't compile for target=arm-elf

[Grant Edwards]

gdbtk/generic/gdbtk-bp.c doesn't seem to compile for an arm-elf
target. On a RH6.2 system, untar insight+dejagnu-20010807 then:

 $ ./configure target=arm-elf
 $ make
 
 [...]
 
 gcc -c -g -O2    -I. -I. -I./config -DHAVE_CONFIG_H -I./../include/opcode -I./../readline/.. -I../bfd -I./../bfd  -I./../include -I../intl -     I./../intl  -DMI_OUT=1 -DGDBTK -DUI_OUT=1 -Wimplicit -Wreturn-type -Wcomment -Wtrigraphs -Wformat -Wparentheses -Wpointer-arith -Wuninitiali     zed  -I./../libgui/src  -I/home/grante/insight+dejagnu-20010807/itcl/itcl/generic \
        -I/home/grante/insight+dejagnu-20010807/itcl/itk/generic -I/home/grante/insight+dejagnu-20010807/tix/generic \
-I/home/grante/insight+dejagnu-20010807/tcl/generic -I/home/grante/insight+dejagnu-20010807/tk/generic -I/home/grante/insight+dejagnu-200108     07/tk/generic -I/usr/X11R6/include \
        ./gdbtk/generic/gdbtk.c -DGDBTK_LIBRARY=\"/usr/local/share/gdbtcl\"
gcc -c -g -O2    -I. -I. -I./config -DHAVE_CONFIG_H -I./../include/opcode -I./../readline/.. -I../bfd -I./../bfd  -I./../include -I../intl -     I./../intl  -DMI_OUT=1 -DGDBTK -DUI_OUT=1 -Wimplicit -Wreturn-type -Wcomment -Wtrigraphs -Wformat -Wparentheses -Wpointer-arith -Wuninitiali     zed  -I./../libgui/src  -I/home/grante/insight+dejagnu-20010807/itcl/itcl/generic \
-I/home/grante/insight+dejagnu-20010807/tix/generic -I/home/grante/insight+dejagnu-20010807/tcl/generic -I/home/grante/insight+dejagnu-20010     807/tk/generic -I/home/grante/insight+dejagnu-20010807/tk/generic -I/usr/X11R6/include   \
 ./gdbtk/generic/gdbtk-bp.c \
-DGDBTK_LIBRARY=\"/usr/local/share/gdbtcl\"
./gdbtk/generic/gdbtk-bp.c: In function `gdb_get_breakpoint_info':
./gdbtk/generic/gdbtk-bp.c:346: structure has no member named `enable'
./gdbtk/generic/gdbtk-bp.c:346: `enabled' undeclared (first use in this function)
./gdbtk/generic/gdbtk-bp.c:346: (Each undeclared identifier is reported only once
./gdbtk/generic/gdbtk-bp.c:346: for each function it appears in.)
./gdbtk/generic/gdbtk-bp.c: In function `gdb_set_bp':
./gdbtk/generic/gdbtk-bp.c:459: `del' undeclared (first use in this function)
./gdbtk/generic/gdbtk-bp.c:461: `donttouch' undeclared (first use in this function)
./gdbtk/generic/gdbtk-bp.c:434: warning: `disp' might be used uninitialized in this function
./gdbtk/generic/gdbtk-bp.c: In function `gdb_set_bp_addr':
./gdbtk/generic/gdbtk-bp.c:541: `del' undeclared (first use in this function)
./gdbtk/generic/gdbtk-bp.c:543: `donttouch' undeclared (first use in this function)
./gdbtk/generic/gdbtk-bp.c:520: warning: `disp' might be used uninitialized in this function
./gdbtk/generic/gdbtk-bp.c: In function `gdb_get_tracepoint_info':
./gdbtk/generic/gdbtk-bp.c:820: structure has no member named `enabled'
make[1]: *** [gdbtk-bp.o] Error 1
make[1]: Leaving directory `/home/grante/insight+dejagnu-20010807/gdb'
make: *** [all-gdb] Error 2

-- 
Grant Edwards
grante@visi.com

Re: 20010807 won't compile for target=arm-elf

[Keith Seitz]

On Mon, 13 Aug 2001, Grant Edwards wrote:

>  gcc -c -g -O2    -I. -I. -I./config -DHAVE_CONFIG_H -I./../include/opcode -I./../readline/.. -I../bfd -I./../bfd  -I./../include -I../intl -     I./../intl  -DMI_OUT=1 -DGDBTK -DUI_OUT=1 -Wimplicit -Wreturn-type -Wcomment -Wtrigraphs -Wformat -Wparentheses -Wpointer-arith -Wuninitiali     zed  -I./../libgui/src  -I/home/grante/insight+dejagnu-20010807/itcl/itcl/generic \
>         -I/home/grante/insight+dejagnu-20010807/itcl/itk/generic -I/home/grante/insight+dejagnu-20010807/tix/generic \
> -I/home/grante/insight+dejagnu-20010807/tcl/generic -I/home/grante/insight+dejagnu-20010807/tk/generic -I/home/grante/insight+dejagnu-200108     07/tk/generic -I/usr/X11R6/include \
>         ./gdbtk/generic/gdbtk.c -DGDBTK_LIBRARY=\"/usr/local/share/gdbtcl\"
> gcc -c -g -O2    -I. -I. -I./config -DHAVE_CONFIG_H -I./../include/opcode -I./../readline/.. -I../bfd -I./../bfd  -I./../include -I../intl -     I./../intl  -DMI_OUT=1 -DGDBTK -DUI_OUT=1 -Wimplicit -Wreturn-type -Wcomment -Wtrigraphs -Wformat -Wparentheses -Wpointer-arith -Wuninitiali     zed  -I./../libgui/src  -I/home/grante/insight+dejagnu-20010807/itcl/itcl/generic \
> -I/home/grante/insight+dejagnu-20010807/tix/generic -I/home/grante/insight+dejagnu-20010807/tcl/generic -I/home/grante/insight+dejagnu-20010     807/tk/generic -I/home/grante/insight+dejagnu-20010807/tk/generic -I/usr/X11R6/include   \
>  ./gdbtk/generic/gdbtk-bp.c \
> -DGDBTK_LIBRARY=\"/usr/local/share/gdbtcl\"
> ./gdbtk/generic/gdbtk-bp.c: In function `gdb_get_breakpoint_info':
> ./gdbtk/generic/gdbtk-bp.c:346: structure has no member named `enable'
> ./gdbtk/generic/gdbtk-bp.c:346: `enabled' undeclared (first use in this function)
> ./gdbtk/generic/gdbtk-bp.c:346: (Each undeclared identifier is reported only once
> ./gdbtk/generic/gdbtk-bp.c:346: for each function it appears in.)
> ./gdbtk/generic/gdbtk-bp.c: In function `gdb_set_bp':
> ./gdbtk/generic/gdbtk-bp.c:459: `del' undeclared (first use in this function)
> ./gdbtk/generic/gdbtk-bp.c:461: `donttouch' undeclared (first use in this function)
> ./gdbtk/generic/gdbtk-bp.c:434: warning: `disp' might be used uninitialized in this function
> ./gdbtk/generic/gdbtk-bp.c: In function `gdb_set_bp_addr':
> ./gdbtk/generic/gdbtk-bp.c:541: `del' undeclared (first use in this function)
> ./gdbtk/generic/gdbtk-bp.c:543: `donttouch' undeclared (first use in this function)
> ./gdbtk/generic/gdbtk-bp.c:520: warning: `disp' might be used uninitialized in this function
> ./gdbtk/generic/gdbtk-bp.c: In function `gdb_get_tracepoint_info':
> ./gdbtk/generic/gdbtk-bp.c:820: structure has no member named `enabled'
> make[1]: *** [gdbtk-bp.o] Error 1
> make[1]: Leaving directory `/home/grante/insight+dejagnu-20010807/gdb'
> make: *** [all-gdb] Error 2

This was fixed by the following patch:

2001-08-02  Keith Seitz  <keiths@redhat.com>

        * generic/gdbtk-bp.c (gdb_get_breakpoint_info): Update
        with recent breakpoint structure changes in gdb.
        (gdb_set_bp_addr): Likewise.
        (gdb_get_tracepoint_info): Update with recent tracepoint
        structure changes in gdb.

You need to grab an updated copy of the file.

Keith

Re: 20010807 won't compile for target=arm-elf

[Grant Edwards]

On Mon, Aug 13, 2001 at 10:27:33AM -0700, Keith Seitz wrote:
> On Mon, 13 Aug 2001, Grant Edwards wrote:
> 
> >  gcc -c -g -O2    -I. -I. -I./config -DHAVE_CONFIG_H -I./../include/opcode -I./../readline/.. -I../bfd -I./../bfd  -I./../include -I../intl -     I./../intl  -DMI_OUT=1 -DGDBTK -DUI_OUT=1 -Wimplicit -Wreturn-type -Wcomment -Wtrigraphs -Wformat -Wparentheses -Wpointer-arith -Wuninitiali     zed  -I./../libgui/src  -I/home/grante/insight+dejagnu-20010807/itcl/itcl/generic \
> >         -I/home/grante/insight+dejagnu-20010807/itcl/itk/generic -I/home/grante/insight+dejagnu-20010807/tix/generic \
> > -I/home/grante/insight+dejagnu-20010807/tcl/generic -I/home/grante/insight+dejagnu-20010807/tk/generic -I/home/grante/insight+dejagnu-200108     07/tk/generic -I/usr/X11R6/include \
> >         ./gdbtk/generic/gdbtk.c -DGDBTK_LIBRARY=\"/usr/local/share/gdbtcl\"
> > gcc -c -g -O2    -I. -I. -I./config -DHAVE_CONFIG_H -I./../include/opcode -I./../readline/.. -I../bfd -I./../bfd  -I./../include -I../intl -     I./../intl  -DMI_OUT=1 -DGDBTK -DUI_OUT=1 -Wimplicit -Wreturn-type -Wcomment -Wtrigraphs -Wformat -Wparentheses -Wpointer-arith -Wuninitiali     zed  -I./../libgui/src  -I/home/grante/insight+dejagnu-20010807/itcl/itcl/generic \
> > -I/home/grante/insight+dejagnu-20010807/tix/generic -I/home/grante/insight+dejagnu-20010807/tcl/generic -I/home/grante/insight+dejagnu-20010     807/tk/generic -I/home/grante/insight+dejagnu-20010807/tk/generic -I/usr/X11R6/include   \
> >  ./gdbtk/generic/gdbtk-bp.c \
> > -DGDBTK_LIBRARY=\"/usr/local/share/gdbtcl\"
> > ./gdbtk/generic/gdbtk-bp.c: In function `gdb_get_breakpoint_info':
> > ./gdbtk/generic/gdbtk-bp.c:346: structure has no member named `enable'
> > ./gdbtk/generic/gdbtk-bp.c:346: `enabled' undeclared (first use in this function)
> > ./gdbtk/generic/gdbtk-bp.c:346: (Each undeclared identifier is reported only once
> > ./gdbtk/generic/gdbtk-bp.c:346: for each function it appears in.)
> > ./gdbtk/generic/gdbtk-bp.c: In function `gdb_set_bp':
> > ./gdbtk/generic/gdbtk-bp.c:459: `del' undeclared (first use in this function)
> > ./gdbtk/generic/gdbtk-bp.c:461: `donttouch' undeclared (first use in this function)
> > ./gdbtk/generic/gdbtk-bp.c:434: warning: `disp' might be used uninitialized in this function
> > ./gdbtk/generic/gdbtk-bp.c: In function `gdb_set_bp_addr':
> > ./gdbtk/generic/gdbtk-bp.c:541: `del' undeclared (first use in this function)
> > ./gdbtk/generic/gdbtk-bp.c:543: `donttouch' undeclared (first use in this function)
> > ./gdbtk/generic/gdbtk-bp.c:520: warning: `disp' might be used uninitialized in this function
> > ./gdbtk/generic/gdbtk-bp.c: In function `gdb_get_tracepoint_info':
> > ./gdbtk/generic/gdbtk-bp.c:820: structure has no member named `enabled'
> > make[1]: *** [gdbtk-bp.o] Error 1
> > make[1]: Leaving directory `/home/grante/insight+dejagnu-20010807/gdb'
> > make: *** [all-gdb] Error 2
> 
> This was fixed by the following patch:
> 
> 2001-08-02  Keith Seitz  <keiths@redhat.com>
> 
>         * generic/gdbtk-bp.c (gdb_get_breakpoint_info): Update
>         with recent breakpoint structure changes in gdb.
>         (gdb_set_bp_addr): Likewise.
>         (gdb_get_tracepoint_info): Update with recent tracepoint
>         structure changes in gdb.
> 
> You need to grab an updated copy of the file.

Thanks -- I'll look into it.

The 2001-08-07 snapshot doesn't include a patch dated
2001-08-02?  ;) I need to get me that kind of calender!  I
could have this project done last month and be on vacation now.

I'm reconsidering my decision to ship a package based on
a weekly snapshot.  I might just go with 5.0 + patches since
that's what I've been using for the past 7-8 months.

-- 
Grant Edwards
grante@visi.com

Re: 20010807 won't compile for target=arm-elf

[Keith Seitz]

On Mon, 13 Aug 2001, Grant Edwards wrote:

> The 2001-08-07 snapshot doesn't include a patch dated
> 2001-08-02?  ;) I need to get me that kind of calender!  I
> could have this project done last month and be on vacation now.

Hmmm. The CVS log for gdbtk-bp.c shows

revision 1.9
date: 2001/08/03 03:37:40;  author: kseitz;  state: Exp;  lines: +6 -6
        * generic/gdbtk-bp.c (gdb_get_breakpoint_info): Update
        with recent breakpoint structure changes in gdb.
        (gdb_set_bp_addr): Likewise.
        (gdb_get_tracepoint_info): Update with recent tracepoint
        structure changes in gdb.

Maybe the snapshot process didn't pick it up for some reason. ???

> I'm reconsidering my decision to ship a package based on
> a weekly snapshot.  I might just go with 5.0 + patches since
> that's what I've been using for the past 7-8 months.

FWIW, I'll be checking in a "new" register window shortly, which you may
want to avoid. I've spent a lot of time making it work, but I've only
tested it on a couple of platforms: linux native, cygwin native,
cygwin-x-[bleep] and linux-x-[bleep]. I haven't discovered any problems,
but it is a chunk of relatively new code...

I think that the 5.1 branch and the main repository are in the best shape
they've been in for quite some time -- probably best they've been ever.
(It's nice not to be distracted by work, eh?)

Also note that if you expect to use insight on win98 (heaven forbid), you
should get the patch that is in limbo in gdb right now about
sigsetjmp/siglongjmp. A problem which, unfortunately, really only shows up
in insight (although I can reproduce it in standalone gdb easily enough).

Keith

Re: 20010807 won't compile for target=arm-elf

[Andrew Cagney]

> 
> Hmmm. The CVS log for gdbtk-bp.c shows
> 
> revision 1.9
> date: 2001/08/03 03:37:40;  author: kseitz;  state: Exp;  lines: +6 -6
>         * generic/gdbtk-bp.c (gdb_get_breakpoint_info): Update
>         with recent breakpoint structure changes in gdb.
>         (gdb_set_bp_addr): Likewise.
>         (gdb_get_tracepoint_info): Update with recent tracepoint
>         structure changes in gdb.
> 
> Maybe the snapshot process didn't pick it up for some reason. ???

Depends.  The snapshot process off on a tangent (hopefully following the 
5.1 branch :-)

	Andrew