Insight windows problems.

Insight windows problems.

[Ian Roxborough]

Hi,

I'm pretty close to fixing the modal dialog problems
on Windows. The problem seem to be related to using
the "." window as a master for our transient modal windows.
I'm not sure if it's a Tk bug or what, but doing:
       wm transient $top .
will cause the $top toplevel to assume some properties
of ".", namely the mapping (or lack of it).  Actually
this may have something to do with the "wm group" a few
lines before:
       wm group $top .

Either way, changing it be:
       wm transient $top $srcwin
seems to fix the dialog problem (where $srcwin is the
path of the source window).  But now I'm seeing
(a related?) problem where after using a modal dialog
if I remove focus from Insight for two seconds Insight
will exit quickly and quietly.

If I find that the exiting problem isn't related to the
dialog problem I'll post a patch.

Ian.

Re: Insight windows problems.

[Ian Roxborough]

Hi,

This will stop the problem you are talking about:
http://sources.redhat.com/ml/insight/2001-q4/msg00160.html

You will run into a crashing problem after that (I've
posted emails about this as well).  If I get a chance I'll
post a really nasty (but short) fix which will stop the
crashing Win32 (then hopefully I'll get time to fix the
real problem (why are the combobox popup windows not being
destroy when used in a modal dialog...).

Anyway, nice to see you've got it compiled,

Ian.

Andy Hare wrote:
> 
> Ian,
> 
>     Have you found the answer to this problem, I think it sounds like the
> problem I am having with the current CVS of Insight. It builds OK now but
> the dialogs do not get displayed. For example I cannot get the target dialog
> to appear, and if I open the source I get the source selection dialog but
> after that no other input is allowed into Insight, I have to kill it via the
> task manager.
> 
> Running Windows 2K and latest cygwin.
> 
> Andy Hare
> www.ahare.btinternet.co.uk
> 
> ----- Original Message -----
> From: "Ian Roxborough" <irox@redhat.com>
> To: <insight@sources.redhat.com>
> Sent: Tuesday, October 16, 2001 9:15 PM
> Subject: Insight windows problems.
> 
> > Hi,
> >
> > I'm pretty close to fixing the modal dialog problems
> > on Windows. The problem seem to be related to using
> > the "." window as a master for our transient modal windows.
> > I'm not sure if it's a Tk bug or what, but doing:
> >        wm transient $top .
> > will cause the $top toplevel to assume some properties
> > of ".", namely the mapping (or lack of it).  Actually
> > this may have something to do with the "wm group" a few
> > lines before:
> >        wm group $top .
> >
> > Either way, changing it be:
> >        wm transient $top $srcwin
> > seems to fix the dialog problem (where $srcwin is the
> > path of the source window).  But now I'm seeing
> > (a related?) problem where after using a modal dialog
> > if I remove focus from Insight for two seconds Insight
> > will exit quickly and quietly.
> >
> > If I find that the exiting problem isn't related to the
> > dialog problem I'll post a patch.
> >
> > Ian.

Re: Insight windows problems.

[Andy Hare]

Ian,

OK so now I got the crashing problem. Running under GDB shows the following
at the point it crashes if this helps:

$ gdb -nw arm-elf-gdb
GNU gdb 5.0 (20010428-1)
Copyright 2001 Free Software Foundation, Inc.
GDB is free software, covered by the GNU General Public License, and you are
welcome to change it and/or distribute copies of it under certain
conditions.
Type "show copying" to see the conditions.
There is absolutely no warranty for GDB.  Type "show warranty" for details.
This GDB was configured as "i686-pc-cygwin"...
(gdb) run
Starting program: /xgcc-arm/gnu/bin/arm-elf-gdb.exe

Program received signal SIGSEGV, Segmentation fault.
0x00b34555 in Tk_GetHWND (window=2426298)
    at /GNU-Source-Code/src/tk/win/tkWinWindow.c:150
150         return twdPtr->window.handle;
(gdb) load
You can't do that when your target is `child'
(gdb) run
The program being debugged has been started already.
Start it from the beginning? (y or n) y

Starting program: /xgcc-arm/gnu/bin/arm-elf-gdb.exe

Program received signal SIGSEGV, Segmentation fault.
0x00b34555 in Tk_GetHWND (window=2819414)
    at /GNU-Source-Code/src/tk/win/tkWinWindow.c:150
150         return twdPtr->window.handle;
(gdb) p twdPtr
No symbol "twdPtr" in current context.
(gdb) p twdPtr->window.handle
No symbol "twdPtr" in current context.
(gdb) p window
$1 = 1348694611
(gdb)

The actual code at the crash point looks thus :

HWND
Tk_GetHWND(window)
    Window window;
{
    TkWinDrawable *twdPtr = (TkWinDrawable *) window;
    return twdPtr->window.handle;
}

so window is passed OK but GDB claims that twdPtr does not exist, surely
that can't be right can it ???

Hope this helps, if you have got any further than this then I would be
pleased to aid in any way possible.


Andy Hare
www.ahare.btinternet.co.uk




----- Original Message -----
From: "Ian Roxborough" <irox@redhat.com>
To: "Andy Hare" <ahare@btinternet.com>
Cc: <insight@sources.redhat.com>
Sent: Monday, November 19, 2001 9:21 PM
Subject: Re: Insight windows problems.


> Hi,
>
> This will stop the problem you are talking about:
> http://sources.redhat.com/ml/insight/2001-q4/msg00160.html
>
> You will run into a crashing problem after that (I've
> posted emails about this as well).  If I get a chance I'll
> post a really nasty (but short) fix which will stop the
> crashing Win32 (then hopefully I'll get time to fix the
> real problem (why are the combobox popup windows not being
> destroy when used in a modal dialog...).
>
> Anyway, nice to see you've got it compiled,
>
> Ian.
>
> Andy Hare wrote:
> >
> > Ian,
> >
> >     Have you found the answer to this problem, I think it sounds like
the
> > problem I am having with the current CVS of Insight. It builds OK now
but
> > the dialogs do not get displayed. For example I cannot get the target
dialog
> > to appear, and if I open the source I get the source selection dialog
but
> > after that no other input is allowed into Insight, I have to kill it via
the
> > task manager.
> >
> > Running Windows 2K and latest cygwin.
> >
> > Andy Hare
> > www.ahare.btinternet.co.uk
> >
> > ----- Original Message -----
> > From: "Ian Roxborough" <irox@redhat.com>
> > To: <insight@sources.redhat.com>
> > Sent: Tuesday, October 16, 2001 9:15 PM
> > Subject: Insight windows problems.
> >
> > > Hi,
> > >
> > > I'm pretty close to fixing the modal dialog problems
> > > on Windows. The problem seem to be related to using
> > > the "." window as a master for our transient modal windows.
> > > I'm not sure if it's a Tk bug or what, but doing:
> > >        wm transient $top .
> > > will cause the $top toplevel to assume some properties
> > > of ".", namely the mapping (or lack of it).  Actually
> > > this may have something to do with the "wm group" a few
> > > lines before:
> > >        wm group $top .
> > >
> > > Either way, changing it be:
> > >        wm transient $top $srcwin
> > > seems to fix the dialog problem (where $srcwin is the
> > > path of the source window).  But now I'm seeing
> > > (a related?) problem where after using a modal dialog
> > > if I remove focus from Insight for two seconds Insight
> > > will exit quickly and quietly.
> > >
> > > If I find that the exiting problem isn't related to the
> > > dialog problem I'll post a patch.
> > >
> > > Ian.

Re: Insight windows problems.

[Ian Roxborough]

Andy Hare wrote:
>
> The actual code at the crash point looks thus :
> 
> HWND
> Tk_GetHWND(window)
>     Window window;
> {
>     TkWinDrawable *twdPtr = (TkWinDrawable *) window;
>     return twdPtr->window.handle;
> }
> 
> so window is passed OK but GDB claims that twdPtr does not exist, surely
> that can't be right can it ???

Yeah it is right, the window doesn't exist (in Tk) because it's been
destroyed already (but not in win32 side).  The window causing the
crash is left over from the combobox pop list window thing.  I think
I've post more details on the problem before.
 
> Hope this helps, if you have got any further than this then I would be
> pleased to aid in any way possible.

It's really nice to see other people reproduce this problem
(it elimates me for the list of things going wrong ;-).

If you want to get around this problem you need to do the following
nastiness:

In the "ModalDialog::post" method in modal.tcl you need to change the
line at the end of the method (~line 100) which reads:

    ::delete object $this

to:
    wm withdraw [winfo toplevel [namespace tail $this]]

This will stop the crashing problem and allow people to
continue to use Insight on Windows until I've got time
to work on fixing it for real again.

I'm sorry it's ended up broken for so long.

Ian.

P.S.: On the bright side I've notice that (other than the
noted problems) Insight seems a lot more stable on Windows
than the Tcl8.0 based version (based on my observations
when comparing the two version over the last couple of months
YMMV).

Re: Insight windows problems.

[Ian Roxborough]

Andy Hare wrote:
>
> The actual code at the crash point looks thus :
> 
> HWND
> Tk_GetHWND(window)
>     Window window;
> {
>     TkWinDrawable *twdPtr = (TkWinDrawable *) window;
>     return twdPtr->window.handle;
> }
> 
> so window is passed OK but GDB claims that twdPtr does not exist, surely
> that can't be right can it ???

Yeah it is right, the window doesn't exist (in Tk) because it's been
destroyed already (but not in win32 side).  The window causing the
crash is left over from the combobox pop list window thing.  I think
I've post more details on the problem before.
 
> Hope this helps, if you have got any further than this then I would be
> pleased to aid in any way possible.

It's really nice to see other people reproduce this problem
(it elimates me for the list of things going wrong ;-).

If you want to get around this problem you need to do the following
nastiness:

In the "ModalDialog::post" method in modal.tcl you need to change the
line at the end of the method (~line 100) which reads:

    ::delete object $this

to:
    wm withdraw [winfo toplevel [namespace tail $this]]

This will stop the crashing problem and allow people to
continue to use Insight on Windows until I've got time
to work on fixing it for real again.

I'm sorry it's ended up broken for so long.

Ian.

P.S.: On the bright side I've notice that (other than the
noted problems) Insight seems a lot more stable on Windows
than the Tcl8.0 based version (based on my observations
when comparing the two version over the last couple of months
YMMV).

Re: Insight windows problems.

[Andy Hare]

Ian,

OK so now I got the crashing problem. Running under GDB shows the following
at the point it crashes if this helps:

$ gdb -nw arm-elf-gdb
GNU gdb 5.0 (20010428-1)
Copyright 2001 Free Software Foundation, Inc.
GDB is free software, covered by the GNU General Public License, and you are
welcome to change it and/or distribute copies of it under certain
conditions.
Type "show copying" to see the conditions.
There is absolutely no warranty for GDB.  Type "show warranty" for details.
This GDB was configured as "i686-pc-cygwin"...
(gdb) run
Starting program: /xgcc-arm/gnu/bin/arm-elf-gdb.exe

Program received signal SIGSEGV, Segmentation fault.
0x00b34555 in Tk_GetHWND (window=2426298)
    at /GNU-Source-Code/src/tk/win/tkWinWindow.c:150
150         return twdPtr->window.handle;
(gdb) load
You can't do that when your target is `child'
(gdb) run
The program being debugged has been started already.
Start it from the beginning? (y or n) y

Starting program: /xgcc-arm/gnu/bin/arm-elf-gdb.exe

Program received signal SIGSEGV, Segmentation fault.
0x00b34555 in Tk_GetHWND (window=2819414)
    at /GNU-Source-Code/src/tk/win/tkWinWindow.c:150
150         return twdPtr->window.handle;
(gdb) p twdPtr
No symbol "twdPtr" in current context.
(gdb) p twdPtr->window.handle
No symbol "twdPtr" in current context.
(gdb) p window
$1 = 1348694611
(gdb)

The actual code at the crash point looks thus :

HWND
Tk_GetHWND(window)
    Window window;
{
    TkWinDrawable *twdPtr = (TkWinDrawable *) window;
    return twdPtr->window.handle;
}

so window is passed OK but GDB claims that twdPtr does not exist, surely
that can't be right can it ???

Hope this helps, if you have got any further than this then I would be
pleased to aid in any way possible.


Andy Hare
www.ahare.btinternet.co.uk




----- Original Message -----
From: "Ian Roxborough" <irox@redhat.com>
To: "Andy Hare" <ahare@btinternet.com>
Cc: <insight@sources.redhat.com>
Sent: Monday, November 19, 2001 9:21 PM
Subject: Re: Insight windows problems.


> Hi,
>
> This will stop the problem you are talking about:
> http://sources.redhat.com/ml/insight/2001-q4/msg00160.html
>
> You will run into a crashing problem after that (I've
> posted emails about this as well).  If I get a chance I'll
> post a really nasty (but short) fix which will stop the
> crashing Win32 (then hopefully I'll get time to fix the
> real problem (why are the combobox popup windows not being
> destroy when used in a modal dialog...).
>
> Anyway, nice to see you've got it compiled,
>
> Ian.
>
> Andy Hare wrote:
> >
> > Ian,
> >
> >     Have you found the answer to this problem, I think it sounds like
the
> > problem I am having with the current CVS of Insight. It builds OK now
but
> > the dialogs do not get displayed. For example I cannot get the target
dialog
> > to appear, and if I open the source I get the source selection dialog
but
> > after that no other input is allowed into Insight, I have to kill it via
the
> > task manager.
> >
> > Running Windows 2K and latest cygwin.
> >
> > Andy Hare
> > www.ahare.btinternet.co.uk
> >
> > ----- Original Message -----
> > From: "Ian Roxborough" <irox@redhat.com>
> > To: <insight@sources.redhat.com>
> > Sent: Tuesday, October 16, 2001 9:15 PM
> > Subject: Insight windows problems.
> >
> > > Hi,
> > >
> > > I'm pretty close to fixing the modal dialog problems
> > > on Windows. The problem seem to be related to using
> > > the "." window as a master for our transient modal windows.
> > > I'm not sure if it's a Tk bug or what, but doing:
> > >        wm transient $top .
> > > will cause the $top toplevel to assume some properties
> > > of ".", namely the mapping (or lack of it).  Actually
> > > this may have something to do with the "wm group" a few
> > > lines before:
> > >        wm group $top .
> > >
> > > Either way, changing it be:
> > >        wm transient $top $srcwin
> > > seems to fix the dialog problem (where $srcwin is the
> > > path of the source window).  But now I'm seeing
> > > (a related?) problem where after using a modal dialog
> > > if I remove focus from Insight for two seconds Insight
> > > will exit quickly and quietly.
> > >
> > > If I find that the exiting problem isn't related to the
> > > dialog problem I'll post a patch.
> > >
> > > Ian.

Re: Insight windows problems.

[Ian Roxborough]

Hi,

This will stop the problem you are talking about:
http://sources.redhat.com/ml/insight/2001-q4/msg00160.html

You will run into a crashing problem after that (I've
posted emails about this as well).  If I get a chance I'll
post a really nasty (but short) fix which will stop the
crashing Win32 (then hopefully I'll get time to fix the
real problem (why are the combobox popup windows not being
destroy when used in a modal dialog...).

Anyway, nice to see you've got it compiled,

Ian.

Andy Hare wrote:
> 
> Ian,
> 
>     Have you found the answer to this problem, I think it sounds like the
> problem I am having with the current CVS of Insight. It builds OK now but
> the dialogs do not get displayed. For example I cannot get the target dialog
> to appear, and if I open the source I get the source selection dialog but
> after that no other input is allowed into Insight, I have to kill it via the
> task manager.
> 
> Running Windows 2K and latest cygwin.
> 
> Andy Hare
> www.ahare.btinternet.co.uk
> 
> ----- Original Message -----
> From: "Ian Roxborough" <irox@redhat.com>
> To: <insight@sources.redhat.com>
> Sent: Tuesday, October 16, 2001 9:15 PM
> Subject: Insight windows problems.
> 
> > Hi,
> >
> > I'm pretty close to fixing the modal dialog problems
> > on Windows. The problem seem to be related to using
> > the "." window as a master for our transient modal windows.
> > I'm not sure if it's a Tk bug or what, but doing:
> >        wm transient $top .
> > will cause the $top toplevel to assume some properties
> > of ".", namely the mapping (or lack of it).  Actually
> > this may have something to do with the "wm group" a few
> > lines before:
> >        wm group $top .
> >
> > Either way, changing it be:
> >        wm transient $top $srcwin
> > seems to fix the dialog problem (where $srcwin is the
> > path of the source window).  But now I'm seeing
> > (a related?) problem where after using a modal dialog
> > if I remove focus from Insight for two seconds Insight
> > will exit quickly and quietly.
> >
> > If I find that the exiting problem isn't related to the
> > dialog problem I'll post a patch.
> >
> > Ian.