* [patch] REGISTER_RAW_SIZE => DEPRECATED_REGISTER_RAW_SIZE
@ 2003-10-06 16:34 David Carlton
2003-10-06 18:30 ` Andrew Cagney
0 siblings, 1 reply; 4+ messages in thread
From: David Carlton @ 2003-10-06 16:34 UTC (permalink / raw)
To: insight
Andrew's latest deprecation missed occurrences in insight. Andrew,
can you please test these patches on a tree containing insight? And
if the insight people were to get around to making it possible to
build GDB in a tree containing insight, even if there are compilation
problems on the insight side, that would be greatly appreciated as
well.
Committed as obvious.
David Carlton
carlton@kealia.com
2003-10-06 David Carlton <carlton@kealia.com>
* generic/gdbtk-register.c (get_register_size): Replace
REGISTER_RAW_SIZE by DEPRECATED_REGISTER_RAW_SIZE.
(get_register, register_changed_p): Ditto.
Index: gdbtk-register.c
===================================================================
RCS file: /cvs/src/src/gdb/gdbtk/generic/gdbtk-register.c,v
retrieving revision 1.21
diff -u -p -r1.21 gdbtk-register.c
--- gdbtk-register.c 30 Sep 2003 23:10:55 -0000 1.21
+++ gdbtk-register.c 6 Oct 2003 16:30:05 -0000
@@ -202,7 +202,8 @@ static void
get_register_size (int regnum, void *arg)
{
Tcl_ListObjAppendElement (gdbtk_interp, result_ptr->obj_ptr,
- Tcl_NewIntObj (REGISTER_RAW_SIZE (regnum)));
+ Tcl_NewIntObj (DEPRECATED_REGISTER_RAW_SIZE
+ (regnum)));
}
/* returns a list of valid types for a register */
@@ -321,10 +322,10 @@ get_register (int regnum, void *arg)
strcpy (buf, "0x");
ptr = buf + 2;
- for (j = 0; j < REGISTER_RAW_SIZE (regnum); j++)
+ for (j = 0; j < DEPRECATED_REGISTER_RAW_SIZE (regnum); j++)
{
int idx = TARGET_BYTE_ORDER == BFD_ENDIAN_BIG ? j
- : REGISTER_RAW_SIZE (regnum) - 1 - j;
+ : DEPRECATED_REGISTER_RAW_SIZE (regnum) - 1 - j;
sprintf (ptr, "%02x", (unsigned char) raw_buffer[idx]);
ptr += 2;
}
@@ -447,13 +448,13 @@ register_changed_p (int regnum, void *ar
return;
if (memcmp (&old_regs[regnum * MAX_REGISTER_SIZE], raw_buffer,
- REGISTER_RAW_SIZE (regnum)) == 0)
+ DEPRECATED_REGISTER_RAW_SIZE (regnum)) == 0)
return;
/* Found a changed register. Save new value and return its number. */
memcpy (&old_regs[regnum * MAX_REGISTER_SIZE], raw_buffer,
- REGISTER_RAW_SIZE (regnum));
+ DEPRECATED_REGISTER_RAW_SIZE (regnum));
Tcl_ListObjAppendElement (NULL, result_ptr->obj_ptr, Tcl_NewIntObj (regnum));
}
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [patch] REGISTER_RAW_SIZE => DEPRECATED_REGISTER_RAW_SIZE
2003-10-06 16:34 [patch] REGISTER_RAW_SIZE => DEPRECATED_REGISTER_RAW_SIZE David Carlton
@ 2003-10-06 18:30 ` Andrew Cagney
2003-10-06 19:49 ` David Carlton
0 siblings, 1 reply; 4+ messages in thread
From: Andrew Cagney @ 2003-10-06 18:30 UTC (permalink / raw)
To: David Carlton; +Cc: insight
> Andrew's latest deprecation missed occurrences in insight. Andrew,
> can you please test these patches on a tree containing insight? And
> if the insight people were to get around to making it possible to
> build GDB in a tree containing insight, even if there are compilation
> problems on the insight side, that would be greatly appreciated as
> well.
Don't forget that Insight isn't part of GDB so there's no obligation on
the part of GDB's FSF maintainers - you included - to keep Insight
building. I do it if I remember. However, I don't do it by default as
it adds a significant drain to my volunteer FSF time.
Perhaphs Red Hat will finally contribute Insight to the FSF?
Andrew
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [patch] REGISTER_RAW_SIZE => DEPRECATED_REGISTER_RAW_SIZE
2003-10-06 18:30 ` Andrew Cagney
@ 2003-10-06 19:49 ` David Carlton
2003-10-06 21:24 ` Andrew Cagney
0 siblings, 1 reply; 4+ messages in thread
From: David Carlton @ 2003-10-06 19:49 UTC (permalink / raw)
To: Andrew Cagney; +Cc: insight
On Mon, 06 Oct 2003 14:30:45 -0400, Andrew Cagney <ac131313@redhat.com> said:
>> Andrew's latest deprecation missed occurrences in insight. Andrew,
>> can you please test these patches on a tree containing insight? And
>> if the insight people were to get around to making it possible to
>> build GDB in a tree containing insight, even if there are compilation
>> problems on the insight side, that would be greatly appreciated as
>> well.
> Don't forget that Insight isn't part of GDB so there's no obligation
> on the part of GDB's FSF maintainers - you included - to keep Insight
> building.
Really? There's no separate COPYING file, the README doesn't give any
indication that that's the case, and I just looked at the copyright
header for a couple of random files in gdbtk/generic, both of which
assign copyright to the FSF and claim that the file in question is
part of GDB.
Hmm, but digging further, the stuff in library/ has Cygnus/Red Hat
copyright info on it. That's confusing.
> Perhaphs Red Hat will finally contribute Insight to the FSF?
That would be the easiest way to remove the confusion.
David Carlton
carlton@kealia.com
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [patch] REGISTER_RAW_SIZE => DEPRECATED_REGISTER_RAW_SIZE
2003-10-06 19:49 ` David Carlton
@ 2003-10-06 21:24 ` Andrew Cagney
0 siblings, 0 replies; 4+ messages in thread
From: Andrew Cagney @ 2003-10-06 21:24 UTC (permalink / raw)
To: David Carlton; +Cc: insight
> Hmm, but digging further, the stuff in library/ has Cygnus/Red Hat
> copyright info on it. That's confusing.
There's no paper trail showing that Red Hat transfered the program
"Insight" to the FSF. Yes, it's confusing.
Andrew
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2003-10-06 21:24 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2003-10-06 16:34 [patch] REGISTER_RAW_SIZE => DEPRECATED_REGISTER_RAW_SIZE David Carlton
2003-10-06 18:30 ` Andrew Cagney
2003-10-06 19:49 ` David Carlton
2003-10-06 21:24 ` Andrew Cagney
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).