[PATCH] Add new browsers for help

[PATCH] Add new browsers for help

[Andrew STUBBS]

[-- Attachment #1: Type: text/plain, Size: 319 bytes --]

Hi,

The attached patch adds Firefox and Opera to the list of browsers 
Insight may use to display help.

I have added them before Mozilla on the grounds that, if installed, they 
are usually used in preference. Obviously there will be somebody who 
doesn't, but this seems the most likely choice to me.

Andrew Stubbs

[-- Attachment #2: browser.patch --]
[-- Type: text/plain, Size: 1005 bytes --]

2006-01-06  Andrew Stubbs  <andrew.stubbs@st.com>

	* library/helpviewer.tcl (open_help): Add firefox and opera to the
	browser list used to display help.

Index: src/gdb/gdbtk/library/helpviewer.tcl
===================================================================
--- src.orig/gdb/gdbtk/library/helpviewer.tcl	2006-01-03 18:23:57.000000000 +0000
+++ src/gdb/gdbtk/library/helpviewer.tcl	2006-01-06 18:22:40.000000000 +0000
@@ -36,13 +36,13 @@ proc open_help {hfile} {
   # set list of viewer apps to try
   switch [pref get gdb/compat] {
     "KDE" {
-      set apps {htmlview khelpcenter mozilla}
+      set apps {htmlview khelpcenter firefox opera mozilla}
     }
     "GNOME" {
-      set apps {htmlview mozilla gnome-help khelpcenter}
+      set apps {htmlview firefox opera mozilla gnome-help khelpcenter}
     }      
     default {
-      set apps {htmlview mozilla gnome-help khelpcenter netscape}
+      set apps {htmlview firefox opera mozilla gnome-help khelpcenter netscape}
     }
   }
 

Re: [PATCH] Add new browsers for help

[Keith Seitz]

Hi,

Just running through my inbox...

I don't know if I ever mentioned it, but I did actually commit this 
patch in January.

Thanks again for the patch.

Keith

Andrew STUBBS wrote:
> Hi,
> 
> The attached patch adds Firefox and Opera to the list of browsers 
> Insight may use to display help.
> 
> I have added them before Mozilla on the grounds that, if installed, they 
> are usually used in preference. Obviously there will be somebody who 
> doesn't, but this seems the most likely choice to me.
> 
> Andrew Stubbs
> 
> 
> ------------------------------------------------------------------------
> 
> 2006-01-06  Andrew Stubbs  <andrew.stubbs@st.com>
> 
> 	* library/helpviewer.tcl (open_help): Add firefox and opera to the
> 	browser list used to display help.
> 
> Index: src/gdb/gdbtk/library/helpviewer.tcl
> ===================================================================
> --- src.orig/gdb/gdbtk/library/helpviewer.tcl	2006-01-03 18:23:57.000000000 +0000
> +++ src/gdb/gdbtk/library/helpviewer.tcl	2006-01-06 18:22:40.000000000 +0000
> @@ -36,13 +36,13 @@ proc open_help {hfile} {
>    # set list of viewer apps to try
>    switch [pref get gdb/compat] {
>      "KDE" {
> -      set apps {htmlview khelpcenter mozilla}
> +      set apps {htmlview khelpcenter firefox opera mozilla}
>      }
>      "GNOME" {
> -      set apps {htmlview mozilla gnome-help khelpcenter}
> +      set apps {htmlview firefox opera mozilla gnome-help khelpcenter}
>      }      
>      default {
> -      set apps {htmlview mozilla gnome-help khelpcenter netscape}
> +      set apps {htmlview firefox opera mozilla gnome-help khelpcenter netscape}
>      }
>    }
>